View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
16914Bug reportsSurvey takingpublic2021-03-29 12:31
ReporterDenisChenu Assigned Togabrieljenik  
PriorityhighSeverityminor 
Status closedResolutionfixed 
Product Version4.3.31 
Summary16914: Check if localization-related options are correctly imported.
Description

Example: In 3.X : we have Question validation tip AND sub-Question validation tip
We loose sub-Question validation tip

Steps To Reproduce

Check both screen

Additional Information

Same in develop (currently) (4.4.0-alpha)

TagsNo tags attached.
Attached Files
Bug heat8
Complete LimeSurvey version number (& build) 4.3.30
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

cdorin

cdorin

2020-12-21 10:32

reporter   ~61012

@DenisChenu - it works for me now. Only that the language-related settings are now displayed only once per "page" . To choose English, select English tab. To choose German, select German tab. Can you please test if it's working fine in latest develop?

DenisChenu

DenisChenu

2020-12-21 10:40

developer   ~61013

Last edited: 2020-12-21 12:44

Ah OK … let me check.

There still an issue when import : attached file : after import only FR is here (for both language)
To be reported or stay here ?

Manual must be clear on that ;)

cdorin

cdorin

2020-12-21 12:43

reporter   ~61015

Last edited: 2020-12-21 12:44

Let's keep the issue here. I will just edit the title of the issue and have it assigned

gabrieljenik

gabrieljenik

2021-03-25 17:10

manager   ~63620

XMLImportSurvey tried to set the language for the question attributes properly, but the QuestionAttribute model didn't have a validator for 'language' field, making it "unsafe". So, the 'language' attribute was silently omitted and all question attributes ended up being saved without language.

PR: https://github.com/LimeSurvey/LimeSurvey/pull/1818

gabrieljenik

gabrieljenik

2021-03-26 09:23

manager   ~63643

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31396

lime_release_bot

lime_release_bot

2021-03-29 12:31

administrator   ~63684

Fixed in Release 4.4.15+210329

Related Changesets

LimeSurvey: master ac766798

2021-03-26 09:23:32

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 16914: Check if localization-related options are correctly imported. (#1818)

Dev XMLImportSurvey tried to set the language for the question attributes properly, but the QuestionAttribute model didn't have a validator for 'language' field, making it "unsafe". So, the 'language' attribute was silently omitted and all question attributes ended up being saved without language.
Affected Issues
16914
mod - application/models/QuestionAttribute.php Diff File

Issue History

Date Modified Username Field Change
2020-12-15 15:02 DenisChenu New Issue
2020-12-15 15:02 DenisChenu File Added: limesurvey_survey_i18n.lss
2020-12-15 15:02 DenisChenu File Added: Capture d’écran du 2020-12-15 15-00-30.png
2020-12-15 15:02 DenisChenu File Added: Capture d’écran du 2020-12-15 15-00-41.png
2020-12-15 15:02 DenisChenu File Added: Capture d’écran du 2020-12-15 15-01-25.png
2020-12-21 10:32 cdorin Note Added: 61012
2020-12-21 10:33 cdorin Status new => feedback
2020-12-21 10:40 DenisChenu Note Added: 61013
2020-12-21 10:40 DenisChenu File Added: limesurvey_survey_i18n-2.lss
2020-12-21 10:40 DenisChenu Status feedback => new
2020-12-21 12:43 cdorin Note Added: 61015
2020-12-21 12:44 cdorin Status new => confirmed
2020-12-21 12:44 cdorin Summary Loose sub-question validation tip for long text question => Check if localization-related options are correctly imported.
2020-12-21 12:44 cdorin Description Updated
2020-12-21 12:44 cdorin Sync to Zoho Project => |Yes|
2020-12-21 12:44 cdorin Priority none => high
2020-12-21 12:44 cdorin Sync to Zoho Project Yes => |Yes|
2021-03-25 17:10 gabrieljenik Note Added: 63620
2021-03-26 09:23 c_schmitz Assigned To => c_schmitz
2021-03-26 09:23 c_schmitz Status confirmed => resolved
2021-03-26 09:23 c_schmitz Resolution open => fixed
2021-03-26 09:23 gabrieljenik Changeset attached => LimeSurvey master ac766798
2021-03-26 09:23 gabrieljenik Note Added: 63643
2021-03-26 09:23 gabrieljenik Assigned To c_schmitz => gabrieljenik
2021-03-29 12:31 lime_release_bot Sync to Zoho Project Yes => |Yes|
2021-03-29 12:31 lime_release_bot Note Added: 63684
2021-03-29 12:31 lime_release_bot Status resolved => closed