View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
16896Bug reportsOtherpublic2020-12-28 10:42
Reportercdorin Assigned Togabrieljenik  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version4.x.0-dev 
Summary16896: Javascript shown when editing subquestions
Description

problem with encoding? To be checked

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)Latest develop 4.4.0-alpha
I will donate to the project if issue is resolvedNo
Browser
Database type & versionirrelevant
Server OS (if known)
Webserver software & version (if known)
PHP Versionirrelevant

Relationships

related to 16904 closedgabrieljenik Check attributes are escaped properly 

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2020-12-11 14:57

manager   ~60926

Last edited: 2020-12-11 15:06

PR: https://github.com/LimeSurvey/LimeSurvey/pull/1686

The HTML breaks when the subquestion's text contains double quotes (").
Added "escape('html_attr')" to subquestion text and code (subquestionRow.twig).
It seems the same happens with other fields (like the "Array filter" attribute, just to mention one).

lime_release_bot

lime_release_bot

2020-12-28 10:42

administrator   ~61180

Fixed in Release 4.4.0-RC1+201223

Issue History

Date Modified Username Field Change
2020-12-10 15:55 cdorin New Issue
2020-12-10 15:55 cdorin Status new => assigned
2020-12-10 15:55 cdorin Assigned To => gabrieljenik
2020-12-11 14:53 gabrieljenik Issue cloned: 16904
2020-12-11 14:53 gabrieljenik Relationship added related to 16904
2020-12-11 14:57 gabrieljenik Note Added: 60926
2020-12-11 15:06 gabrieljenik Note Edited: 60926
2020-12-28 10:42 lime_release_bot Sync to Zoho Project Yes => |Yes|
2020-12-28 10:42 lime_release_bot Note Added: 61180
2020-12-28 10:42 lime_release_bot Status assigned => closed
2020-12-28 10:42 lime_release_bot Resolution open => fixed