View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|16482||Bug reports||Survey taking||public||2020-07-10 09:30||2021-01-12 17:55|
|Summary||16482: Prefill value broke survey policy (and GPDR ?)|
|Description||Add a prefill value create survey before it was started, then without Survey policy was accepted|
|Steps To Reproduce||Import included survey|
Copy start link
Open a private browsing
Paste survey start link
Look at response : no response : OK
Open another private browsing
Add &uid=ID to start link
Paste update start link : see checkbox about policy not checked
Return to browse response : see the response created
|Additional Information||My opinion|
- Don't fix in 3.X since it was something old
- Use prefiilling like 'defaultvalue' : https://github.com/LimeSurvey/LimeSurvey/blob/62d9f87309d0b6d7731ac003408d501a6844b8a3/application/helpers/expressions/em_manager_helper.php#L7074
Then prefill value are set only at good step :)
|Tags||No tags attached.|
|Complete LimeSurvey version number (& build)||3.22.25|
|I will donate to the project if issue is resolved||No|
|Database & DB-Version||not relevant|
|Server OS (if known)||not relevant ?|
|Webserver software & version (if known)||not relevant ?|
|PHP Version||not relevant ?|
limesurvey_survey_prefilltest.lss (15,452 bytes)
@ollehar & @cdorin : i think i can take some time on this issue? What do you think about _not fixing in 3LTS_ ? I think update and move it only after like **default_value** is the best solution.
But then : it can update some survey behaviour, maybe some user use it to know someone click on a link …
|I muts check if https://github.com/LimeSurvey/LimeSurvey/commit/cb2424333afee56810cf9f91ee8e8a2bda24e644 didn't create this issue …|
git checkout afcb6572b5fa5a843265b643390307dacad1291e
Check : still happen :)
> Use prefiilling like 'defaultvalue' :
I understand that your idea, is setting the prefill value as default value. Then the question validation will save the value on the DB.
Is that correct?
Sorry, not too fan of that idea.
Why not setting the prefill values to the starting values at the very beggining.
Starting values are already being saved well, right?
(I mean starting values don't show the issue, right? From the code I think they do)
> I understand that your idea, is setting the prefill value as default value. Then the question validation will save the value on the DB.
Yes, but right : it something to mind : only when question are shown (or step are done) …
Something to check too : prefiled value must be deleted when `step` of question happen and relevance is 0 ;) i think it's the case currently.
> Why not setting the prefill values to the starting values at the very beggining.
Because it broke survey policy
> Starting values are already being saved well, right?
on 3.22.25 : saved too soon (survey not started)
> (I mean starting values don't show the issue, right? From the code I think they do)
|2020-07-10 09:30||DenisChenu||New Issue|
|2020-07-10 09:30||DenisChenu||File Added: limesurvey_survey_prefilltest.lss|
|2020-07-10 09:30||DenisChenu||File Added: Capture d’écran du 2020-07-10 09-27-15.png|
|2020-07-10 09:31||DenisChenu||Relationship added||child of 16481|
|2020-07-16 09:39||DenisChenu||Note Added: 58968|
|2020-07-16 11:27||DenisChenu||Note Added: 58969|
|2020-07-16 11:30||DenisChenu||Note Added: 58970|
|2021-01-12 17:42||gabrieljenik||Note Added: 61504|
|2021-01-12 17:55||DenisChenu||Note Added: 61505|