View Issue Details

IDProjectCategoryView StatusLast Update
16442Bug reportsTheme editorpublic2020-07-25 11:02
ReporterDenisChenu Assigned To 
PrioritynoneSeveritypartial_block 
Status newResolutionopen 
Product Version4.3.2 
Summary16442: Unable to use string with "on" in theme option label
Description

In theme config : if you try to use 'on' string on some label it was translated to Yes directly.
Even for none or contrast for example

Steps To Reproduce

Import https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla or https://dl.sondages.pro/skelvanilla.zip

Install in 4.X
For Survey : since it take parent see screen

Additional Information

Issue here : https://github.com/LimeSurvey/LimeSurvey/blob/67053bb60910b811e488a89ace7562442a8ae8ba/application/models/TemplateConfiguration.php#L1584-L1592

Must check if

  1. It's a label (here apply to any option)
  2. Only for $value === 'on' not inside

But more : translation must come from Theme , not from core. No way for Theme to really translate.

TagsNo tags attached.
Complete LimeSurvey version number (& build)4.3.2 github
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database & DB-Versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Activities

DenisChenu

DenisChenu

2020-07-01 09:51

developer  

DenisChenu

DenisChenu

2020-07-01 16:14

developer   ~58621

https://github.com/LimeSurvey/LimeSurvey/pull/1460

ollehar

ollehar

2020-07-15 12:20

administrator   ~58953

Hey Denis, can you be a little bit more precise in "Steps To Reproduce" so our QA-team can reproduce it? Thank you!

DenisChenu

DenisChenu

2020-07-15 12:32

developer   ~58954

Import https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla or https://dl.sondages.pro/skelvanilla.zip

Since core theme didn't use this function : need a updated theme. In fact : it's the major issue, the function is not used by core, only for user theme. Then : it broke user theme, not core theme …

Peek-15-07-2020-12-27.md.gif

global-skelvanilla.png (73,855 bytes)   
global-skelvanilla.png (73,855 bytes)   
survey-skelvanilla.png (61,915 bytes)   
survey-skelvanilla.png (61,915 bytes)   
DenisChenu

DenisChenu

2020-07-15 12:33

developer   ~58955

Since gifyu image didn't work https://gifyu.com/image/QZDF

DenisChenu

DenisChenu

2020-07-25 11:02

developer   ~59087

In fact : never transform any string …
https://hitchdev.com/strictyaml/why/implicit-typing-removed/

Issue History

Date Modified Username Field Change
2020-07-01 09:51 DenisChenu New Issue
2020-07-01 09:51 DenisChenu File Added: Capture d’écran du 2020-07-01 09-43-59.png
2020-07-01 10:02 DenisChenu Summary Unable to use string with "on" in label => Unable to use string with "on" in theme option label
2020-07-01 16:14 DenisChenu Note Added: 58621
2020-07-15 12:20 ollehar Note Added: 58953
2020-07-15 12:20 ollehar Status new => feedback
2020-07-15 12:32 DenisChenu Note Added: 58954
2020-07-15 12:32 DenisChenu File Added: global-skelvanilla.png
2020-07-15 12:32 DenisChenu File Added: survey-skelvanilla.png
2020-07-15 12:32 DenisChenu Status feedback => new
2020-07-15 12:33 DenisChenu Note Added: 58955
2020-07-21 15:18 DenisChenu Severity minor => partial_block
2020-07-25 11:02 DenisChenu Note Added: 59087