15879: Plugin menu events not implemented in V4 - LimeSurvey bugs and feature requests

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

15879	Bug reports	Plugins	public	2020-02-14 16:32	2020-02-24 17:31

Reporter	gabrieljenik	Assigned To	ollehar
Priority	urgent	Severity	partial_block
Status	closed	Resolution	fixed
Product Version	4.1.1

Summary	15879: Plugin menu events not implemented in V4
Description	The following events does'nt seem to be implemented on LSv4 yet. https://manual.limesurvey.org/BeforeToolsMenuRender https://manual.limesurvey.org/BeforeSurveyBarRender
Tags	No tags attached.

Bug heat	10
Complete LimeSurvey version number (& build)	Version 4.1.4+200214
I will donate to the project if issue is resolved	No
Browser
Database type & version	Mysql
Server OS (if known)
Webserver software & version (if known)
PHP Version	7

User List	DenisChenu

Mazi 2020-02-17 09:38 updater ~56042	@cdorin, please let us know why previously supported plugin events are suddenly not supported at Limesurvey 4 anymore. This is a regression which can break systems/pluigns if someone updates to LS 4.

ollehar 2020-02-17 11:14 administrator ~56045 Last edited: 2020-02-17 11:14	Related to moving views from PHP/Twig to VueJS.

ollehar 2020-02-17 11:45 administrator ~56054	Maybe refit the events by pushing buttons to VueJS using Ajax?

ollehar 2020-02-17 17:59 administrator ~56059	Commits are in branch bug/15879-plugin-menu-events-not-implemented-in-V4

ollehar 2020-02-17 17:59 administrator ~56060	Please test

gabrieljenik 2020-02-19 15:55 manager ~56097	Worked out good! Thanks

ollehar 2020-02-20 17:05 administrator ~56110	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29606

lime_release_bot 2020-02-24 17:31 administrator ~56185	Fixed in Release 4.1.7+200224

LimeSurvey: master a9525cdd 2020-02-17 17:33 ollehar Details Diff	Fixed issue 15879: Plugin menu events not implemented in V4	Affected Issues 15879
	mod - application/controllers/admin/surveyadmin.php	Diff File
	mod - application/core/Survey_Common_Action.php	Diff File
	mod - application/views/admin/survey/topbar/survey_topbar.php	Diff File
LimeSurvey: master fe349f0a 2020-02-17 18:28 ollehar Details Diff	Fixed issue 15879: Plugin menu events not implemented in V4	Affected Issues 15879
	mod - application/controllers/admin/surveyadmin.php	Diff File
	mod - application/views/admin/survey/topbar/survey_topbar.php	Diff File

Date Modified	Username	Field	Change
2020-02-14 16:32	gabrieljenik	New Issue
2020-02-14 16:48	DenisChenu	Issue Monitored: DenisChenu
2020-02-15 14:14	cdorin	Assigned To	=> cdorin
2020-02-15 14:14	cdorin	Status	new => assigned
2020-02-17 09:38	Mazi	Note Added: 56042
2020-02-17 11:14	ollehar	Note Added: 56045
2020-02-17 11:14	ollehar	Note Edited: 56045
2020-02-17 11:44	ollehar	Priority	none => urgent
2020-02-17 11:45	ollehar	Note Added: 56054
2020-02-17 17:59	ollehar	Status	assigned => ready for testing
2020-02-17 17:59	ollehar	Note Added: 56059
2020-02-17 17:59	ollehar	Note Added: 56060
2020-02-19 15:55	gabrieljenik	Note Added: 56097
2020-02-20 17:05	ollehar	Changeset attached	=> LimeSurvey master fe349f0a
2020-02-20 17:05	ollehar	Changeset attached	=> LimeSurvey master a9525cdd
2020-02-20 17:05	ollehar	Note Added: 56110
2020-02-20 17:05	ollehar	Assigned To	cdorin => ollehar
2020-02-20 17:05	ollehar	Resolution	open => fixed
2020-02-24 14:48	ollehar	Status	ready for testing => resolved
2020-02-24 17:31	lime_release_bot	Note Added: 56185
2020-02-24 17:31	lime_release_bot	Status	resolved => closed
2021-08-04 04:37	guest	Bug heat	8 => 10