View Issue Details

IDProjectCategoryView StatusLast Update
14934Bug reports[All Projects] Theme editorpublic2019-05-29 16:39
ReporterDenisChenu Assigned Todominikvitt  
PrioritynoneSeveritymajor 
Status closedResolutionfixed 
Product Version3.17.x 
Target VersionFixed in Version3.17.x 
Summary14934: Survey theme options reset to default
Description

the theme option like color, or container are taken from default

Steps To Reproduce

Import include survey, check the beautifull color io choose in options, test the survey

Additional Information

Commit that broke : https://github.com/LimeSurvey/LimeSurvey/commit/dbd5d40cf1ce42fbf6c37e219c35b3a6ec561948

My opinion : this must never be set in twig since Template must be set before calling twig … then in controller

TagsNo tags attached.
Complete LimeSurvey version number (& build)3.17.2 github
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database & DB-Versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

related to 14255 closeddominikvitt Current global theme option didn't update preview 

Activities

DenisChenu

DenisChenu

2019-05-24 00:15

developer  

limesurvey_survey_themeOptionsResetted.lss (19,235 bytes)
dominikvitt

dominikvitt

2019-05-24 17:40

developer   ~52108

https://github.com/LimeSurvey/LimeSurvey/commit/1d4f8d3b6500318d6bd3ab7046b862c473ec2657

c_schmitz

c_schmitz

2019-05-29 16:12

administrator   ~52167

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=28876

c_schmitz

c_schmitz

2019-05-29 16:39

administrator   ~52210

Version 3.17.4+190529 released

Related Changesets

LimeSurvey: master 1d4f8d3b

2019-05-24 17:40:06

Dominik Vitt

Details Diff
Fixed issue 14934: Survey theme options are reset to default values Affected Issues
14934
mod - application/core/LSETwigViewRenderer.php Diff File

Issue History

Date Modified Username Field Change
2019-05-24 00:15 DenisChenu New Issue
2019-05-24 00:15 DenisChenu Status new => assigned
2019-05-24 00:15 DenisChenu Assigned To => dominikvitt
2019-05-24 00:15 DenisChenu File Added: limesurvey_survey_themeOptionsResetted.lss
2019-05-24 00:20 DenisChenu Relationship added related to 14255
2019-05-24 17:40 dominikvitt Status assigned => resolved
2019-05-24 17:40 dominikvitt Resolution open => fixed
2019-05-24 17:40 dominikvitt Fixed in Version => 3.17.x
2019-05-24 17:40 dominikvitt Note Added: 52108
2019-05-29 16:12 Changeset attached => LimeSurvey master 1d4f8d3b
2019-05-29 16:12 c_schmitz Note Added: 52167
2019-05-29 16:39 c_schmitz Note Added: 52210
2019-05-29 16:39 c_schmitz Status resolved => closed