14749: Unable to move questions - LimeSurvey bugs and feature requests

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

14749	Bug reports	Survey editing	public	2019-04-06 14:57	2020-03-09 15:36

Reporter	DenisChenu	Assigned To	~~dominikvitt~~
Priority	none	Severity	minor
Status	closed	Resolution	fixed
Product Version	4.0.0dev
Fixed in Version	4.0.0-beta

Summary	14749: Unable to move questions
Description	See screenshot
Additional Information	Move to organize question, move one question, save and see what happen
Tags	No tags attached.
Attached Files	Capture d’écran du 2019-04-06 14-54-30.png (36,646 bytes) Capture d’écran du 2019-04-06 14-54-30.png (36,646 bytes) Error.html (19,134 bytes) <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"><head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <title>Error</title> <style type="text/css"> /<![CDATA[/ html,body,div,span,applet,object,iframe,h1,h2,h3,h4,h5,h6,p,blockquote,pre,a,abbr,acronym,address,big,cite,code,del,dfn,em,font,img,ins,kbd,q,s,samp,small,strike,strong,sub,sup,tt,var,b,u,i,center,dl,dt,dd,ol,ul,li,fieldset,form,label,legend,table,caption,tbody,tfoot,thead,tr,th,td{border:0;outline:0;font-size:100%;vertical-align:baseline;background:transparent;margin:0;padding:0;} body{line-height:1;} ol,ul{list-style:none;} blockquote,q{quotes:none;} blockquote:before,blockquote:after,q:before,q:after{content:none;} :focus{outline:0;} ins{text-decoration:none;} del{text-decoration:line-through;} table{border-collapse:collapse;border-spacing:0;} body { font: normal 9pt "Verdana"; color: #000; background: #fff; } h1 { font: normal 18pt "Verdana"; color: #f00; margin-bottom: .5em; } h2 { font: normal 14pt "Verdana"; color: #800000; margin-bottom: .5em; } h3 { font: bold 11pt "Verdana"; } pre { font: normal 11pt Menlo, Consolas, "Lucida Console", Monospace; } pre span.error { display: block; background: #fce3e3; } pre span.ln { color: #999; padding-right: 0.5em; border-right: 1px solid #ccc; } pre span.error-ln { font-weight: bold; } .container { margin: 1em 4em; } .version { color: gray; font-size: 8pt; border-top: 1px solid #aaa; padding-top: 1em; margin-bottom: 1em; } .message { color: #000; padding: 1em; font-size: 11pt; background: #f3f3f3; -webkit-border-radius: 10px; -moz-border-radius: 10px; border-radius: 10px; margin-bottom: 1em; line-height: 160%; } .source { margin-bottom: 1em; } .code pre { background-color: #ffe; margin: 0.5em 0; padding: 0.5em; line-height: 125%; border: 1px solid #eee; } .source .file { margin-bottom: 1em; font-weight: bold; } .traces { margin: 2em 0; } .trace { margin: 0.5em 0; padding: 0.5em; } .trace.app { border: 1px dashed #c00; } .trace .number { text-align: right; width: 2em; padding: 0.5em; } .trace .content { padding: 0.5em; } .trace .plus, .trace .minus { display:inline; vertical-align:middle; text-align:center; border:1px solid #000; color:#000; font-size:10px; line-height:10px; margin:0; padding:0 1px; width:10px; height:10px; } .trace.collapsed .minus, .trace.expanded .plus, .trace.collapsed pre { display: none; } .trace-file { cursor: pointer; padding: 0.2em; } .trace-file:hover { background: #f0ffff; } /]]>/ </style> </head> <body> <div class="container"> <h1>Error</h1> <p class="message"> Call to undefined function fixMovedQuestionConditions() </p> <div class="source"> <p class="file">/mnt/data/shnoulle/nginx/www/develop/application/controllers/admin/surveyadmin.php(1338)</p> <div class="code"><pre><span class="ln">1326</span> } elseif ($ID[0] == 'q') { <span class="ln">1327</span> $qid = (int) substr($ID, 1); <span class="ln">1328</span> $gid = (int) substr($parent, 1); <span class="ln">1329</span> if (!isset($aQuestionOrder[$gid])) { <span class="ln">1330</span> $aQuestionOrder[$gid] = 0; <span class="ln">1331</span> } <span class="ln">1332</span> <span class="ln">1333</span> $sBaseLanguage = Survey::model()->findByPk($iSurveyID)->language; <span class="ln">1334</span> $oQuestion = Question::model()->findByPk(array("qid"=>$qid, 'language'=>$sBaseLanguage)); <span class="ln">1335</span> $oldGid = $oQuestion['gid']; <span class="ln">1336</span> <span class="ln">1337</span> if ($oldGid != $gid) { <span class="error"><span class="ln error-ln">1338</span> fixMovedQuestionConditions($qid, $oldGid, $gid, $iSurveyID); </span><span class="ln">1339</span> } <span class="ln">1340</span> Question::model()->updateAll(array('question_order' => $aQuestionOrder[$gid], 'gid' => $gid), 'qid=:qid', array(':qid' => $qid)); <span class="ln">1341</span> Question::model()->updateAll(array('gid' => $gid), 'parent_qid=:parent_qid', array(':parent_qid' => $qid)); <span class="ln">1342</span> $aQuestionOrder[$gid]++; <span class="ln">1343</span> } <span class="ln">1344</span> } <span class="ln">1345</span> LimeExpressionManager::SetDirtyFlag(); // so refreshes syntax highlighting <span class="ln">1346</span> Yii::app()->session['flashmessage'] = gT("The new question group/question order was successfully saved."); <span class="ln">1347</span> } <span class="ln">1348</span> <span class="ln">1349</span> /** <span class="ln">1350</span> * Get the new question organization from the post data. </pre></div> </div> <div class="traces"> <h2>Stack Trace</h2> <table style="width:100%;"> <tbody><tr class="trace app expanded"> <td class="number"> #0 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div>  /mnt/data/shnoulle/nginx/www/develop/application/controllers/admin/surveyadmin.php(1229): <strong>SurveyAdmin</strong>-><strong>_reorderGroup</strong>(186748) </div> <div class="code"><pre><span class="ln">1224</span> $this->getController()->redirect(Yii::app()->request->urlReferrer); <span class="ln">1225</span> } <span class="ln">1226</span> <span class="ln">1227</span> if ($thereIsPostData) { <span class="ln">1228</span> // Save the new ordering <span class="error"><span class="ln error-ln">1229</span> $this->_reorderGroup($iSurveyID); </span><span class="ln">1230</span> <span class="ln">1231</span> $closeAfterSave = $request->getPost('close-after-save') === 'true'; <span class="ln">1232</span> if ($closeAfterSave) { <span class="ln">1233</span> $this->getController()->redirect(array('admin/survey/sa/view/surveyid/'.$iSurveyID)); <span class="ln">1234</span> } else { </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #1 </td> <td class="content"> <div class="trace-file">  unknown(0): <strong>SurveyAdmin</strong>-><strong>organize</strong>(186748) </div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #2 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div>  /mnt/data/shnoulle/nginx/www/develop/framework/web/actions/CAction.php(109): <strong>ReflectionMethod</strong>-><strong>invokeArgs</strong>(SurveyAdmin, array("186748")) </div> <div class="code"><pre><span class="ln">104</span> elseif($param->isDefaultValueAvailable()) <span class="ln">105</span> $ps[]=$param->getDefaultValue(); <span class="ln">106</span> else <span class="ln">107</span> return false; <span class="ln">108</span> } <span class="error"><span class="ln error-ln">109</span> $method->invokeArgs($object,$ps); </span><span class="ln">110</span> return true; <span class="ln">111</span> } <span class="ln">112</span> } </pre></div> </td> </tr> <tr class="trace app expanded"> <td class="number"> #3 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div>  /mnt/data/shnoulle/nginx/www/develop/application/core/Survey_Common_Action.php(83): <strong>CAction</strong>-><strong>runWithParamsInternal</strong>(SurveyAdmin, ReflectionMethod, array("r" => "admin/survey/sa/organize/surveyid/186748", "sa" => "organize", "surveyid" => "186748", "iSurveyId" => "186748", ...)) </div> <div class="code"><pre><span class="ln">78</span> $oMethod = new ReflectionMethod($this, $sDefault); <span class="ln">79</span> } <span class="ln">80</span> <span class="ln">81</span> // We're all good to go, let's execute it <span class="ln">82</span> // runWithParamsInternal would automatically get the parameters of the method and populate them as required with the params <span class="error"><span class="ln error-ln">83</span> return parent::runWithParamsInternal($this, $oMethod, $params); </span><span class="ln">84</span> } <span class="ln">85</span> <span class="ln">86</span> /** <span class="ln">87</span> * Some functions have different parameters, which are just an alias of the <span class="ln">88</span> * usual parameters we're getting in the url. This function just populates </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #4 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div>  /mnt/data/shnoulle/nginx/www/develop/framework/web/CController.php(308): <strong>Survey_Common_Action</strong>-><strong>runWithParams</strong>(array("r" => "admin/survey/sa/organize/surveyid/186748", "sa" => "organize", "surveyid" => "186748", "iSurveyId" => "186748", ...)) </div> <div class="code"><pre><span class="ln">303</span> { <span class="ln">304</span> $priorAction=$this->_action; <span class="ln">305</span> $this->_action=$action; <span class="ln">306</span> if($this->beforeAction($action)) <span class="ln">307</span> { <span class="error"><span class="ln error-ln">308</span> if($action->runWithParams($this->getActionParams())===false) </span><span class="ln">309</span> $this->invalidActionParams($action); <span class="ln">310</span> else <span class="ln">311</span> $this->afterAction($action); <span class="ln">312</span> } <span class="ln">313</span> $this->_action=$priorAction; </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #5 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div>  /mnt/data/shnoulle/nginx/www/develop/framework/web/CController.php(286): <strong>CController</strong>-><strong>runAction</strong>(SurveyAdmin) </div> <div class="code"><pre><span class="ln">281</span> * @see runAction <span class="ln">282</span> / <span class="ln">283</span> public function runActionWithFilters($action,$filters) <span class="ln">284</span> { <span class="ln">285</span> if(empty($filters)) <span class="error"><span class="ln error-ln">286</span> $this->runAction($action); </span><span class="ln">287</span> else <span class="ln">288</span> { <span class="ln">289</span> $priorAction=$this->_action; <span class="ln">290</span> $this->_action=$action; <span class="ln">291</span> CFilterChain::create($this,$action,$filters)->run(); </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #6 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div>  /mnt/data/shnoulle/nginx/www/develop/framework/web/CController.php(265): <strong>CController</strong>-><strong>runActionWithFilters</strong>(SurveyAdmin, array()) </div> <div class="code"><pre><span class="ln">260</span> { <span class="ln">261</span> if(($parent=$this->getModule())===null) <span class="ln">262</span> $parent=Yii::app(); <span class="ln">263</span> if($parent->beforeControllerAction($this,$action)) <span class="ln">264</span> { <span class="error"><span class="ln error-ln">265</span> $this->runActionWithFilters($action,$this->filters()); </span><span class="ln">266</span> $parent->afterControllerAction($this,$action); <span class="ln">267</span> } <span class="ln">268</span> } <span class="ln">269</span> else <span class="ln">270</span> $this->missingAction($actionID); </pre></div> </td> </tr> <tr class="trace app expanded"> <td class="number"> #7 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div>  /mnt/data/shnoulle/nginx/www/develop/application/controllers/AdminController.php(158): <strong>CController</strong>-><strong>run</strong>("survey") </div> <div class="code"><pre><span class="ln">153</span> $this->redirect(array('/admin/authentication/sa/login')); <span class="ln">154</span> } <span class="ln">155</span> } <span class="ln">156</span> } <span class="ln">157</span> <span class="error"><span class="ln error-ln">158</span> return parent::run($action); </span><span class="ln">159</span> } <span class="ln">160</span> <span class="ln">161</span> /* <span class="ln">162</span> * Routes all the actions to their respective places <span class="ln">163</span> * </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #8 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div>  /mnt/data/shnoulle/nginx/www/develop/framework/web/CWebApplication.php(282): <strong>AdminController</strong>-><strong>run</strong>("survey") </div> <div class="code"><pre><span class="ln">277</span> { <span class="ln">278</span> list($controller,$actionID)=$ca; <span class="ln">279</span> $oldController=$this->_controller; <span class="ln">280</span> $this->_controller=$controller; <span class="ln">281</span> $controller->init(); <span class="error"><span class="ln error-ln">282</span> $controller->run($actionID); </span><span class="ln">283</span> $this->_controller=$oldController; <span class="ln">284</span> } <span class="ln">285</span> else <span class="ln">286</span> throw new CHttpException(404,Yii::t('yii','Unable to resolve the request "{route}".', <span class="ln">287</span> array('{route}'=>$route===''?$this->defaultController:$route))); </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #9 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div>  /mnt/data/shnoulle/nginx/www/develop/framework/web/CWebApplication.php(141): <strong>CWebApplication</strong>-><strong>runController</strong>("admin/survey/sa/organize/surveyid/186748") </div> <div class="code"><pre><span class="ln">136</span> foreach(array_splice($this->catchAllRequest,1) as $name=>$value) <span class="ln">137</span> $_GET[$name]=$value; <span class="ln">138</span> } <span class="ln">139</span> else <span class="ln">140</span> $route=$this->getUrlManager()->parseUrl($this->getRequest()); <span class="error"><span class="ln error-ln">141</span> $this->runController($route); </span><span class="ln">142</span> } <span class="ln">143</span> <span class="ln">144</span> /** <span class="ln">145</span> * Registers the core application components. <span class="ln">146</span> * This method overrides the parent implementation by registering additional core components. </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #10 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div>  /mnt/data/shnoulle/nginx/www/develop/framework/base/CApplication.php(185): <strong>CWebApplication</strong>-><strong>processRequest</strong>() </div> <div class="code"><pre><span class="ln">180</span> public function run() <span class="ln">181</span> { <span class="ln">182</span> if($this->hasEventHandler('onBeginRequest')) <span class="ln">183</span> $this->onBeginRequest(new CEvent($this)); <span class="ln">184</span> register_shutdown_function(array($this,'end'),0,false); <span class="error"><span class="ln error-ln">185</span> $this->processRequest(); </span><span class="ln">186</span> if($this->hasEventHandler('onEndRequest')) <span class="ln">187</span> $this->onEndRequest(new CEvent($this)); <span class="ln">188</span> } <span class="ln">189</span> <span class="ln">190</span> /** </pre></div> </td> </tr> <tr class="trace app collapsed"> <td class="number"> #11 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div>  /mnt/data/shnoulle/nginx/www/develop/index.php(194): <strong>CApplication</strong>-><strong>run</strong>() </div> <div class="code"><pre><span class="ln">189</span> require_once APPPATH . 'core/LSYii_Application' . EXT; <span class="ln">190</span> <span class="ln">191</span> $config = require_once(APPPATH . 'config/internal' . EXT); <span class="ln">192</span> <span class="ln">193</span> Yii::$enableIncludePath = false; <span class="error"><span class="ln error-ln">194</span> Yii::createApplication('LSYii_Application', $config)->run(); </span><span class="ln">195</span> <span class="ln">196</span> /* End of file index.php / <span class="ln">197</span> / Location: ./index.php / </pre></div> </td> </tr> </tbody></table> </div> <div class="version"> 2019-04-06 12:56:00 nginx/1.14.2 <a href="http://www.yiiframework.com/">Yii Framework</a>/1.1.21 </div> </div> <script type="text/javascript"> /<![CDATA[/ var traceReg = new RegExp("(^\|\\s)trace-file(\\s\|$)"); var collapsedReg = new RegExp("(^\|\\s)collapsed(\\s\|$)"); var e = document.getElementsByTagName("div"); for(var j=0,len=e.length;j<len;j++){ if(traceReg.test(e[j].className)){ e[j].onclick = function(){ var trace = this.parentNode.parentNode; if(collapsedReg.test(trace.className)) trace.className = trace.className.replace("collapsed", "expanded"); else trace.className = trace.className.replace("expanded", "collapsed"); } } } /]]>*/ </script> </body></html> Error.html (19,134 bytes) Capture d’écran du 2019-06-12 17-55-50.png (35,265 bytes) Capture d’écran du 2019-06-12 17-55-50.png (35,265 bytes) Capture d’écran du 2019-06-12 17-57-39.png (11,296 bytes) Capture d’écran du 2019-06-12 17-57-39.png (11,296 bytes)

Bug heat	6
Complete LimeSurvey version number (& build)
I will donate to the project if issue is resolved
Browser
Database type & version
Server OS (if known)
Webserver software & version (if known)
PHP Version

User List	There are no users monitoring this issue.

cdorin 2019-04-10 17:47 reporter ~51434	When is this happening? Can't reproduce it on my local/pro instance

DenisChenu 2019-04-12 10:37 developer ~51446	Oups : 4.0

~~dominikvitt~~ 2019-06-12 17:54 developer ~52375	Question moving works as expected using latest LS version 4.0.0-beta, no error message.

DenisChenu 2019-06-12 17:56 developer ~52376 Last edited: 2019-06-12 17:57	~~@dominikvitt~~ using last GIT for develop : no save buttons on organize. maybe you spoke from another screen ? Way to reorder ? Linl index.php?r=admin/survey/sa/organize&surveyid=XXXX found in menu

~~dominikvitt~~ 2019-06-12 18:01 developer ~52377	There is no error message, but "Save" button is missing. I'll look into it.

DenisChenu 2019-06-12 18:06 developer ~52378	No save button : no way to save => no error message ;)

~~dominikvitt~~ 2019-06-13 13:45 developer ~52396	This issue is fixed. The patch is available now on GitHub and would be available on next LimeSurvey release. https://github.com/LimeSurvey/LimeSurvey/commit/149bfccc615990da90fbdda0c2004093c40f7f69

Date Modified	Username	Field	Change
2019-04-06 14:57	DenisChenu	New Issue
2019-04-06 14:57	DenisChenu	File Added: Capture d’écran du 2019-04-06 14-54-30.png
2019-04-06 14:57	DenisChenu	File Added: Error.html
2019-04-10 17:47	cdorin	Note Added: 51434
2019-04-12 10:37	DenisChenu	Note Added: 51446
2019-04-12 10:37	DenisChenu	Product Version	=> 4.0.0dev
2019-06-12 17:54	~~dominikvitt~~	Assigned To	=> dominikvitt
2019-06-12 17:54	~~dominikvitt~~	Status	new => resolved
2019-06-12 17:54	~~dominikvitt~~	Resolution	open => unable to reproduce
2019-06-12 17:54	~~dominikvitt~~	Note Added: 52375
2019-06-12 17:56	DenisChenu	Status	resolved => feedback
2019-06-12 17:56	DenisChenu	Resolution	unable to reproduce => reopened
2019-06-12 17:56	DenisChenu	Note Added: 52376
2019-06-12 17:56	DenisChenu	File Added: Capture d’écran du 2019-06-12 17-55-50.png
2019-06-12 17:57	DenisChenu	Note Edited: 52376
2019-06-12 17:57	DenisChenu	File Added: Capture d’écran du 2019-06-12 17-57-39.png
2019-06-12 17:58	DenisChenu	Project	Feature requests => Bug reports
2019-06-12 17:58	DenisChenu	Severity	feature => minor
2019-06-12 18:01	~~dominikvitt~~	Note Added: 52377
2019-06-12 18:06	DenisChenu	Note Added: 52378
2019-06-12 18:06	DenisChenu	Status	feedback => assigned
2019-06-13 13:45	~~dominikvitt~~	Status	assigned => resolved
2019-06-13 13:45	~~dominikvitt~~	Resolution	reopened => fixed
2019-06-13 13:45	~~dominikvitt~~	Fixed in Version	=> 4.0.0-beta
2019-06-13 13:45	~~dominikvitt~~	Note Added: 52396
2019-11-01 17:25	c_schmitz	Category	Survey design => Survey editing
2020-03-09 15:36	c_schmitz	Status	resolved => closed

View Issue Details

Users monitoring this issue

Activities

Issue History