View Issue Details

IDProjectCategoryView StatusLast Update
14271Bug reports[All Projects] Expression Managerpublic2019-04-30 09:12
Reporterholch Assigned ToDenisChenu  
PrioritynoneSeveritymajor 
Status closedResolutionfixed 
Product Version3.15.x 
Target Version3.16.xFixed in Version3.15.x 
Summary14271: Some words used by LS can be used as question/subquestion/answer codes
Description

Some words used by LS and Expression Manager like for example LANG can be used as question code and thus cause problems when trying to access this question via EM.

See link for further details and discussion:
https://www.limesurvey.org/forum/installation-a-update-issues/107555-can-t-hide-question-groups-based-on-yes-no-whatever-i-try-s

TagsNo tags attached.
Complete LimeSurvey version number (& build)latest
I will donate to the project if issue is resolvedNo
Browserall
Database & DB-VersionNA
Server OS (if known)NA
Webserver software & version (if known)NA
PHP VersionNA

Relationships

related to 14272 resolvedcdorin Multiple text with comment and subquestion «comment» validation and logic file is broken 

Activities

DenisChenu

DenisChenu

2018-11-22 13:10

developer   ~49725

Last edited: 2018-11-22 13:10

View 2 revisions

@c_schmitz : OK to fix it for 3.X or need to be in develop ?
I fix it via rules : clean and easy :)

c_schmitz

c_schmitz

2018-11-22 14:01

administrator   ~49728

I think it is a fix, so go ahead for master.

DenisChenu

DenisChenu

2018-11-22 14:05

developer   ~49729

OK,

Starting by :
LANG
SID
GID
QID
SQG
SAVEDID

If you see another. I do a test if we need lower/upper case or not …

DenisChenu

DenisChenu

2018-11-22 16:56

developer   ~49741

https://github.com/LimeSurvey/LimeSurvey/pull/1177/files

@holch : i don't see any potential issue for Answer, and except with other and time : no issue with Sub-question. Maybe comment ? (let me check this one)

holch

holch

2018-11-22 17:26

reporter   ~49743

Thinking about it, there is probably issue with answer code or subquestion code, because they wouldn't stand alone so they would always be something like "Q1_A1" or similar.

DenisChenu

DenisChenu

2018-11-22 17:37

developer   ~49744

Q1_A1 == "A1" work (multi text OR array with answer A1 to 15 and subquestion A1 to A5) : no issue here :)

Event : Q1_A1 == Q1_A2 if you want

DenisChenu

DenisChenu

2018-11-22 18:07

developer   ~49745

No BIG issue except Survey Logic File … with multiple text with comment

EM is OK, but survey logic file didn't show subquestion with code : comment, automatic validation are MAYBE broken.



limesurvey_survey_multipleTextComment.lss (16,748 bytes)
DenisChenu

DenisChenu

2018-11-22 18:09

developer   ~49746

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=28551

holch

holch

2018-11-22 18:10

reporter   ~49747

Sorry, I was missing a "NO". So what I wanted to say is actually: "Thinking about it, there is probably NO issue with answer code or subquestion code, because they wouldn't stand alone so they would always be something like "Q1_A1" or similar."

DenisChenu

DenisChenu

2018-11-22 18:12

developer   ~49748

Fixed for common bad word, other can be easily added (add it here still is not closed but fixed)

I report another issue about ASSESMENT_CURRENT_TOTAL and Multiple text with comment.

About answer : please report another issue too (not same fix because not same model, have one mantis by fix is always better)

c_schmitz

c_schmitz

2019-04-30 09:12

administrator   ~51653

Fixed in Version 3.1.7.3

Related Changesets

LimeSurvey: master a8e3c8a5

2018-11-22 16:47:39

DenisChenu

Details Diff
Fixed issue 14271: Some words used by LS can be used as question codes
Dev: subquestion already fixed : time and other
Dev: don't see for answer ?
Affected Issues
14271
mod - application/models/Question.php Diff File

Issue History

Date Modified Username Field Change
2018-11-22 12:35 holch New Issue
2018-11-22 13:09 DenisChenu Assigned To => DenisChenu
2018-11-22 13:09 DenisChenu Status new => assigned
2018-11-22 13:10 DenisChenu Note Added: 49725
2018-11-22 13:10 DenisChenu Note Edited: 49725 View Revisions
2018-11-22 14:01 c_schmitz Note Added: 49728
2018-11-22 14:05 DenisChenu Target Version => 3.16.x
2018-11-22 14:05 DenisChenu Note Added: 49729
2018-11-22 16:56 DenisChenu Note Added: 49741
2018-11-22 17:26 holch Note Added: 49743
2018-11-22 17:37 DenisChenu Note Added: 49744
2018-11-22 18:07 DenisChenu File Added: limesurvey_survey_multipleTextComment.lss
2018-11-22 18:07 DenisChenu File Added: Capture du 2018-11-22 18-06-45.png
2018-11-22 18:07 DenisChenu Note Added: 49745
2018-11-22 18:09 DenisChenu Changeset attached => LimeSurvey master a8e3c8a5
2018-11-22 18:09 DenisChenu Note Added: 49746
2018-11-22 18:09 DenisChenu Resolution open => fixed
2018-11-22 18:10 holch Note Added: 49747
2018-11-22 18:12 DenisChenu Status assigned => resolved
2018-11-22 18:12 DenisChenu Fixed in Version => 3.15.x
2018-11-22 18:12 DenisChenu Note Added: 49748
2018-11-22 18:22 DenisChenu Relationship added related to 14272
2019-04-30 09:12 c_schmitz Note Added: 51653
2019-04-30 09:12 c_schmitz Status resolved => closed