View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
14271 | Bug reports | Expression Manager | public | 2018-11-22 12:35 | 2019-04-30 09:12 |
Reporter | holch | Assigned To | DenisChenu | ||
Priority | none | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.15.x | ||||
Target Version | 3.16.x | Fixed in Version | 3.15.x | ||
Summary | 14271: Some words used by LS can be used as question/subquestion/answer codes | ||||
Description | Some words used by LS and Expression Manager like for example LANG can be used as question code and thus cause problems when trying to access this question via EM. See link for further details and discussion: | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | latest | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | all | ||||
Database type & version | NA | ||||
Server OS (if known) | NA | ||||
Webserver software & version (if known) | NA | ||||
PHP Version | NA | ||||
@c_schmitz : OK to fix it for 3.X or need to be in develop ? |
|
I think it is a fix, so go ahead for master. |
|
OK, Starting by : If you see another. I do a test if we need lower/upper case or not … |
|
https://github.com/LimeSurvey/LimeSurvey/pull/1177/files @holch : i don't see any potential issue for Answer, and except with other and time : no issue with Sub-question. Maybe comment ? (let me check this one) |
|
Thinking about it, there is probably issue with answer code or subquestion code, because they wouldn't stand alone so they would always be something like "Q1_A1" or similar. |
|
Q1_A1 == "A1" work (multi text OR array with answer A1 to 15 and subquestion A1 to A5) : no issue here :) Event : Q1_A1 == Q1_A2 if you want |
|
No BIG issue except Survey Logic File … with multiple text with comment EM is OK, but survey logic file didn't show subquestion with code : comment, automatic validation are MAYBE broken. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=28551 |
|
Sorry, I was missing a "NO". So what I wanted to say is actually: "Thinking about it, there is probably NO issue with answer code or subquestion code, because they wouldn't stand alone so they would always be something like "Q1_A1" or similar." |
|
Fixed for common bad word, other can be easily added (add it here still is not closed but fixed) I report another issue about ASSESMENT_CURRENT_TOTAL and Multiple text with comment. About answer : please report another issue too (not same fix because not same model, have one mantis by fix is always better) |
|
Fixed in Version 3.1.7.3 |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2018-11-22 12:35 | holch | New Issue | |
2018-11-22 13:09 | DenisChenu | Assigned To | => DenisChenu |
2018-11-22 13:09 | DenisChenu | Status | new => assigned |
2018-11-22 13:10 | DenisChenu | Note Added: 49725 | |
2018-11-22 13:10 | DenisChenu | Note Edited: 49725 | |
2018-11-22 14:01 | c_schmitz | Note Added: 49728 | |
2018-11-22 14:05 | DenisChenu | Target Version | => 3.16.x |
2018-11-22 14:05 | DenisChenu | Note Added: 49729 | |
2018-11-22 16:56 | DenisChenu | Note Added: 49741 | |
2018-11-22 17:26 | holch | Note Added: 49743 | |
2018-11-22 17:37 | DenisChenu | Note Added: 49744 | |
2018-11-22 18:07 | DenisChenu | File Added: limesurvey_survey_multipleTextComment.lss | |
2018-11-22 18:07 | DenisChenu | File Added: Capture du 2018-11-22 18-06-45.png | |
2018-11-22 18:07 | DenisChenu | Note Added: 49745 | |
2018-11-22 18:09 | DenisChenu | Changeset attached | => LimeSurvey master a8e3c8a5 |
2018-11-22 18:09 | DenisChenu | Note Added: 49746 | |
2018-11-22 18:09 | DenisChenu | Resolution | open => fixed |
2018-11-22 18:10 | holch | Note Added: 49747 | |
2018-11-22 18:12 | DenisChenu | Status | assigned => resolved |
2018-11-22 18:12 | DenisChenu | Fixed in Version | => 3.15.x |
2018-11-22 18:12 | DenisChenu | Note Added: 49748 | |
2018-11-22 18:22 | DenisChenu | Relationship added | related to 14272 |
2019-04-30 09:12 | c_schmitz | Note Added: 51653 | |
2019-04-30 09:12 | c_schmitz | Status | resolved => closed |