View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
13565Bug reportsSurvey takingpublic2018-04-03 16:052018-04-06 11:47
ReporterKRav Assigned Toollehar1  
PrioritynoneSeveritytweak 
Status closedResolutionfixed 
Product Version3.3.x 
Fixed in Version3.5.x 
Summary13565: Punctuation points should go into the translation and not into the php code
Description

$sMandatoryText = $LEM->gT('Please complete all parts').'.';.

What you think?

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build) 180329
I will donate to the project if issue is resolvedNo
Browser
Database type & versionx
Server OS (if known)xx
Webserver software & version (if known)xx
PHP Versionx

Users monitoring this issue

There are no users monitoring this issue.

Activities

ollehar

ollehar

2018-04-03 16:10

administrator   ~47314

Agreed.
KRav

KRav

2018-04-03 16:13

partner   ~47315

how to handle the translations - files? I can make a pull request for the php file.
KRav

KRav

2018-04-03 16:29

partner   ~47316

https://github.com/LimeSurvey/LimeSurvey/pull/1036
ollehar1

ollehar1

2018-04-03 16:50

reporter   ~47317

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=26919

Related Changesets

LimeSurvey: master ed14d0a9

2018-04-03 16:50:10

ResearchOnBlogs


Committer: ollehar1 Details Diff 		Fixed issue 13565: Remove punctuation points from php (#1036)

Fixed issue 13565: Remove punctuation points from PHP		 Affected Issues
13565
mod - application/helpers/expressions/em_manager_helper.php Diff File

Issue History

Date Modified Username Field Change
2018-04-03 16:05 KRav New Issue
2018-04-03 16:10 ollehar Note Added: 47314
2018-04-03 16:13 KRav Note Added: 47315
2018-04-03 16:29 KRav Note Added: 47316
2018-04-03 16:50 ollehar1 Changeset attached => LimeSurvey master ed14d0a9
2018-04-03 16:50 ollehar1 Note Added: 47317
2018-04-03 16:50 ollehar1 Assigned To => ollehar1
2018-04-03 16:50 ollehar1 Resolution open => fixed
2018-04-03 17:08 ollehar Status new => resolved
2018-04-03 17:08 ollehar Fixed in Version => 3.5.x
2018-04-06 11:47 markusfluer Status resolved => closed