View Issue Details

IDProjectCategoryView StatusLast Update
13169Bug reports[All Projects] _ Unknownpublic2018-01-15 15:12
ReporterTonisOrmissonAssigned To 
PrioritynoneSeverityminor 
Status newResolutionopen 
Product Version 
Target VersionFixed in Version 
Summary13169: Glyphicons not visible in themes
Descriptionusing bootstrap glyphicons like:
<span class="glyphicon glyphicon-exclamation-sign text-danger"></span>

will not render the icon. see image below
TagsNo tags attached.
Complete LimeSurvey version number (& build)Version 3.0.2
I will donate to the project if issue is resolvedNo
Browserff 57
Database & DB-Versionna
Operating System (Server)debian
Webserver software & versionnginx
PHP Version7.0

Activities

TonisOrmisson

TonisOrmisson

2018-01-12 08:08

reporter  

markusfluer

markusfluer

2018-01-12 09:31

developer   ~45567

Last edited: 2018-01-12 09:32

View 2 revisions

That's because we are not using them.
use fontawesome icons -> fa fa-exclamation

TonisOrmisson

TonisOrmisson

2018-01-12 09:39

reporter   ~45568

ok, but is it not standard bootstrap components?
LouisGac

LouisGac

2018-01-15 10:35

developer   ~45636

We spent quiet a lot of time to convert everything from glyphicon to fontawesome.
It has been debated in the meetings, and it seems that people prefer fontawesome.
For performance reasons, it's better to load as less as possible fonts for one survey.
But if you want, it could be pretty easy to add the glyphicon fonts as a package (like for other fonts)
tammo

tammo

2018-01-15 14:32

developer   ~45812

Maybe ask Denis: adding this font as a plugin?
TonisOrmisson

TonisOrmisson

2018-01-15 14:57

reporter   ~45815

i have actualli no problem using fa. i just asdumed i could use standard bootstrap components and this question might come up anyway. feel free to close it.
tammo

tammo

2018-01-15 14:59

developer   ~45816

If the question might come up anyway: why not put FontAwesome and Glyphicons in separate plugins and switch on FA by default?
LouisGac

LouisGac

2018-01-15 15:04

developer   ~45817

tammo: you don't need any plugin for that.
if you want to add a font in a theme: you can do it.

I was just offering to add a core package for glyphicon to make it super easy to use like:
https://github.com/LimeSurvey/LimeSurvey/blob/master/themes/survey/vanilla/config.xml#L58
tammo

tammo

2018-01-15 15:12

developer   ~45818

OK!

Issue History

Date Modified Username Field Change
2018-01-12 08:08 TonisOrmisson New Issue
2018-01-12 08:08 TonisOrmisson File Added: Screenshot from 2018-01-12 09-00-10.png
2018-01-12 09:31 markusfluer Note Added: 45567
2018-01-12 09:32 markusfluer Note Edited: 45567 View Revisions
2018-01-12 09:39 TonisOrmisson Note Added: 45568
2018-01-15 10:35 LouisGac Note Added: 45636
2018-01-15 14:32 tammo Note Added: 45812
2018-01-15 14:57 TonisOrmisson Note Added: 45815
2018-01-15 14:59 tammo Note Added: 45816
2018-01-15 15:04 LouisGac Note Added: 45817
2018-01-15 15:12 tammo Note Added: 45818