View Issue Details

Jump to NotesJump to History
This issue affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
12949Bug reportsInstallationpublic2017-11-23 10:252018-01-15 10:35
Reporterfvanderstarre Assigned Toollehar  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version3.0.0-rc.x 
Summary12949: Incorrect sql statement when updating to db version 329 (ms-sql)
Description

When updating from db version 325 to 329, an error is thrown at line # 692 in updatedb_helper.php:
"An non-recoverable error happened during the update. Error details:
CDbCommand failed to execute the SQL statement: SQLSTATE[HY000]: General error: 20018 Invalid column name 'generalsettings'. [20018] (severity 16) [(null)]".
SQL statement to be performed: "UPDATE [surveymenu_entries] SET [name]='generalsettings_collapsed' WHERE name = "generalsettings" AND menu_id = 2".
Apparently "name" in the where clause is interpreted as "column name" instead of column "name" having value equal to "generalsettings".

Steps To Reproduce

See above

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)3.0.0-RC.3 + 171114, latest GitHub download (23/11/2017)
I will donate to the project if issue is resolvedNo
BrowserAny
Database type & versionMS-SQL 2008 R2
Server OS (if known)Linux RHEL 7
Webserver software & version (if known)Apache 2.4.6
PHP Version5.6.31

Users monitoring this issue

There are no users monitoring this issue.

Activities

ollehar

ollehar

2017-11-24 14:23

administrator   ~45142

Double quotes should be single quotes. I'll have a look.
ollehar

ollehar

2017-11-24 14:24

administrator   ~45143

And yes, also [name] like that.
ollehar

ollehar

2017-11-24 14:28

administrator   ~45144

Resolved in commit 83857977928df7aaa7d0f3b6d1d1cad2302c2837
fvanderstarre

fvanderstarre

2017-11-27 10:01

reporter   ~45157

Upgrade to 329: statement: $oDB->createCommand()->createIndex('{{surveymenu_name}}', '{{surveymenu}}', 'name', true);
should be moved after: $oDB->createCommand()->alterColumn('{{surveymenu}}', 'name', 'string(128) NOT NULL');
(otherwise creating a unique index on "name" will fail)
c_schmitz

c_schmitz

2018-01-15 10:35

administrator   ~45620

Version 3.0.3 released.

Issue History

Date Modified Username Field Change
2017-11-23 10:25 fvanderstarre New Issue
2017-11-24 14:23 ollehar Note Added: 45142
2017-11-24 14:24 ollehar Note Added: 45143
2017-11-24 14:28 ollehar Assigned To => ollehar
2017-11-24 14:28 ollehar Status new => resolved
2017-11-24 14:28 ollehar Resolution open => fixed
2017-11-24 14:28 ollehar Note Added: 45144
2017-11-27 10:01 fvanderstarre Note Added: 45157
2018-01-15 10:35 c_schmitz Note Added: 45620
2018-01-15 10:35 c_schmitz Status resolved => closed