View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
12807Bug reportsOtherpublic2018-01-15 10:41
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version2.7x.x 
Fixed in Version2.7x.x 
Summary12807: Produced 404 due to error in survey broke with template
Description

WIth debug 2, 404 error produce an error in template and not a 404 error

Steps To Reproduce

Activate debug=2
Go to an unexisting survey id

Additional Information

If survey is not set : must be the default template …

TagsNo tags attached.
Attached Files
PHP notice.html (19,276 bytes)   
<!DOCTYPE html PUBLIC
	"-//W3C//DTD XHTML 1.0 Transitional//EN"
	"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
<title>PHP notice</title>

<style type="text/css">
/*<![CDATA[*/
html,body,div,span,applet,object,iframe,h1,h2,h3,h4,h5,h6,p,blockquote,pre,a,abbr,acronym,address,big,cite,code,del,dfn,em,font,img,ins,kbd,q,s,samp,small,strike,strong,sub,sup,tt,var,b,u,i,center,dl,dt,dd,ol,ul,li,fieldset,form,label,legend,table,caption,tbody,tfoot,thead,tr,th,td{border:0;outline:0;font-size:100%;vertical-align:baseline;background:transparent;margin:0;padding:0;}
body{line-height:1;}
ol,ul{list-style:none;}
blockquote,q{quotes:none;}
blockquote:before,blockquote:after,q:before,q:after{content:none;}
:focus{outline:0;}
ins{text-decoration:none;}
del{text-decoration:line-through;}
table{border-collapse:collapse;border-spacing:0;}

body {
	font: normal 9pt "Verdana";
	color: #000;
	background: #fff;
}

h1 {
	font: normal 18pt "Verdana";
	color: #f00;
	margin-bottom: .5em;
}

h2 {
	font: normal 14pt "Verdana";
	color: #800000;
	margin-bottom: .5em;
}

h3 {
	font: bold 11pt "Verdana";
}

pre {
	font: normal 11pt Menlo, Consolas, "Lucida Console", Monospace;
}

pre span.error {
	display: block;
	background: #fce3e3;
}

pre span.ln {
	color: #999;
	padding-right: 0.5em;
	border-right: 1px solid #ccc;
}

pre span.error-ln {
	font-weight: bold;
}

.container {
	margin: 1em 4em;
}

.version {
	color: gray;
	font-size: 8pt;
	border-top: 1px solid #aaa;
	padding-top: 1em;
	margin-bottom: 1em;
}

.message {
	color: #000;
	padding: 1em;
	font-size: 11pt;
	background: #f3f3f3;
	-webkit-border-radius: 10px;
	-moz-border-radius: 10px;
	border-radius: 10px;
	margin-bottom: 1em;
	line-height: 160%;
}

.source {
	margin-bottom: 1em;
}

.code pre {
	background-color: #ffe;
	margin: 0.5em 0;
	padding: 0.5em;
	line-height: 125%;
	border: 1px solid #eee;
}

.source .file {
	margin-bottom: 1em;
	font-weight: bold;
}

.traces {
	margin: 2em 0;
}

.trace {
	margin: 0.5em 0;
	padding: 0.5em;
}

.trace.app {
	border: 1px dashed #c00;
}

.trace .number {
	text-align: right;
	width: 2em;
	padding: 0.5em;
}

.trace .content {
	padding: 0.5em;
}

.trace .plus,
.trace .minus {
	display:inline;
	vertical-align:middle;
	text-align:center;
	border:1px solid #000;
	color:#000;
	font-size:10px;
	line-height:10px;
	margin:0;
	padding:0 1px;
	width:10px;
	height:10px;
}

.trace.collapsed .minus,
.trace.expanded .plus,
.trace.collapsed pre {
	display: none;
}

.trace-file {
	cursor: pointer;
	padding: 0.2em;
}

.trace-file:hover {
	background: #f0ffff;
}
/*]]>*/
</style>
</head>

<body>
<div class="container">
	<h1>PHP notice</h1>

	<p class="message">
		Trying to get property of non-object	</p>

	<div class="source">
		<p class="file">/home/sondages.pro/htdocs/clients/complets/oecd/application/models/TemplateConfiguration.php(72)</p>
		<div class="code"><pre><span class="ln">60</span>         // If it&#039;s called from template editor, a template name will be provided.
<span class="ln">61</span>         // If it&#039;s called for survey taking, a survey id will be provided
<span class="ln">62</span>         if ($sTemplateName == &#039;&#039; &amp;&amp; $iSurveyId == &#039;&#039;)
<span class="ln">63</span>         {
<span class="ln">64</span>             throw new TemplateException(&quot;Template needs either template name or survey id&quot;);
<span class="ln">65</span>         }
<span class="ln">66</span> 
<span class="ln">67</span>         $this-&gt;sTemplateName = $sTemplateName;
<span class="ln">68</span>         $this-&gt;iSurveyId     = (int) $iSurveyId;
<span class="ln">69</span> 
<span class="ln">70</span>         if ($sTemplateName==&#039;&#039;){
<span class="ln">71</span>             $this-&gt;oSurvey       = Survey::model()-&gt;findByPk($iSurveyId);
<span class="error"><span class="ln error-ln">72</span>             $this-&gt;sTemplateName = $this-&gt;oSurvey-&gt;template;
</span><span class="ln">73</span>         }
<span class="ln">74</span> 
<span class="ln">75</span>         // We check if  it&#039;s a CORE template
<span class="ln">76</span>         $this-&gt;isStandard = $this-&gt;setIsStandard();
<span class="ln">77</span> 
<span class="ln">78</span>         // If the template is standard, its root is based on standardtemplaterootdir, else, it&#039;s a user template, its root is based on usertemplaterootdir
<span class="ln">79</span>         $this-&gt;path = ($this-&gt;isStandard)?Yii::app()-&gt;getConfig(&quot;standardtemplaterootdir&quot;).DIRECTORY_SEPARATOR.$this-&gt;sTemplateName:Yii::app()-&gt;getConfig(&quot;usertemplaterootdir&quot;).DIRECTORY_SEPARATOR.$this-&gt;sTemplateName;
<span class="ln">80</span> 
<span class="ln">81</span>         // If the template directory doesn&#039;t exist, it can be that:
<span class="ln">82</span>         // - user deleted a custom theme
<span class="ln">83</span>         // In any case, we just set Default as the template to use
<span class="ln">84</span>         if (!is_dir($this-&gt;path))
</pre></div>	</div>

	<div class="traces">
		<h2>Stack Trace</h2>
				<table style="width:100%;">
						<tr class="trace app expanded">
			<td class="number">
				#0			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/clients/complets/oecd/application/models/Template.php(143): <strong>TemplateConfiguration</strong>-><strong>setTemplateConfiguration</strong>(&quot;&quot;, &quot;415553&quot;)				</div>

				<div class="code"><pre><span class="ln">138</span>      * @return StdClass
<span class="ln">139</span>      */
<span class="ln">140</span>     public static function getTemplateConfiguration($sTemplateName=&#039;&#039;, $iSurveyId=&#039;&#039;)
<span class="ln">141</span>     {
<span class="ln">142</span>         $oTemplate = new TemplateConfiguration;
<span class="error"><span class="ln error-ln">143</span>         $oTemplate-&gt;setTemplateConfiguration($sTemplateName, $iSurveyId);
</span><span class="ln">144</span>         return $oTemplate;
<span class="ln">145</span>     }
<span class="ln">146</span> 
<span class="ln">147</span>     /**
<span class="ln">148</span>      * Return the list of ALL files present in the file directory
</pre></div>			</td>
		</tr>
						<tr class="trace app expanded">
			<td class="number">
				#1			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/clients/complets/oecd/application/models/Template.php(304): <strong>Template</strong>::<strong>getTemplateConfiguration</strong>(&quot;&quot;, &quot;415553&quot;)				</div>

				<div class="code"><pre><span class="ln">299</span>      */
<span class="ln">300</span>     public static function getInstance($sTemplateName=&#039;&#039;, $iSurveyId=&#039;&#039;)
<span class="ln">301</span>     {
<span class="ln">302</span>         if (empty(self::$instance))
<span class="ln">303</span>         {
<span class="error"><span class="ln error-ln">304</span>             self::$instance = self::getTemplateConfiguration($sTemplateName, $iSurveyId);
</span><span class="ln">305</span>         }
<span class="ln">306</span>         return self::$instance;
<span class="ln">307</span>     }
<span class="ln">308</span> 
<span class="ln">309</span>     /**
</pre></div>			</td>
		</tr>
						<tr class="trace app expanded">
			<td class="number">
				#2			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/clients/complets/oecd/application/controllers/survey/index.php(39): <strong>Template</strong>::<strong>getInstance</strong>(&quot;&quot;, &quot;415553&quot;)				</div>

				<div class="code"><pre><span class="ln">34</span> 
<span class="ln">35</span>         // Template configuration
<span class="ln">36</span>         $param = $this-&gt;_getParameters(func_get_args(), $_POST);
<span class="ln">37</span>         $surveyid = $param[&#039;sid&#039;];
<span class="ln">38</span> 
<span class="error"><span class="ln error-ln">39</span>         $oTemplate = Template::model()-&gt;getInstance(&#039;&#039;, $surveyid);
</span><span class="ln">40</span>         $this-&gt;oTemplate = $oTemplate;
<span class="ln">41</span>         App()-&gt;clientScript-&gt;registerScript(&#039;sLSJavascriptVar&#039;,$sLSJavascriptVar,CClientScript::POS_HEAD);
<span class="ln">42</span>         App()-&gt;clientScript-&gt;registerScript(&#039;setJsVar&#039;,&quot;setJsVar();&quot;,CClientScript::POS_BEGIN);// Ensure all js var is set before rendering the page (User can click before $.ready)
<span class="ln">43</span> 
<span class="ln">44</span>         foreach($oTemplate-&gt;packages as $package)
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#3			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/clients/complets/oecd/framework/web/actions/CAction.php(76): <strong>index</strong>-><strong>run</strong>()				</div>

				<div class="code"><pre><span class="ln">71</span>     {
<span class="ln">72</span>         $method=new ReflectionMethod($this, &#039;run&#039;);
<span class="ln">73</span>         if($method-&gt;getNumberOfParameters()&gt;0)
<span class="ln">74</span>             return $this-&gt;runWithParamsInternal($this, $method, $params);
<span class="ln">75</span> 
<span class="error"><span class="ln error-ln">76</span>         $this-&gt;run();
</span><span class="ln">77</span>         return true;
<span class="ln">78</span>     }
<span class="ln">79</span> 
<span class="ln">80</span>     /**
<span class="ln">81</span>      * Executes a method of an object with the supplied named parameters.
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#4			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/clients/complets/oecd/framework/web/CController.php(308): <strong>CAction</strong>-><strong>runWithParams</strong>(array(&quot;token&quot; =&gt; &quot;6UNiBXDjJ3s2X0S&quot;, &quot;newtest&quot; =&gt; &quot;Y&quot;, &quot;lang&quot; =&gt; &quot;en&quot;, &quot;sid&quot; =&gt; &quot;415553&quot;))				</div>

				<div class="code"><pre><span class="ln">303</span>     {
<span class="ln">304</span>         $priorAction=$this-&gt;_action;
<span class="ln">305</span>         $this-&gt;_action=$action;
<span class="ln">306</span>         if($this-&gt;beforeAction($action))
<span class="ln">307</span>         {
<span class="error"><span class="ln error-ln">308</span>             if($action-&gt;runWithParams($this-&gt;getActionParams())===false)
</span><span class="ln">309</span>                 $this-&gt;invalidActionParams($action);
<span class="ln">310</span>             else
<span class="ln">311</span>                 $this-&gt;afterAction($action);
<span class="ln">312</span>         }
<span class="ln">313</span>         $this-&gt;_action=$priorAction;
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#5			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/clients/complets/oecd/framework/web/CController.php(286): <strong>CController</strong>-><strong>runAction</strong>(index)				</div>

				<div class="code"><pre><span class="ln">281</span>      * @see runAction
<span class="ln">282</span>      */
<span class="ln">283</span>     public function runActionWithFilters($action,$filters)
<span class="ln">284</span>     {
<span class="ln">285</span>         if(empty($filters))
<span class="error"><span class="ln error-ln">286</span>             $this-&gt;runAction($action);
</span><span class="ln">287</span>         else
<span class="ln">288</span>         {
<span class="ln">289</span>             $priorAction=$this-&gt;_action;
<span class="ln">290</span>             $this-&gt;_action=$action;
<span class="ln">291</span>             CFilterChain::create($this,$action,$filters)-&gt;run();
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#6			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/clients/complets/oecd/framework/web/CController.php(265): <strong>CController</strong>-><strong>runActionWithFilters</strong>(index, array())				</div>

				<div class="code"><pre><span class="ln">260</span>         {
<span class="ln">261</span>             if(($parent=$this-&gt;getModule())===null)
<span class="ln">262</span>                 $parent=Yii::app();
<span class="ln">263</span>             if($parent-&gt;beforeControllerAction($this,$action))
<span class="ln">264</span>             {
<span class="error"><span class="ln error-ln">265</span>                 $this-&gt;runActionWithFilters($action,$this-&gt;filters());
</span><span class="ln">266</span>                 $parent-&gt;afterControllerAction($this,$action);
<span class="ln">267</span>             }
<span class="ln">268</span>         }
<span class="ln">269</span>         else
<span class="ln">270</span>             $this-&gt;missingAction($actionID);
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#7			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/clients/complets/oecd/framework/web/CWebApplication.php(282): <strong>CController</strong>-><strong>run</strong>(&quot;index&quot;)				</div>

				<div class="code"><pre><span class="ln">277</span>         {
<span class="ln">278</span>             list($controller,$actionID)=$ca;
<span class="ln">279</span>             $oldController=$this-&gt;_controller;
<span class="ln">280</span>             $this-&gt;_controller=$controller;
<span class="ln">281</span>             $controller-&gt;init();
<span class="error"><span class="ln error-ln">282</span>             $controller-&gt;run($actionID);
</span><span class="ln">283</span>             $this-&gt;_controller=$oldController;
<span class="ln">284</span>         }
<span class="ln">285</span>         else
<span class="ln">286</span>             throw new CHttpException(404,Yii::t(&#039;yii&#039;,&#039;Unable to resolve the request &quot;{route}&quot;.&#039;,
<span class="ln">287</span>                 array(&#039;{route}&#039;=&gt;$route===&#039;&#039;?$this-&gt;defaultController:$route)));
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#8			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/clients/complets/oecd/framework/web/CWebApplication.php(141): <strong>CWebApplication</strong>-><strong>runController</strong>(&quot;survey/index/sid/415553&quot;)				</div>

				<div class="code"><pre><span class="ln">136</span>             foreach(array_splice($this-&gt;catchAllRequest,1) as $name=&gt;$value)
<span class="ln">137</span>                 $_GET[$name]=$value;
<span class="ln">138</span>         }
<span class="ln">139</span>         else
<span class="ln">140</span>             $route=$this-&gt;getUrlManager()-&gt;parseUrl($this-&gt;getRequest());
<span class="error"><span class="ln error-ln">141</span>         $this-&gt;runController($route);
</span><span class="ln">142</span>     }
<span class="ln">143</span> 
<span class="ln">144</span>     /**
<span class="ln">145</span>      * Registers the core application components.
<span class="ln">146</span>      * This method overrides the parent implementation by registering additional core components.
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#9			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/clients/complets/oecd/framework/base/CApplication.php(185): <strong>CWebApplication</strong>-><strong>processRequest</strong>()				</div>

				<div class="code"><pre><span class="ln">180</span>     public function run()
<span class="ln">181</span>     {
<span class="ln">182</span>         if($this-&gt;hasEventHandler(&#039;onBeginRequest&#039;))
<span class="ln">183</span>             $this-&gt;onBeginRequest(new CEvent($this));
<span class="ln">184</span>         register_shutdown_function(array($this,&#039;end&#039;),0,false);
<span class="error"><span class="ln error-ln">185</span>         $this-&gt;processRequest();
</span><span class="ln">186</span>         if($this-&gt;hasEventHandler(&#039;onEndRequest&#039;))
<span class="ln">187</span>             $this-&gt;onEndRequest(new CEvent($this));
<span class="ln">188</span>     }
<span class="ln">189</span> 
<span class="ln">190</span>     /**
</pre></div>			</td>
		</tr>
						<tr class="trace app collapsed">
			<td class="number">
				#10			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/clients/complets/oecd/index.php(214): <strong>CApplication</strong>-><strong>run</strong>()				</div>

				<div class="code"><pre><span class="ln">209</span>         die (sprintf(&#039;%s should be writable by the webserver (766 or 776).&#039;, $sDefaultRuntimePath));
<span class="ln">210</span>     }
<span class="ln">211</span> }
<span class="ln">212</span> 
<span class="ln">213</span> Yii::$enableIncludePath = false;
<span class="error"><span class="ln error-ln">214</span> Yii::createApplication(&#039;LSYii_Application&#039;, $config)-&gt;run();
</span><span class="ln">215</span> 
<span class="ln">216</span> /* End of file index.php */
<span class="ln">217</span> /* Location: ./index.php */
</pre></div>			</td>
		</tr>
				</table>
	</div>

	<div class="version">
		2017-10-19 08:17:54 Apache/2.2.22 (Debian) <a href="http://www.yiiframework.com/">Yii Framework</a>/1.1.18	</div>
</div>

<script type="text/javascript">
/*<![CDATA[*/
var traceReg = new RegExp("(^|\\s)trace-file(\\s|$)");
var collapsedReg = new RegExp("(^|\\s)collapsed(\\s|$)");

var e = document.getElementsByTagName("div");
for(var j=0,len=e.length;j<len;j++){
	if(traceReg.test(e[j].className)){
		e[j].onclick = function(){
			var trace = this.parentNode.parentNode;
			if(collapsedReg.test(trace.className))
				trace.className = trace.className.replace("collapsed", "expanded");
			else
				trace.className = trace.className.replace("expanded", "collapsed");
		}
	}
}
/*]]>*/
</script>

</body>
</html>
PHP notice.html (19,276 bytes)   
Bug heat4
Complete LimeSurvey version number (& build) 2.72.2
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2017-10-19 08:29

developer   ~44725

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=24176

c_schmitz

c_schmitz

2018-01-15 10:41

administrator   ~45784

Version 3.0.3 released.

Related Changesets

LimeSurvey: master 86f098d8

2017-10-19 08:28:50

DenisChenu

Details Diff
Dev: Fixed issue 12807: Produced 404 due to error in survey broke with template
Dev: put Dev : not need to be in changelog
Affected Issues
12807
mod - application/models/TemplateConfiguration.php Diff File

Issue History

Date Modified Username Field Change
2017-10-19 08:26 DenisChenu New Issue
2017-10-19 08:26 DenisChenu Status new => assigned
2017-10-19 08:26 DenisChenu Assigned To => DenisChenu
2017-10-19 08:26 DenisChenu File Added: PHP notice.html
2017-10-19 08:29 DenisChenu Changeset attached => LimeSurvey master 86f098d8
2017-10-19 08:29 DenisChenu Note Added: 44725
2017-10-19 08:29 DenisChenu Resolution open => fixed
2017-10-19 08:29 DenisChenu Status assigned => resolved
2017-10-19 08:29 DenisChenu Fixed in Version => 2.7x.x
2018-01-15 10:41 c_schmitz Note Added: 45784
2018-01-15 10:41 c_schmitz Status resolved => closed