View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
12173 | Bug reports | Plugins | public | 2017-03-07 13:50 | 2017-03-10 18:03 |
Reporter | DenisChenu | Assigned To | DenisChenu | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.64.x | ||||
Fixed in Version | 2.64.x | ||||
Summary | 12173: Error with pluginhelper?sa=sidebody direct link | ||||
Description | In pluginhelper?sa=sidebody : if EM is not initialized : receive a notice or page in error | ||||
Steps To Reproduce |
| ||||
Additional Information | PHP notice with debug and strnage page without | ||||
Tags | No tags attached. | ||||
Attached Files | PHP notice.html (23,192 bytes)
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"/> <title>PHP notice</title> <style type="text/css"> /*<![CDATA[*/ html,body,div,span,applet,object,iframe,h1,h2,h3,h4,h5,h6,p,blockquote,pre,a,abbr,acronym,address,big,cite,code,del,dfn,em,font,img,ins,kbd,q,s,samp,small,strike,strong,sub,sup,tt,var,b,u,i,center,dl,dt,dd,ol,ul,li,fieldset,form,label,legend,table,caption,tbody,tfoot,thead,tr,th,td{border:0;outline:0;font-size:100%;vertical-align:baseline;background:transparent;margin:0;padding:0;} body{line-height:1;} ol,ul{list-style:none;} blockquote,q{quotes:none;} blockquote:before,blockquote:after,q:before,q:after{content:none;} :focus{outline:0;} ins{text-decoration:none;} del{text-decoration:line-through;} table{border-collapse:collapse;border-spacing:0;} body { font: normal 9pt "Verdana"; color: #000; background: #fff; } h1 { font: normal 18pt "Verdana"; color: #f00; margin-bottom: .5em; } h2 { font: normal 14pt "Verdana"; color: #800000; margin-bottom: .5em; } h3 { font: bold 11pt "Verdana"; } pre { font: normal 11pt Menlo, Consolas, "Lucida Console", Monospace; } pre span.error { display: block; background: #fce3e3; } pre span.ln { color: #999; padding-right: 0.5em; border-right: 1px solid #ccc; } pre span.error-ln { font-weight: bold; } .container { margin: 1em 4em; } .version { color: gray; font-size: 8pt; border-top: 1px solid #aaa; padding-top: 1em; margin-bottom: 1em; } .message { color: #000; padding: 1em; font-size: 11pt; background: #f3f3f3; -webkit-border-radius: 10px; -moz-border-radius: 10px; border-radius: 10px; margin-bottom: 1em; line-height: 160%; } .source { margin-bottom: 1em; } .code pre { background-color: #ffe; margin: 0.5em 0; padding: 0.5em; line-height: 125%; border: 1px solid #eee; } .source .file { margin-bottom: 1em; font-weight: bold; } .traces { margin: 2em 0; } .trace { margin: 0.5em 0; padding: 0.5em; } .trace.app { border: 1px dashed #c00; } .trace .number { text-align: right; width: 2em; padding: 0.5em; } .trace .content { padding: 0.5em; } .trace .plus, .trace .minus { display:inline; vertical-align:middle; text-align:center; border:1px solid #000; color:#000; font-size:10px; line-height:10px; margin:0; padding:0 1px; width:10px; height:10px; } .trace.collapsed .minus, .trace.expanded .plus, .trace.collapsed pre { display: none; } .trace-file { cursor: pointer; padding: 0.2em; } .trace-file:hover { background: #f0ffff; } /*]]>*/ </style> </head> <body> <div class="container"> <h1>PHP notice</h1> <p class="message"> Undefined index: LEMsid </p> <div class="source"> <p class="file">/home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/application/helpers/expressions/em_manager_helper.php(4849)</p> <div class="code"><pre><span class="ln">4837</span> } <span class="ln">4838</span> // $LEM->runtimeTimings[] = array(__METHOD__,(microtime(true) - $now)); <span class="ln">4839</span> <span class="ln">4840</span> $LEM->initialized=true; <span class="ln">4841</span> <span class="ln">4842</span> if ($initializeVars) <span class="ln">4843</span> { <span class="ln">4844</span> $LEM->em->StartProcessingGroup( <span class="ln">4845</span> isset($_SESSION['LEMsid']) ? $_SESSION['LEMsid'] : NULL, <span class="ln">4846</span> '', <span class="ln">4847</span> true <span class="ln">4848</span> ); <span class="error"><span class="ln error-ln">4849</span> $LEM->setVariableAndTokenMappingsForExpressionManager($_SESSION['LEMsid']); </span><span class="ln">4850</span> } <span class="ln">4851</span> <span class="ln">4852</span> } <span class="ln">4853</span> <span class="ln">4854</span> /** <span class="ln">4855</span> * Initialize a survey so can use EM to manage navigation <span class="ln">4856</span> * @param int $surveyid <span class="ln">4857</span> * @param string $surveyMode <span class="ln">4858</span> * @param array $aSurveyOptions <span class="ln">4859</span> * @param bool $forceRefresh <span class="ln">4860</span> * @param int $debugLevel <span class="ln">4861</span> */ </pre></div> </div> <div class="traces"> <h2>Stack Trace</h2> <table style="width:100%;"> <tr class="trace app expanded"> <td class="number"> #0 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/application/core/Survey_Common_Action.php(261): <strong>LimeExpressionManager</strong>::<strong>StartProcessingPage</strong>(false, true) </div> <div class="code"><pre><span class="ln">256</span> { <span class="ln">257</span> $aData['oSurvey'] = Survey::model()->findByPk($aData['surveyid']); <span class="ln">258</span> <span class="ln">259</span> // Needed to evaluate EM expressions in question summary <span class="ln">260</span> // See bug #11845 <span class="error"><span class="ln error-ln">261</span> LimeExpressionManager::StartProcessingPage(false,true); </span><span class="ln">262</span> <span class="ln">263</span> $this->_titlebar($aData); <span class="ln">264</span> <span class="ln">265</span> //// Each view will call the correct bar as a subview. <span class="ln">266</span> $this->_surveybar($aData); </pre></div> </td> </tr> <tr class="trace app expanded"> <td class="number"> #1 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/application/controllers/admin/PluginHelper.php(40): <strong>Survey_Common_Action</strong>-><strong>_renderWrappedTemplate</strong>(null, array("super/sidebody"), array("surveyid" => "234152", "surveybar" => array("buttons" => array("view" => true)), "title_bar" => array("title" => "Test pivot table (ID:234152)"), "sidemenu" => array("state" => false), ...)) </div> <div class="code"><pre><span class="ln">35</span> $aData['sidemenu']['state'] = false; <span class="ln">36</span> $aData['sideMenuBehaviour'] = getGlobalSetting('sideMenuBehaviour'); <span class="ln">37</span> $aData['content'] = $content; <span class="ln">38</span> $aData['activated'] = $surveyinfo['active']; <span class="ln">39</span> $aData['sideMenuOpen'] = false; // TODO: Assume this for all plugins? <span class="error"><span class="ln error-ln">40</span> $this->_renderWrappedTemplate(null, array('super/sidebody'), $aData); </span><span class="ln">41</span> <span class="ln">42</span> } <span class="ln">43</span> <span class="ln">44</span> /** <span class="ln">45</span> * Helper function to let a plugin put content </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #2 </td> <td class="content"> <div class="trace-file"> unknown(0): <strong>PluginHelper</strong>-><strong>sidebody</strong>("234152", "MassAction", "actionIndex") </div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #3 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/framework/web/actions/CAction.php(109): <strong>ReflectionMethod</strong>-><strong>invokeArgs</strong>(PluginHelper, array("234152", "MassAction", "actionIndex")) </div> <div class="code"><pre><span class="ln">104</span> elseif($param->isDefaultValueAvailable()) <span class="ln">105</span> $ps[]=$param->getDefaultValue(); <span class="ln">106</span> else <span class="ln">107</span> return false; <span class="ln">108</span> } <span class="error"><span class="ln error-ln">109</span> $method->invokeArgs($object,$ps); </span><span class="ln">110</span> return true; <span class="ln">111</span> } <span class="ln">112</span> } </pre></div> </td> </tr> <tr class="trace app expanded"> <td class="number"> #4 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/application/core/Survey_Common_Action.php(101): <strong>CAction</strong>-><strong>runWithParamsInternal</strong>(PluginHelper, ReflectionMethod, array("sa" => "sidebody", "plugin" => "MassAction", "method" => "actionIndex", "surveyId" => "234152")) </div> <div class="code"><pre><span class="ln">096</span> $oMethod = new ReflectionMethod($this, $sDefault); <span class="ln">097</span> } <span class="ln">098</span> <span class="ln">099</span> // We're all good to go, let's execute it <span class="ln">100</span> // runWithParamsInternal would automatically get the parameters of the method and populate them as required with the params <span class="error"><span class="ln error-ln">101</span> return parent::runWithParamsInternal($this, $oMethod, $params); </span><span class="ln">102</span> } <span class="ln">103</span> <span class="ln">104</span> /** <span class="ln">105</span> * Some functions have different parameters, which are just an alias of the <span class="ln">106</span> * usual parameters we're getting in the url. This function just populates </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #5 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/framework/web/CController.php(308): <strong>Survey_Common_Action</strong>-><strong>runWithParams</strong>(array("sa" => "sidebody", "plugin" => "MassAction", "method" => "actionIndex", "surveyId" => "234152")) </div> <div class="code"><pre><span class="ln">303</span> { <span class="ln">304</span> $priorAction=$this->_action; <span class="ln">305</span> $this->_action=$action; <span class="ln">306</span> if($this->beforeAction($action)) <span class="ln">307</span> { <span class="error"><span class="ln error-ln">308</span> if($action->runWithParams($this->getActionParams())===false) </span><span class="ln">309</span> $this->invalidActionParams($action); <span class="ln">310</span> else <span class="ln">311</span> $this->afterAction($action); <span class="ln">312</span> } <span class="ln">313</span> $this->_action=$priorAction; </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #6 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/framework/web/CController.php(286): <strong>CController</strong>-><strong>runAction</strong>(PluginHelper) </div> <div class="code"><pre><span class="ln">281</span> * @see runAction <span class="ln">282</span> */ <span class="ln">283</span> public function runActionWithFilters($action,$filters) <span class="ln">284</span> { <span class="ln">285</span> if(empty($filters)) <span class="error"><span class="ln error-ln">286</span> $this->runAction($action); </span><span class="ln">287</span> else <span class="ln">288</span> { <span class="ln">289</span> $priorAction=$this->_action; <span class="ln">290</span> $this->_action=$action; <span class="ln">291</span> CFilterChain::create($this,$action,$filters)->run(); </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #7 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/framework/web/CController.php(265): <strong>CController</strong>-><strong>runActionWithFilters</strong>(PluginHelper, array()) </div> <div class="code"><pre><span class="ln">260</span> { <span class="ln">261</span> if(($parent=$this->getModule())===null) <span class="ln">262</span> $parent=Yii::app(); <span class="ln">263</span> if($parent->beforeControllerAction($this,$action)) <span class="ln">264</span> { <span class="error"><span class="ln error-ln">265</span> $this->runActionWithFilters($action,$this->filters()); </span><span class="ln">266</span> $parent->afterControllerAction($this,$action); <span class="ln">267</span> } <span class="ln">268</span> } <span class="ln">269</span> else <span class="ln">270</span> $this->missingAction($actionID); </pre></div> </td> </tr> <tr class="trace app collapsed"> <td class="number"> #8 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/application/controllers/AdminController.php(177): <strong>CController</strong>-><strong>run</strong>("pluginhelper") </div> <div class="code"><pre><span class="ln">172</span> $this->redirect(array('/admin/authentication/sa/login')); <span class="ln">173</span> } <span class="ln">174</span> <span class="ln">175</span> } <span class="ln">176</span> <span class="error"><span class="ln error-ln">177</span> return parent::run($action); </span><span class="ln">178</span> } <span class="ln">179</span> <span class="ln">180</span> /** <span class="ln">181</span> * Routes all the actions to their respective places <span class="ln">182</span> * </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #9 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/framework/web/CWebApplication.php(282): <strong>AdminController</strong>-><strong>run</strong>("pluginhelper") </div> <div class="code"><pre><span class="ln">277</span> { <span class="ln">278</span> list($controller,$actionID)=$ca; <span class="ln">279</span> $oldController=$this->_controller; <span class="ln">280</span> $this->_controller=$controller; <span class="ln">281</span> $controller->init(); <span class="error"><span class="ln error-ln">282</span> $controller->run($actionID); </span><span class="ln">283</span> $this->_controller=$oldController; <span class="ln">284</span> } <span class="ln">285</span> else <span class="ln">286</span> throw new CHttpException(404,Yii::t('yii','Unable to resolve the request "{route}".', <span class="ln">287</span> array('{route}'=>$route===''?$this->defaultController:$route))); </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #10 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/framework/web/CWebApplication.php(141): <strong>CWebApplication</strong>-><strong>runController</strong>("admin/pluginhelper") </div> <div class="code"><pre><span class="ln">136</span> foreach(array_splice($this->catchAllRequest,1) as $name=>$value) <span class="ln">137</span> $_GET[$name]=$value; <span class="ln">138</span> } <span class="ln">139</span> else <span class="ln">140</span> $route=$this->getUrlManager()->parseUrl($this->getRequest()); <span class="error"><span class="ln error-ln">141</span> $this->runController($route); </span><span class="ln">142</span> } <span class="ln">143</span> <span class="ln">144</span> /** <span class="ln">145</span> * Registers the core application components. <span class="ln">146</span> * This method overrides the parent implementation by registering additional core components. </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #11 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/framework/base/CApplication.php(185): <strong>CWebApplication</strong>-><strong>processRequest</strong>() </div> <div class="code"><pre><span class="ln">180</span> public function run() <span class="ln">181</span> { <span class="ln">182</span> if($this->hasEventHandler('onBeginRequest')) <span class="ln">183</span> $this->onBeginRequest(new CEvent($this)); <span class="ln">184</span> register_shutdown_function(array($this,'end'),0,false); <span class="error"><span class="ln error-ln">185</span> $this->processRequest(); </span><span class="ln">186</span> if($this->hasEventHandler('onEndRequest')) <span class="ln">187</span> $this->onEndRequest(new CEvent($this)); <span class="ln">188</span> } <span class="ln">189</span> <span class="ln">190</span> /** </pre></div> </td> </tr> <tr class="trace app collapsed"> <td class="number"> #12 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/index.php(214): <strong>CApplication</strong>-><strong>run</strong>() </div> <div class="code"><pre><span class="ln">209</span> die (sprintf('%s should be writable by the webserver (766 or 776).', $sDefaultRuntimePath)); <span class="ln">210</span> } <span class="ln">211</span> } <span class="ln">212</span> <span class="ln">213</span> Yii::$enableIncludePath = false; <span class="error"><span class="ln error-ln">214</span> Yii::createApplication('LSYii_Application', $config)->run(); </span><span class="ln">215</span> <span class="ln">216</span> /* End of file index.php */ <span class="ln">217</span> /* Location: ./index.php */ </pre></div> </td> </tr> </table> </div> <div class="version"> 2017-03-07 13:43:45 Apache/2.2.22 (Debian) <a href="http://www.yiiframework.com/">Yii Framework</a>/1.1.17 </div> </div> <script type="text/javascript"> /*<![CDATA[*/ var traceReg = new RegExp("(^|\\s)trace-file(\\s|$)"); var collapsedReg = new RegExp("(^|\\s)collapsed(\\s|$)"); var e = document.getElementsByTagName("div"); for(var j=0,len=e.length;j<len;j++){ if(traceReg.test(e[j].className)){ e[j].onclick = function(){ var trace = this.parentNode.parentNode; if(collapsedReg.test(trace.className)) trace.className = trace.className.replace("collapsed", "expanded"); else trace.className = trace.className.replace("expanded", "collapsed"); } } } /*]]>*/ </script> </body> </html> <!-- start log messages --> <table class="yiiLog" width="100%" cellpadding="2" style="border-spacing:1px;font:11px Verdana, Arial, Helvetica, sans-serif;background:#EEEEEE;color:#666666;"> <tr> <th style="background:black;color:white;" colspan="5"> Application Log </th> </tr> <tr style="background-color: #ccc;"> <th style="width:120px">Timestamp</th> <th>Level</th> <th>Category</th> <th>Message</th> </tr> <tr style="background:#FFC0CB"> <td align="center">13:43:45.077281</td> <td>error</td> <td>php</td> <td><pre>Undefined index: LEMsid (/home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/application/helpers/expressions/em_manager_helper.php:4849) Stack trace: #0 unknown(0): PluginHelper->sidebody() #1 /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/framework/web/actions/CAction.php(109): ReflectionMethod->invokeArgs() #2 /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/application/core/Survey_Common_Action.php(101): PluginHelper->runWithParamsInternal() #3 /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/framework/web/CController.php(308): PluginHelper->runWithParams() #4 /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/framework/web/CController.php(286): AdminController->runAction() #5 /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/framework/web/CController.php(265): AdminController->runActionWithFilters() #6 /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/application/controllers/AdminController.php(177): AdminController->run() #7 /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/framework/web/CWebApplication.php(282): AdminController->run() #8 /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/framework/web/CWebApplication.php(141): LSYii_Application->runController() #9 /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/framework/base/CApplication.php(185): LSYii_Application->processRequest() #10 /home/sondages.pro/htdocs/limesurvey_GIT/testing/masterall/index.php(214): LSYii_Application->run() REQUEST_URI=/masterall/admin/pluginhelper?sa=sidebody&plugin=MassAction&method=actionIndex&surveyId=234152</pre></td> </tr></table> <!-- end of log messages --> | ||||
Bug heat | 4 | ||||
Complete LimeSurvey version number (& build) | 2.64.0 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | FF51.0.1 | ||||
Database type & version | not relevant | ||||
Server OS (if known) | not relevant | ||||
Webserver software & version (if known) | not relevant | ||||
PHP Version | not relevant ? | ||||
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=22450 |
|
New version released |
|
LimeSurvey: master cf2b2eed 2017-03-07 15:22 Details Diff |
Fixed issue 12173: Error with pluginhelper?sa=sidebody direct link Dev: surveyId !=sid !=surveyid !=iSurveyId ,and iSurveyId need to start EM Dev: not broken API fix |
Affected Issues 12173 |
|
mod - application/core/Survey_Common_Action.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2017-03-07 13:50 | DenisChenu | New Issue | |
2017-03-07 13:50 | DenisChenu | Status | new => assigned |
2017-03-07 13:50 | DenisChenu | Assigned To | => DenisChenu |
2017-03-07 13:50 | DenisChenu | File Added: Capture du 2017-03-07 13-45-37.png | |
2017-03-07 13:50 | DenisChenu | File Added: PHP notice.html | |
2017-03-07 14:25 | DenisChenu | Changeset attached | => LimeSurvey master cf2b2eed |
2017-03-07 14:25 | DenisChenu | Note Added: 43187 | |
2017-03-07 14:25 | DenisChenu | Resolution | open => fixed |
2017-03-07 16:23 | DenisChenu | Status | assigned => resolved |
2017-03-07 16:23 | DenisChenu | Fixed in Version | => 2.64.x |
2017-03-10 18:03 | c_schmitz | Note Added: 43256 | |
2017-03-10 18:03 | c_schmitz | Status | resolved => closed |