View Issue Details

Jump to NotesJump to History
This issue affects 1 person(s).
 2
IDProjectCategoryView StatusDate SubmittedLast Update
11946Bug reportsSurvey editingpublic2016-11-23 10:162016-11-23 11:58
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionno change required 
Summary11946: .dialog is not a function in admin part
Description

See screenshot in the last version

Steps To Reproduce

Load a admin page and look at console

Additional Information

It's a merge issue :
$ git checkout 1a72a0cef812906496f4c62caaf1e4a7a58dccd5 : https://github.com/LimeSurvey/LimeSurvey/commit/1a72a0cef812906496f4c62caaf1e4a7a58dccd5
=> OK
$ git checkout 488f4a97153e51f70b978b01c99385c8ee5f548f : https://github.com/LimeSurvey/LimeSurvey/commit/488f4a97153e51f70b978b01c99385c8ee5f548f
Previous HEAD position was 1a72a0c... Dev: Run admin theme generator script
HEAD is now at 488f4a9... Merge branch 'master' of git@github.com:LimeSurvey/LimeSurvey.git into develop
=> KO/Broken

TagsNo tags attached.
Attached Files
Capture du 2016-11-23 10-09-09.png (41,539 bytes)   
Capture du 2016-11-23 10-09-09.png (41,539 bytes)   
loadafter.png (130,939 bytes)
Bug heat2
Complete LimeSurvey version number (& build)20161123
I will donate to the project if issue is resolvedNo
BrowserFF50
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-11-23 10:23

developer   ~42182

Oups, not merge issue : checkout goes to master :)
DenisChenu

DenisChenu

2016-11-23 10:32

developer   ~42184

Oups ...; jquery3.0 update, maybe i lost some jqueryui part in bundle

$ git checkout 6ad06c67d0957abee7901528f7159b0c823fa2b3
Previous HEAD position was 87a9fb8... Dev: new feature 11930: Show visually the { } for expression managed forced attribute Dev: for textarea too please
HEAD is now at 6ad06c6... Dev: ls-input-group broke in multiline with xss screen : seems better Dev: sr-only width nowrap : see https://github.com/h5bp/html5-boilerplate/issues/1874 and others link (accessibilty too) Dev: remove console.log in notify : console come bigger in next commit
======> OK
$ git checkout 3c1de66ec1ec381b243214ec3558d7fe6e900731
Previous HEAD position was 6ad06c6... Dev: ls-input-group broke in multiline with xss screen : seems better Dev: sr-only width nowrap : see https://github.com/h5bp/html5-boilerplate/issues/1874 and others link (accessibilty too) Dev: remove console.log in notify : console come bigger in next commit
HEAD is now at 3c1de66... Dev: Update to jquery 3.1.1 + migrate 3.0.0 Dev: Update jquery-ui to 1.12.1 : migrate show a bunch of error Dev: Add 'Development version' to have warning in console
======> KO
DenisChenu

DenisChenu

2016-11-23 10:38

developer   ~42186

....
https://github.com/jquery/jquery/issues/3157

BUT : migrate is here ....
DenisChenu

DenisChenu

2016-11-23 10:43

developer   ~42188

WTF :
<script type="text/javascript" src="/answershtml/tmp/assets/26dc4d7/jquery-3.1.1.js"></script>
<script type="text/javascript" src="/answershtml/tmp/assets/26dc4d7/jquery-migrate-3.0.0.js"></script>
<script type="text/javascript" src="/answershtml/tmp/assets/2b5158ea/jquery-ui.js"></script>
<script type="text/javascript" src="/answershtml/tmp/assets/4b875e4e/jquery.cookie.js"></script>

BUT : in firefox console:
jquery-ui is loaded BEFORE jquery.
DenisChenu

DenisChenu

2016-11-23 10:56

developer   ~42189

Shit ....

revert/update/ sometimes it's OK, sometimes not ....
DenisChenu

DenisChenu

2016-11-23 11:11

developer   ~42190

firebug issue ?????

Activate firebug : see the error / dialog didn't open
Don't activate firebug (but FireFox console) : don't see error / dialog open ...
DenisChenu

DenisChenu

2016-11-23 11:37

developer   ~42191

I report the bug in firebug and close this issue.
DenisChenu

DenisChenu

2016-11-23 11:58

developer   ~42193

https://blog.getfirebug.com/2016/02/08/merging-firebug-into-the-built-in-firefox-developer-tools/

Issue History

Date Modified Username Field Change
2016-11-23 10:16 DenisChenu New Issue
2016-11-23 10:16 DenisChenu File Added: Capture du 2016-11-23 10-09-09.png
2016-11-23 10:23 DenisChenu Assigned To => DenisChenu
2016-11-23 10:23 DenisChenu Status new => assigned
2016-11-23 10:23 DenisChenu Note Added: 42182
2016-11-23 10:32 DenisChenu Note Added: 42184
2016-11-23 10:38 DenisChenu Note Added: 42186
2016-11-23 10:43 DenisChenu File Added: Capture du 2016-11-23 10-43-06.png
2016-11-23 10:43 DenisChenu Note Added: 42188
2016-11-23 10:44 DenisChenu File Deleted: Capture du 2016-11-23 10-43-06.png
2016-11-23 10:44 DenisChenu File Added: Capture du 2016-11-23 10-38-38.png
2016-11-23 10:44 DenisChenu File Deleted: Capture du 2016-11-23 10-38-38.png
2016-11-23 10:45 DenisChenu File Added: loadafter.png
2016-11-23 10:56 DenisChenu Status assigned => closed
2016-11-23 10:56 DenisChenu Resolution open => unable to reproduce
2016-11-23 10:56 DenisChenu Note Added: 42189
2016-11-23 10:56 DenisChenu Status closed => new
2016-11-23 10:56 DenisChenu Resolution unable to reproduce => reopened
2016-11-23 11:11 DenisChenu Note Added: 42190
2016-11-23 11:37 DenisChenu Status new => feedback
2016-11-23 11:37 DenisChenu Note Added: 42191
2016-11-23 11:58 DenisChenu Status feedback => closed
2016-11-23 11:58 DenisChenu Resolution reopened => no change required
2016-11-23 11:58 DenisChenu Note Added: 42193
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing