View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
11903Bug reportsSurvey editingpublic2017-07-21 17:08
Reportertammo Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version2.55.x 
Target Version3.0.x 
Summary11903: Bad alignment of repeated headers
Description

Headers are left aligned and in normal font, while first headers are centered and in bold.

See attached image

TagsNo tags attached.
Attached Files
headers-alignment.png (23,934 bytes)   
headers-alignment.png (23,934 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)3.0.0 alpha (2.55.3 merged)
I will donate to the project if issue is resolvedNo
Browserff
Database type & versionff
Server OS (if known)ff
Webserver software & version (if known)ff
PHP Versionff

Users monitoring this issue

There are no users monitoring this issue.

Activities

tammo

tammo

2016-11-14 17:06

developer   ~41917

Attached survey (same as previous error report).

DenisChenu

DenisChenu

2016-11-14 17:08

developer   ~41918

But ??? I think i already fix it ... surely in precedent default .... :-\

tammo

tammo

2016-11-14 17:10

developer   ~41920

Strange, sometimes it seems previous edits seem to get lost. I also do not see my addition for small displays any more. I thought that I had done something wrong in GIT..

DenisChenu

DenisChenu

2016-11-14 17:20

developer   ~41922

For me : it's surely in one pof 'precedent' template. Maybe default when flatmodern exist.

What is you update about small display ?
If it's this : https://github.com/LimeSurvey/LimeSurvey/commit/94f2b86d563229e53ce14e12e804f00e31e99eaf#diff-ed0951e7a3b1d0add348df7bab8341afR626
You need to test with a real phone (i tell you that on the bug report) see https://github.com/LimeSurvey/LimeSurvey/commit/a94aecbb8ed299034b3829ee8666b28185b32de9#diff-ed0951e7a3b1d0add348df7bab8341afR626

PS : about px : why can not cm directly for min-height ?
Did you have a link about "min-height" for button in phone ?

DenisChenu

DenisChenu

2016-11-14 17:31

developer   ~41924

I can not reproduce ....

Fixed here :
https://github.com/LimeSurvey/LimeSurvey/commit/b7cb7d80c7672725b1d7708e64979d4a40add6a8#diff-eba34bc02d2cbd778d86a42b0397731fR48

Tested here : http://testing.sondages.pro/answershtml/index.php/survey/index/sid/696372/newtest/Y/lang/en

BUT : maybe it's lack of ls-heading class in array/text : did you test all other ?

tammo

tammo

2016-11-14 17:39

developer   ~41927

You are right: it was that commit and you did tell me about that. Why only test on mobile phone? Why not on small screen on my laptop: this is extra efford since I develop locally and cannot reach my localhost with my mobile. Or do you have a trick for that (I guess you have...)

https://www.researchgate.net/post/What_would_be_the_optimum_button_size_for_the_Android_iOS_Windows_native_applications

https://material.google.com/layout/metrics-keylines.html#metrics-keylines-keylines-spacing

It is a discussion:
http://stackoverflow.com/questions/1928991/minimum-sensible-button-size-on-iphone

tammo

tammo

2016-11-14 17:44

developer   ~41928

Je suis desolé. I just made a new GIT clone and I emptied /tmp/assets
Debug=1 and still this happens.

I will test your survey.

DenisChenu

DenisChenu

2016-11-14 19:03

developer   ~41940

Fixe : question type dependant .

For testing : you can remove max-device-width why not.

But still :

  • h1 is reallu little here
  • why this px ? why not other .

Maybe test with boostrap btn class for example. Seems only the "display:inline-block" need replacement

DenisChenu

DenisChenu

2016-11-14 19:08

developer   ~41941

About : height : we can add btn. But seems really more quick to add more padding-top/bottom for td.input-radio / td-input-checkbox.

I can review it in template-core : not an issue

We need 0 padding for right part and 20px padding for left. But nothing about top/bottom padding

tammo

tammo

2016-11-14 19:19

developer   ~41943

Why not other? Well, it had to be something...
I thought that this looked good, and it is just a little larger than the body font-size.

I have been struggling a lot with small screens, especially when the keyboard is shown for text questions...

In the ideal situation I would like the menu bar to behave like on many sites: disappear when scrolling down, re-appear when scrolling up.

c_schmitz

c_schmitz

2017-07-21 17:08

administrator   ~44157

Version 3.0.0-beta.1 released

Related Changesets

LimeSurvey: develop ad8d6a0b

2016-11-14 19:57

DenisChenu


Details Diff
Dev: issue 11903: Bad alignment of repeated headers
Dev: please : question type information :)
Affected Issues
11903
mod - application/views/survey/questions/arrays/10point/answer.php Diff File
mod - application/views/survey/questions/arrays/5point/answer.php Diff File
mod - application/views/survey/questions/arrays/multiflexi/answer.php Diff File
mod - application/views/survey/questions/arrays/multiflexi/rows/repeat_header.php Diff File
mod - application/views/survey/questions/arrays/texts/rows/repeat_header.php Diff File

Issue History

Date Modified Username Field Change
2016-11-14 17:06 tammo New Issue
2016-11-14 17:06 tammo Status new => assigned
2016-11-14 17:06 tammo Assigned To => DenisChenu
2016-11-14 17:06 tammo File Added: headers-alignment.png
2016-11-14 17:06 tammo File Added: limesurvey_survey_319974(2).lss
2016-11-14 17:06 tammo Note Added: 41917
2016-11-14 17:08 DenisChenu Note Added: 41918
2016-11-14 17:10 tammo Note Added: 41920
2016-11-14 17:20 DenisChenu Note Added: 41922
2016-11-14 17:31 DenisChenu Note Added: 41924
2016-11-14 17:32 DenisChenu File Added: limesurvey_survey_bigarrayfiltered.lss
2016-11-14 17:39 tammo Note Added: 41927
2016-11-14 17:44 tammo Note Added: 41928
2016-11-14 18:58 DenisChenu Changeset attached => LimeSurvey develop ad8d6a0b
2016-11-14 19:03 DenisChenu Note Added: 41940
2016-11-14 19:04 DenisChenu Status assigned => resolved
2016-11-14 19:04 DenisChenu Resolution open => fixed
2016-11-14 19:04 DenisChenu Fixed in Version => 3.0
2016-11-14 19:08 DenisChenu Note Added: 41941
2016-11-14 19:19 tammo Note Added: 41943
2017-07-21 17:08 c_schmitz Note Added: 44157
2017-07-21 17:08 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing