View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
11746Bug reportsSurvey editingpublic2016-10-14 10:24
ReporterDenisChenu Assigned Toc_schmitz  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version2.53 
Fixed in Version2.54 
Summary11746: When previewing an hidden question : PHP notice (debug at 2)
Description

When we preview an hidden question debug at 2 send PHP Notice

Steps To Reproduce

Go to any question, set hidden to true, click on preview (Question)

Additional Information

I have this error a lot when make patch : because hidden is very quick to set ;).

It's really a minor issue, but maybe we must control if qanda is set and show something if not ?

Some sentence like "This survey can not ...."

TagsNo tags attached.
Attached Files
PHP notice.html (17,707 bytes)   
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"><head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>PHP notice</title>

<style type="text/css">
/*<![CDATA[*/
html,body,div,span,applet,object,iframe,h1,h2,h3,h4,h5,h6,p,blockquote,pre,a,abbr,acronym,address,big,cite,code,del,dfn,em,font,img,ins,kbd,q,s,samp,small,strike,strong,sub,sup,tt,var,b,u,i,center,dl,dt,dd,ol,ul,li,fieldset,form,label,legend,table,caption,tbody,tfoot,thead,tr,th,td{border:0;outline:0;font-size:100%;vertical-align:baseline;background:transparent;margin:0;padding:0;}
body{line-height:1;}
ol,ul{list-style:none;}
blockquote,q{quotes:none;}
blockquote:before,blockquote:after,q:before,q:after{content:none;}
:focus{outline:0;}
ins{text-decoration:none;}
del{text-decoration:line-through;}
table{border-collapse:collapse;border-spacing:0;}

body {
	font: normal 9pt "Verdana";
	color: #000;
	background: #fff;
}

h1 {
	font: normal 18pt "Verdana";
	color: #f00;
	margin-bottom: .5em;
}

h2 {
	font: normal 14pt "Verdana";
	color: #800000;
	margin-bottom: .5em;
}

h3 {
	font: bold 11pt "Verdana";
}

pre {
	font: normal 11pt Menlo, Consolas, "Lucida Console", Monospace;
}

pre span.error {
	display: block;
	background: #fce3e3;
}

pre span.ln {
	color: #999;
	padding-right: 0.5em;
	border-right: 1px solid #ccc;
}

pre span.error-ln {
	font-weight: bold;
}

.container {
	margin: 1em 4em;
}

.version {
	color: gray;
	font-size: 8pt;
	border-top: 1px solid #aaa;
	padding-top: 1em;
	margin-bottom: 1em;
}

.message {
	color: #000;
	padding: 1em;
	font-size: 11pt;
	background: #f3f3f3;
	-webkit-border-radius: 10px;
	-moz-border-radius: 10px;
	border-radius: 10px;
	margin-bottom: 1em;
	line-height: 160%;
}

.source {
	margin-bottom: 1em;
}

.code pre {
	background-color: #ffe;
	margin: 0.5em 0;
	padding: 0.5em;
	line-height: 125%;
	border: 1px solid #eee;
}

.source .file {
	margin-bottom: 1em;
	font-weight: bold;
}

.traces {
	margin: 2em 0;
}

.trace {
	margin: 0.5em 0;
	padding: 0.5em;
}

.trace.app {
	border: 1px dashed #c00;
}

.trace .number {
	text-align: right;
	width: 2em;
	padding: 0.5em;
}

.trace .content {
	padding: 0.5em;
}

.trace .plus,
.trace .minus {
	display:inline;
	vertical-align:middle;
	text-align:center;
	border:1px solid #000;
	color:#000;
	font-size:10px;
	line-height:10px;
	margin:0;
	padding:0 1px;
	width:10px;
	height:10px;
}

.trace.collapsed .minus,
.trace.expanded .plus,
.trace.collapsed pre {
	display: none;
}

.trace-file {
	cursor: pointer;
	padding: 0.2em;
}

.trace-file:hover {
	background: #f0ffff;
}
/*]]>*/
</style>
</head>

<body>
<div class="container">
	<h1>PHP notice</h1>

	<p class="message">
		Undefined variable: qanda	</p>

	<div class="source">
		<p class="file">/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/application/helpers/SurveyRuntimeHelper.php(1283)</p>
		<div class="code"><pre><span class="ln">1271</span>             }
<span class="ln">1272</span> 
<span class="ln">1273</span>             $showgroupdesc_ = $showgroupinfo_ == 'B' /* both */ || $showgroupinfo_ == 'D'; /* (group-) description */
<span class="ln">1274</span> 
<span class="ln">1275</span>             if (!$previewquestion &amp;&amp; trim($redata['groupdescription'])!="" &amp;&amp; $showgroupdesc_)
<span class="ln">1276</span>             {
<span class="ln">1277</span>                 echo templatereplace(file_get_contents($sTemplateViewPath."groupdescription.pstpl"), array(), $redata);
<span class="ln">1278</span>             }
<span class="ln">1279</span>             echo "\n";
<span class="ln">1280</span> 
<span class="ln">1281</span>             echo "\n\n&lt;!-- PRESENT THE QUESTIONS (in SurveyRunTime )  --&gt;\n";
<span class="ln">1282</span> 
<span class="error"><span class="ln error-ln">1283</span>             foreach ($qanda as $qa) // one entry per QID
</span><span class="ln">1284</span>             {
<span class="ln">1285</span>                 // Test if finalgroup is in this qid (for all in one survey, else we do only qanda for needed question (in one by one or group by goup)
<span class="ln">1286</span>                 if ($gid != $qa['finalgroup']) {
<span class="ln">1287</span>                     continue;
<span class="ln">1288</span>                 }
<span class="ln">1289</span>                 $qid = $qa[4];
<span class="ln">1290</span>                 $qinfo = LimeExpressionManager::GetQuestionStatus($qid);
<span class="ln">1291</span>                 $lastgrouparray = explode("X", $qa[7]);
<span class="ln">1292</span>                 $lastgroup = $lastgrouparray[0] . "X" . $lastgrouparray[1]; // id of the last group, derived from question id
<span class="ln">1293</span>                 $lastanswer = $qa[7];
<span class="ln">1294</span> 
<span class="ln">1295</span> 
</pre></div>	</div>

	<div class="traces">
		<h2>Stack Trace</h2>
				<table style="width:100%;">
						<tbody><tr class="trace app expanded">
			<td class="number">
				#0			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/application/controllers/survey/index.php(611): <strong>SurveyRuntimeHelper</strong>-&gt;<strong>run</strong>("44899",
 array("surveyid" =&gt; "44899", "thissurvey" =&gt; array("template" 
=&gt; "default", "language" =&gt; "fr", "sid" =&gt; "44899", "owner_id" 
=&gt; "1", ...), "thisstep" =&gt; null, "tokensexist" =&gt; 0, ...))				</div>

				<div class="code"><pre><span class="ln">606</span>         //Send local variables to the appropriate survey type
<span class="ln">607</span>         unset($redata);
<span class="ln">608</span>         $redata = compact(array_keys(get_defined_vars()));
<span class="ln">609</span>         Yii::import('application.helpers.SurveyRuntimeHelper');
<span class="ln">610</span>         $tmp = new SurveyRuntimeHelper();
<span class="error"><span class="ln error-ln">611</span>         $tmp-&gt;run($surveyid,$redata);
</span><span class="ln">612</span> 
<span class="ln">613</span>         if (App()-&gt;request-&gt;getPost('saveall') || isset($flashmessage))
<span class="ln">614</span>         {
<span class="ln">615</span>             App()-&gt;clientScript-&gt;registerScript("saveflashmessage","alert('".gT("Your responses were successfully saved.","js")."');",CClientScript::POS_READY);
<span class="ln">616</span>         }
</pre></div>			</td>
		</tr>
						<tr class="trace app expanded">
			<td class="number">
				#1			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/application/controllers/survey/index.php(70): <strong>index</strong>-&gt;<strong>action</strong>()				</div>

				<div class="code"><pre><span class="ln">65</span>             App()-&gt;getClientScript()-&gt;reset();
<span class="ln">66</span>             return $buffer;
<span class="ln">67</span>         });
<span class="ln">68</span> 
<span class="ln">69</span>         ob_implicit_flush(false);
<span class="error"><span class="ln error-ln">70</span>         $this-&gt;action();
</span><span class="ln">71</span>         ob_flush();
<span class="ln">72</span>     }
<span class="ln">73</span> 
<span class="ln">74</span>     function action()
<span class="ln">75</span>     {
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#2			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/actions/CAction.php(76): <strong>index</strong>-&gt;<strong>run</strong>()				</div>

				<div class="code"><pre><span class="ln">71</span>     {
<span class="ln">72</span>         $method=new ReflectionMethod($this, 'run');
<span class="ln">73</span>         if($method-&gt;getNumberOfParameters()&gt;0)
<span class="ln">74</span>             return $this-&gt;runWithParamsInternal($this, $method, $params);
<span class="ln">75</span> 
<span class="error"><span class="ln error-ln">76</span>         $this-&gt;run();
</span><span class="ln">77</span>         return true;
<span class="ln">78</span>     }
<span class="ln">79</span> 
<span class="ln">80</span>     /**
<span class="ln">81</span>      * Executes a method of an object with the supplied named parameters.
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#3			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/CController.php(308): <strong>CAction</strong>-&gt;<strong>runWithParams</strong>(array("action" =&gt; "previewquestion", "sid" =&gt; "44899", "gid" =&gt; "2827", "qid" =&gt; "54433"))				</div>

				<div class="code"><pre><span class="ln">303</span>     {
<span class="ln">304</span>         $priorAction=$this-&gt;_action;
<span class="ln">305</span>         $this-&gt;_action=$action;
<span class="ln">306</span>         if($this-&gt;beforeAction($action))
<span class="ln">307</span>         {
<span class="error"><span class="ln error-ln">308</span>             if($action-&gt;runWithParams($this-&gt;getActionParams())===false)
</span><span class="ln">309</span>                 $this-&gt;invalidActionParams($action);
<span class="ln">310</span>             else
<span class="ln">311</span>                 $this-&gt;afterAction($action);
<span class="ln">312</span>         }
<span class="ln">313</span>         $this-&gt;_action=$priorAction;
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#4			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/CController.php(286): <strong>CController</strong>-&gt;<strong>runAction</strong>(index)				</div>

				<div class="code"><pre><span class="ln">281</span>      * @see runAction
<span class="ln">282</span>      */
<span class="ln">283</span>     public function runActionWithFilters($action,$filters)
<span class="ln">284</span>     {
<span class="ln">285</span>         if(empty($filters))
<span class="error"><span class="ln error-ln">286</span>             $this-&gt;runAction($action);
</span><span class="ln">287</span>         else
<span class="ln">288</span>         {
<span class="ln">289</span>             $priorAction=$this-&gt;_action;
<span class="ln">290</span>             $this-&gt;_action=$action;
<span class="ln">291</span>             CFilterChain::create($this,$action,$filters)-&gt;run();
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#5			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/CController.php(265): <strong>CController</strong>-&gt;<strong>runActionWithFilters</strong>(index, array())				</div>

				<div class="code"><pre><span class="ln">260</span>         {
<span class="ln">261</span>             if(($parent=$this-&gt;getModule())===null)
<span class="ln">262</span>                 $parent=Yii::app();
<span class="ln">263</span>             if($parent-&gt;beforeControllerAction($this,$action))
<span class="ln">264</span>             {
<span class="error"><span class="ln error-ln">265</span>                 $this-&gt;runActionWithFilters($action,$this-&gt;filters());
</span><span class="ln">266</span>                 $parent-&gt;afterControllerAction($this,$action);
<span class="ln">267</span>             }
<span class="ln">268</span>         }
<span class="ln">269</span>         else
<span class="ln">270</span>             $this-&gt;missingAction($actionID);
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#6			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/CWebApplication.php(282): <strong>CController</strong>-&gt;<strong>run</strong>("index")				</div>

				<div class="code"><pre><span class="ln">277</span>         {
<span class="ln">278</span>             list($controller,$actionID)=$ca;
<span class="ln">279</span>             $oldController=$this-&gt;_controller;
<span class="ln">280</span>             $this-&gt;_controller=$controller;
<span class="ln">281</span>             $controller-&gt;init();
<span class="error"><span class="ln error-ln">282</span>             $controller-&gt;run($actionID);
</span><span class="ln">283</span>             $this-&gt;_controller=$oldController;
<span class="ln">284</span>         }
<span class="ln">285</span>         else
<span class="ln">286</span>             throw new CHttpException(404,Yii::t('yii','Unable to resolve the request "{route}".',
<span class="ln">287</span>                 array('{route}'=&gt;$route===''?$this-&gt;defaultController:$route)));
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#7			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/web/CWebApplication.php(141): <strong>CWebApplication</strong>-&gt;<strong>runController</strong>("survey/index/action/previewquestion/sid/44899/gid/2827/qid/54433")				</div>

				<div class="code"><pre><span class="ln">136</span>             foreach(array_splice($this-&gt;catchAllRequest,1) as $name=&gt;$value)
<span class="ln">137</span>                 $_GET[$name]=$value;
<span class="ln">138</span>         }
<span class="ln">139</span>         else
<span class="ln">140</span>             $route=$this-&gt;getUrlManager()-&gt;parseUrl($this-&gt;getRequest());
<span class="error"><span class="ln error-ln">141</span>         $this-&gt;runController($route);
</span><span class="ln">142</span>     }
<span class="ln">143</span> 
<span class="ln">144</span>     /**
<span class="ln">145</span>      * Registers the core application components.
<span class="ln">146</span>      * This method overrides the parent implementation by registering additional core components.
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#8			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/framework/base/CApplication.php(185): <strong>CWebApplication</strong>-&gt;<strong>processRequest</strong>()				</div>

				<div class="code"><pre><span class="ln">180</span>     public function run()
<span class="ln">181</span>     {
<span class="ln">182</span>         if($this-&gt;hasEventHandler('onBeginRequest'))
<span class="ln">183</span>             $this-&gt;onBeginRequest(new CEvent($this));
<span class="ln">184</span>         register_shutdown_function(array($this,'end'),0,false);
<span class="error"><span class="ln error-ln">185</span>         $this-&gt;processRequest();
</span><span class="ln">186</span>         if($this-&gt;hasEventHandler('onEndRequest'))
<span class="ln">187</span>             $this-&gt;onEndRequest(new CEvent($this));
<span class="ln">188</span>     }
<span class="ln">189</span> 
<span class="ln">190</span>     /**
</pre></div>			</td>
		</tr>
						<tr class="trace app expanded">
			<td class="number">
				#9			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/home/sondages.pro/htdocs/limesurvey_GIT/LimeSurvey/index.php(214): <strong>CApplication</strong>-&gt;<strong>run</strong>()				</div>

				<div class="code"><pre><span class="ln">209</span>         die (sprintf('%s should be writable by the webserver (766 or 776).', $sDefaultRuntimePath));
<span class="ln">210</span>     }
<span class="ln">211</span> }
<span class="ln">212</span> 
<span class="ln">213</span> Yii::$enableIncludePath = false;
<span class="error"><span class="ln error-ln">214</span> Yii::createApplication('LSYii_Application', $config)-&gt;run();
</span><span class="ln">215</span> 
<span class="ln">216</span> /* End of file index.php */
<span class="ln">217</span> /* Location: ./index.php */
</pre></div>			</td>
		</tr>
				</tbody></table>
	</div>

	<div class="version">
		2016-10-05 09:28:50 Apache/2.2.22 (Debian) <a href="http://www.yiiframework.com/">Yii Framework</a>/1.1.17	</div>
</div>

<script type="text/javascript">
/*<![CDATA[*/
var traceReg = new RegExp("(^|\\s)trace-file(\\s|$)");
var collapsedReg = new RegExp("(^|\\s)collapsed(\\s|$)");

var e = document.getElementsByTagName("div");
for(var j=0,len=e.length;j<len;j++){
	if(traceReg.test(e[j].className)){
		e[j].onclick = function(){
			var trace = this.parentNode.parentNode;
			if(collapsedReg.test(trace.className))
				trace.className = trace.className.replace("collapsed", "expanded");
			else
				trace.className = trace.className.replace("expanded", "collapsed");
		}
	}
}
/*]]>*/
</script>



</body></html>
PHP notice.html (17,707 bytes)   
Bug heat4
Complete LimeSurvey version number (& build)161004
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-10-05 09:36

developer   ~41143

Without debug : clean : we have the group and no question.

c_schmitz

c_schmitz

2016-10-05 09:43

administrator   ~41146

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=20826

c_schmitz

c_schmitz

2016-10-05 17:53

administrator   ~41152

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=20846

c_schmitz

c_schmitz

2016-10-07 16:39

administrator   ~41196

Version 2.54 released

DenisChenu

DenisChenu

2016-10-07 18:50

developer   ~41203

You unmerge it ;)

Still the issue

With relevance set to 0==1 : we see the question (in EM we set to true when preview question) => maybe it's a good idea too for hidden ?

In fact : we have the same for previewgroup if all group his hidden too

When preview survey in group by group : move next come back to first page :)

Still : it's not a major issue

c_schmitz

c_schmitz

2016-10-13 15:31

administrator   ~41305

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=20998

c_schmitz

c_schmitz

2016-10-14 10:24

administrator   ~41330

Version 2.54.3 Build 161014 released

Related Changesets

LimeSurvey: master 3bad8cad

2016-10-05 11:43

c_schmitz


Details Diff
Fixed issue 11746: Notice when previewing a hidden question and debug mode activated Affected Issues
11746
mod - application/helpers/SurveyRuntimeHelper.php Diff File

LimeSurvey: master 63993039

2016-10-05 19:52

c_schmitz


Details Diff
Fixed issue 11746: Notice when previewing a hidden question and debug mode activated (reverted from commit 3bad8cad4740bf540a57ac8e35970bbb51ceb152) Affected Issues
11746
mod - application/helpers/SurveyRuntimeHelper.php Diff File

LimeSurvey: master 31eba5b5

2016-10-13 17:30

c_schmitz


Details Diff
Fixed issue 11746: Notice when previewing a hidden question and debug mode activated Affected Issues
11746
mod - application/helpers/SurveyRuntimeHelper.php Diff File

Issue History

Date Modified Username Field Change
2016-10-05 09:34 DenisChenu New Issue
2016-10-05 09:34 DenisChenu File Added: PHP notice.html
2016-10-05 09:36 DenisChenu Note Added: 41143
2016-10-05 09:43 c_schmitz Changeset attached => LimeSurvey master 3bad8cad
2016-10-05 09:43 c_schmitz Note Added: 41146
2016-10-05 09:43 c_schmitz Assigned To => c_schmitz
2016-10-05 09:43 c_schmitz Resolution open => fixed
2016-10-05 09:44 c_schmitz Status new => resolved
2016-10-05 09:44 c_schmitz Fixed in Version => 2.53
2016-10-05 17:53 c_schmitz Changeset attached => LimeSurvey master 63993039
2016-10-05 17:53 c_schmitz Note Added: 41152
2016-10-07 16:39 c_schmitz Note Added: 41196
2016-10-07 16:39 c_schmitz Status resolved => closed
2016-10-07 18:50 DenisChenu Status closed => new
2016-10-07 18:50 DenisChenu Resolution fixed => reopened
2016-10-07 18:50 DenisChenu Note Added: 41203
2016-10-07 18:50 DenisChenu File Added: limesurvey_survey_hiddenPreview.lss
2016-10-13 15:31 c_schmitz Changeset attached => LimeSurvey master 31eba5b5
2016-10-13 15:31 c_schmitz Note Added: 41305
2016-10-14 10:23 c_schmitz Status new => resolved
2016-10-14 10:23 c_schmitz Resolution reopened => fixed
2016-10-14 10:23 c_schmitz Fixed in Version 2.53 => 2.54
2016-10-14 10:24 c_schmitz Note Added: 41330
2016-10-14 10:24 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing