View Issue Details

Jump to NotesJump to History
This issue affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
11623Bug reportsSurvey takingpublic2016-09-05 20:292016-09-20 10:48
ReporterMazi Assigned Toollehar  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.51.x 
Target Version2.51.xFixed in Version2.51.x 
Summary11623: Adjustments for {CHECKJAVASCRIPT} placeholder break all custom templates
Description

It looks like commit https://github.com/LimeSurvey/LimeSurvey/commit/b1c10d5d9f5f4f0e482c071bce787aee3864bdad has broken any custom template using {CHECKJAVASCRIPT} placeholder. Please revert or create a backward compatible solution.

Steps To Reproduce

Take any custom template making use of the {CHECKJAVASCRIPT} placeholder. You will always (!) see this error message even though JS IS enabled: "Caution: JavaScript execution is disabled in your browser. You may not be able to answer all questions in this survey. Please, verify your browser parameters."

Test link: http://ls25.mysurveyhosting.com/index.php/survey/index/sid/456786/newtest/Y/lang/en

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)160901
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionMySQL 5
Server OS (if known)Linux
Webserver software & version (if known)Apache 2
PHP Version5.5

Users monitoring this issue

There are no users monitoring this issue.

Activities

ollehar

ollehar

2016-09-05 20:47

administrator   ~40685

It's only visible on the welcome page for me.
Mazi

Mazi

2016-09-05 21:26

updater   ~40686

Yep, for everyone who starts a survey. This is pretty confusing.
ollehar

ollehar

2016-09-05 23:39

administrator   ~40688

Hm, OK, we could remove < noscript > from the template and put it in the replacement function instead. That would solve your problem, right?
Mazi

Mazi

2016-09-06 08:25

updater   ~40689

Hmm, depends on the details but as long as existing CSS wil still work and not require any modifications and the pstpl files stay the same, this should work.
c_schmitz

c_schmitz

2016-09-20 10:48

administrator   ~40839

Version 2.52 Build 160920 released

Issue History

Date Modified Username Field Change
2016-09-05 20:29 Mazi New Issue
2016-09-05 20:29 Mazi Status new => assigned
2016-09-05 20:29 Mazi Assigned To => ollehar
2016-09-05 20:47 ollehar Note Added: 40685
2016-09-05 21:26 Mazi Note Added: 40686
2016-09-05 23:39 ollehar Note Added: 40688
2016-09-06 08:25 Mazi Note Added: 40689
2016-09-08 16:43 ollehar Status assigned => resolved
2016-09-08 16:43 ollehar Fixed in Version => 2.51.x
2016-09-08 16:43 ollehar Resolution open => fixed
2016-09-20 10:48 c_schmitz Note Added: 40839
2016-09-20 10:48 c_schmitz Status resolved => closed