View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 10
IDProjectCategoryView StatusDate SubmittedLast Update
11173Bug reportsOtherpublic2016-05-12 19:562016-05-24 09:49
Reporterpmonstad Assigned Toc_schmitz  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary11173: inconsistent use of on/off yes/no
Description

I dislike the mix of on/off switches and the old style (drop down menus) yes/no. See screenshot where this mix is visible. Either should there be on/off switches 100 % in gui or 100 % drop down menus, not a mix. I'd prefer the on/off.

TagsNo tags attached.
Attached Files
Skjermbilde 2016-05-12 kl. 19.53.14.png (96,978 bytes)   
Skjermbilde 2016-05-12 kl. 19.53.14.png (96,978 bytes)   
Bug heat10
Complete LimeSurvey version number (& build)160512
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionirrelevant
Server OS (if known)irrelevant
Webserver software & version (if known)irrelevant
PHP Versionirrelevant

Users monitoring this issue

DenisChenu

Activities

LouisGac

LouisGac

2016-05-13 10:20

developer   ~38532

or either we could go step by step to on/off switches 100 % in gui
;-)
pmonstad

pmonstad

2016-05-13 10:43

updater   ~38538

Thanks, step by step transform to on/off is a good suggestion
DenisChenu

DenisChenu

2016-05-13 10:50

developer   ~38539

Last edited: 2016-05-13 10:52

Just for information : switch seems really buggy for accessibility.
Personnaly i prefer a clean form : radio/checkbox or any other system.

Sorry : found the checkbow : then optimiozation can be done.
pmonstad

pmonstad

2016-05-13 11:44

updater   ~38544

Checkbox is also a better alternative than the drop down menu. A checkbox takes less space than on/off switches and is probably the best choice.
c_schmitz

c_schmitz

2016-05-13 11:51

administrator   ~38545

I prefer the switches. They can be styled in different ways.
For more information see http://www.bootstrap-switch.org/
DenisChenu

DenisChenu

2016-05-13 12:02

developer   ~38547

It have a checkbox. Just need some aria-hidden true / aria-hidden false . It's OK
c_schmitz

c_schmitz

2016-05-13 15:46

administrator   ~38555

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19053
pmonstad

pmonstad

2016-05-17 18:38

updater   ~38654

There are still some left in Notification... and Tokens tabs in survey settings.
c_schmitz

c_schmitz

2016-05-17 19:30

administrator   ~38656

Yes, that's why the last commit says 'Partial fix' and this issue is not set as resolved.
c_schmitz

c_schmitz

2016-05-19 17:32

administrator   ~38692

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19098
DenisChenu

DenisChenu

2016-05-19 17:59

developer   ~38694

Really : using a global system (like plugin) do it more quickly.

Outdated now (must be removes) but : https://manual.limesurvey.org/Project_ideas_for_GSoC_2015#Make_use_of_the_SettingsWidget_for_core_functions
c_schmitz

c_schmitz

2016-05-24 09:49

administrator   ~38748

Version 2.50+ Build 160523 released

Related Changesets

LimeSurvey: master 2bf179b0

2016-05-13 15:46

c_schmitz


Details Diff		 Fixed issue 11173: Inconsistent use of on/off yes/no
Dev Partial fix
Dev Also replaced 3 option selects with button groups		 Affected Issues
11173
mod - application/controllers/admin/database.php Diff File
mod - application/controllers/admin/surveyadmin.php Diff File
mod - application/views/admin/survey/listSurveys_view.php Diff File
mod - application/views/admin/survey/subview/accordion/_generaloptions_panel.php Diff File
mod - application/views/admin/survey/subview/accordion/_notification_panel.php Diff File
mod - application/views/admin/survey/subview/accordion/_presentation_panel.php Diff File
mod - application/views/admin/survey/subview/accordion/_publication_panel.php Diff File

LimeSurvey: master 6e63e86f

2016-05-19 17:32

c_schmitz


Details Diff		 Fixed issue 11173: Inconsistent use of on/off yes/no Affected Issues
11173
mod - application/controllers/admin/database.php Diff File
mod - application/controllers/admin/surveyadmin.php Diff File
mod - application/models/Survey.php Diff File
mod - application/views/admin/survey/subview/accordion/_notification_panel.php Diff File
mod - application/views/admin/survey/subview/accordion/_tokens_panel.php Diff File

Issue History

Date Modified Username Field Change
2016-05-12 19:56 pmonstad New Issue
2016-05-12 19:56 pmonstad File Added: Skjermbilde 2016-05-12 kl. 19.53.14.png
2016-05-13 08:31 DenisChenu Issue Monitored: DenisChenu
2016-05-13 10:20 LouisGac Note Added: 38532
2016-05-13 10:43 pmonstad Note Added: 38538
2016-05-13 10:50 DenisChenu Note Added: 38539
2016-05-13 10:51 DenisChenu Note Edited: 38539
2016-05-13 10:52 DenisChenu Note Edited: 38539
2016-05-13 11:44 pmonstad Note Added: 38544
2016-05-13 11:51 c_schmitz Note Added: 38545
2016-05-13 11:52 c_schmitz Assigned To => c_schmitz
2016-05-13 11:52 c_schmitz Status new => assigned
2016-05-13 12:02 DenisChenu Note Added: 38547
2016-05-13 15:46 c_schmitz Changeset attached => LimeSurvey master 2bf179b0
2016-05-13 15:46 c_schmitz Note Added: 38555
2016-05-13 15:46 c_schmitz Resolution open => fixed
2016-05-17 18:38 pmonstad Note Added: 38654
2016-05-17 19:30 c_schmitz Note Added: 38656
2016-05-19 17:32 c_schmitz Changeset attached => LimeSurvey master 6e63e86f
2016-05-19 17:32 c_schmitz Note Added: 38692
2016-05-19 17:57 c_schmitz Status assigned => resolved
2016-05-19 17:57 c_schmitz Fixed in Version => 2.5
2016-05-19 17:59 DenisChenu Note Added: 38694
2016-05-24 09:49 c_schmitz Note Added: 38748
2016-05-24 09:49 c_schmitz Status resolved => closed
2021-08-03 01:04 guest Bug heat 8 => 10