View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
11143Bug reportsOtherpublic2016-05-12 10:38
Reporterttenbergen Assigned Toc_schmitz  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary11143: password save notification
Description

I just deleted several optional languages from the demo install to see if that would set it back to English. It did not. But: as I clicked "speichern" the password save on my Firefox activated and wanted to save a user "fuckisreal@". I had not entered that.
Tried to reproduce just now and could not.

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)123456789
I will donate to the project if issue is resolvedNo
BrowserFirefox
Database type & version123
Server OS (if known)123
Webserver software & version (if known)123
PHP Version123

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-05-10 15:32

developer   ~38278

Yes, i have it some times : it can happen if you have a SMTP password OR a IMPA password.

BUT : form seems clean .....

DenisChenu

DenisChenu

2016-05-10 19:07

developer   ~38292

Not in 2.50 no autocomplete="off" is set

c_schmitz

c_schmitz

2016-05-11 10:25

administrator   ~38299

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=18949

DenisChenu

DenisChenu

2016-05-11 10:54

developer   ~38308

Last edited: 2016-05-11 10:55

Not really resolved ... new browser don't activate "autocomplete".

See http://stackoverflow.com/a/21348793/2239406 and http://caniuse.com/#feat=input-autocomplete-onoff (end of page : partial only on all browser)

I try adding 2 false input

Maybe leave it with "not fixable" => browser behaviour
See another source : https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#The_autocomplete_attribute_and_login_fields

c_schmitz

c_schmitz

2016-05-11 11:12

administrator   ~38310

http://caniuse.com/#search=autocomplete

Good enough for me.

DenisChenu

DenisChenu

2016-05-11 12:09

developer   ~38317

Maybe enough , but don't wrok:

<quote>
This support information does not include support for other autocomplete values.

As described in detail below, many modern browsers ignore the off value on certain fields in certain cases intentionally in order to give the user more control over autofilling fields. One example is the use of password managers.

1 Partial support refers to ignoring the off value for password fields. see related blog post

2 Partial support in Chrome refers to the browser intentionally ignoring autocomplete="off" when the user uses the browser's autofill functionality. see bug

3 Partial support in Firefox refers to ignoring autocomplete="off" for login forms. see bug

4 Browser does not display previously submitted values as options with on value.

5 Safari ignores the off value for username, email and password fields
</quote>

c_schmitz

c_schmitz

2016-05-11 12:43

administrator   ~38323

Yes, I can read.

DenisChenu

DenisChenu

2016-05-11 14:11

developer   ~38332

Yes, but then "Not fix" or something other, but not "fixed" no ?

c_schmitz

c_schmitz

2016-05-12 10:38

administrator   ~38428

Version 2.50 Build 160512 released

Related Changesets

LimeSurvey: master 13d2e935

2016-05-11 08:17:34

c_schmitz

Details Diff
Fixed issue 11143: Password save notification when saving global settings
Dev Better handling of default language changes
Dev Added /application/extensions not to be scanned by Scrutinizer
Affected Issues
11143
mod - .scrutinizer.yml Diff File
mod - application/helpers/common_helper.php Diff File
mod - application/views/admin/globalSettings_view.php Diff File
mod - application/views/admin/global_settings/_email.php Diff File
mod - scripts/admin/globalsettings.js Diff File

Issue History

Date Modified Username Field Change
2016-05-10 00:08 ttenbergen New Issue
2016-05-10 15:32 DenisChenu Note Added: 38278
2016-05-10 19:07 DenisChenu Assigned To => DenisChenu
2016-05-10 19:07 DenisChenu Status new => assigned
2016-05-10 19:07 DenisChenu Note Added: 38292
2016-05-11 10:25 c_schmitz Changeset attached => LimeSurvey master 13d2e935
2016-05-11 10:25 c_schmitz Note Added: 38299
2016-05-11 10:25 c_schmitz Assigned To DenisChenu => c_schmitz
2016-05-11 10:25 c_schmitz Resolution open => fixed
2016-05-11 10:29 c_schmitz Status assigned => resolved
2016-05-11 10:29 c_schmitz Fixed in Version => 2.5
2016-05-11 10:54 DenisChenu Note Added: 38308
2016-05-11 10:55 DenisChenu Note Edited: 38308
2016-05-11 11:12 c_schmitz Note Added: 38310
2016-05-11 12:09 DenisChenu Note Added: 38317
2016-05-11 12:43 c_schmitz Note Added: 38323
2016-05-11 14:11 DenisChenu Note Added: 38332
2016-05-12 10:38 c_schmitz Note Added: 38428
2016-05-12 10:38 c_schmitz Status resolved => closed