View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
11142Bug reportsTheme editorpublic2016-05-12 13:22
Reporterdavet902 Assigned Toc_schmitz  
PriorityimmediateSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary11142: template editir dies if expected template does not exist (should revert to default)
Description

Issue reported in https://bugs.limesurvey.org/view.php?id=10720 is NOT (or should not have been) closed. Template editor still fires a blank error message page if the expected template (not just the default one, but the last one edited) doesn't exist.

Steps To Reproduce

Create custom template. Exit limesurvey after editing that template (ie - leave it selected in the template editor). On login and template edit, that template is loaded for editing. That's arguably helpful, though not necessary (and removing that saved setting would also fix the problem).

Not, upgrade LS manually (presumably the comfort update won't have this problem) without saving the uploads folder. Just delete everything and reload config.php (and several other things I've modified, hiding upgrade notifications and so on) by ftp.

Now log back in again, and open the template editor. As the expected (custom) template is gone, the error message will fire without reverting to the default.

Now that I've noticed the custom templates are in uploads, I'll just save a copy of that along with the modded files under applications. But I imagine I'm not the only one to hit this snag.

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)limesurvey250plus-build1605
I will donate to the project if issue is resolvedNo
Browser
Database type & versionmysql
Server OS (if known)linux
Webserver software & version (if known)apache
PHP Version5.5

Relationships

related to 11161 closedc_schmitz Error HTTP/400 when clicking "Import a question" button 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-05-10 15:35

developer   ~38279

regression : it work in 2.06 :

But maybe we need optimisation on Template::templateNameFilter (cache or minimum : static if we use it a lot)

DenisChenu

DenisChenu

2016-05-12 11:46

developer   ~38460

Can not reproduce since Louis fix https://bugs.limesurvey.org/view.php?id=11135

https://github.com/LimeSurvey/LimeSurvey/commit/057e7e54efd6fd15357852a25fd8d90d020b20ad

Canb you test with last version GIT master version or with the fix ?

davet902

davet902

2016-05-12 13:01

reporter   ~38472

The git version fires the error whether the template is there or not.

However, I just updated to limesurvey250plus-build160512 and that seems to fix the problem. Deleted (user) template doesn't fail, just reverts to default.

So, I think it's fixed, though NOT with this mod (the git file lined above).

c_schmitz

c_schmitz

2016-05-12 13:01

administrator   ~38473

davet902: Please check out the patch from 11161 and let us know if that fixes your issue.

davet902

davet902

2016-05-12 13:04

reporter   ~38474

I think we're crossing emails. This can be closed as of the latest version (160512), as far as I can tell.

Issue History

Date Modified Username Field Change
2016-05-09 20:08 davet902 New Issue
2016-05-10 15:35 DenisChenu Note Added: 38279
2016-05-12 11:20 c_schmitz Product Version 2.06+ => 2.5
2016-05-12 11:30 c_schmitz Priority none => immediate
2016-05-12 11:40 DenisChenu Assigned To => DenisChenu
2016-05-12 11:40 DenisChenu Status new => assigned
2016-05-12 11:43 DenisChenu Assigned To DenisChenu =>
2016-05-12 11:46 DenisChenu Note Added: 38460
2016-05-12 11:46 DenisChenu Status assigned => feedback
2016-05-12 13:00 c_schmitz Relationship added related to 11161
2016-05-12 13:01 davet902 Note Added: 38472
2016-05-12 13:01 davet902 Status feedback => new
2016-05-12 13:01 c_schmitz Note Added: 38473
2016-05-12 13:01 c_schmitz Assigned To => c_schmitz
2016-05-12 13:01 c_schmitz Status new => feedback
2016-05-12 13:04 davet902 Note Added: 38474
2016-05-12 13:04 davet902 Status feedback => assigned
2016-05-12 13:22 c_schmitz Status assigned => closed
2016-05-12 13:22 c_schmitz Resolution open => fixed
2016-05-12 13:22 c_schmitz Fixed in Version => 2.5