View Issue Details

Jump to NotesJump to History
This issue affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
11138Bug reportsSurvey editingpublic2016-05-09 11:222016-05-12 11:06
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionno change required 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary11138: Uneeded Status information on quota
Description

See screenshot

Steps To Reproduce

Add a quota

Additional Information

See https://bugs.limesurvey.org/view.php?id=10177 and https://github.com/LimeSurvey/LimeSurvey/commit/7b9f2c3debe043b16c0b716e270d11aba7b6f436#commitcomment-17396913

https://github.com/LimeSurvey/LimeSurvey/blob/master/application/views/admin/quotas/viewquotasrow_view.php#L8

TagsNo tags attached.
Attached Files
Capture du 2016-05-09 10-44-38.png (21,858 bytes)   
Capture du 2016-05-09 10-44-38.png (21,858 bytes)   
Capture du 2016-05-09 16-48-48.png (22,251 bytes)   
Capture du 2016-05-09 16-48-48.png (22,251 bytes)   
limesurvey_survey_quota_Not-active.lss (17,780 bytes)
Bug heat4
Complete LimeSurvey version number (& build)180509
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant
Git branch / Pull Request URL

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2016-05-09 16:41

administrator   ~38267

I cannot see any relevance regarding https://bugs.limesurvey.org/view.php?id=10177 for this.

I can see the usefulness of such a setting for a single quota though - and the existence of the database field is bonus :-).

IMHO it should be fine to add the feature - let ask the others in the dev meeting tomorrwo.
DenisChenu

DenisChenu

2016-05-09 16:51

developer   ~38269

Last edited: 2016-05-09 16:52

For relevance : Uploaded a screenshoit after hacking DB (manually set quota.active to 0) Screenshot done with actual MASTER GIT version (same with older version)
Uploaded the lss file : unsure Not active is set to 0 but think yes.

The relevance is :

  • We have a setting active 0/1 in the DB
  • We show this settings

Then we must

  • Use it in survey
  • Allow updating it.
DenisChenu

DenisChenu

2016-05-09 16:54

developer   ~38270

PS : for interset of feature : i don't care : i don't really use Quota . But
t6nnp6nn + Marksom seems intersted.
Feature request is not mine (and i didn't have a client for this).
DenisChenu

DenisChenu

2016-05-12 11:05

developer   ~38446

After discussion : https://github.com/LimeSurvey/LimeSurvey/commit/7b9f2c3debe043b16c0b716e270d11aba7b6f436 is OK, but commit message is bad.

Linked feature is https://bugs.limesurvey.org/view.php?id=10051 (very light feature)
DenisChenu

DenisChenu

2016-05-12 11:06

developer   ~38447

Fixed by https://bugs.limesurvey.org/view.php?id=10051
Active/Not active is used after fixing

Issue History

Date Modified Username Field Change
2016-05-09 11:22 DenisChenu New Issue
2016-05-09 11:22 DenisChenu File Added: Capture du 2016-05-09 10-44-38.png
2016-05-09 16:41 c_schmitz Note Added: 38267
2016-05-09 16:41 c_schmitz Assigned To => c_schmitz
2016-05-09 16:41 c_schmitz Status new => assigned
2016-05-09 16:49 DenisChenu File Added: Capture du 2016-05-09 16-48-48.png
2016-05-09 16:49 DenisChenu File Added: limesurvey_survey_quota_Not-active.lss
2016-05-09 16:51 DenisChenu Note Added: 38269
2016-05-09 16:52 DenisChenu Note Edited: 38269
2016-05-09 16:54 DenisChenu Note Added: 38270
2016-05-12 11:04 DenisChenu Assigned To c_schmitz => DenisChenu
2016-05-12 11:05 DenisChenu Note Added: 38446
2016-05-12 11:06 DenisChenu Note Added: 38447
2016-05-12 11:06 DenisChenu Status assigned => closed
2016-05-12 11:06 DenisChenu Resolution open => no change required
2016-05-12 11:06 DenisChenu Fixed in Version => 2.5
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing