View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
11089Bug reportsSurvey editingpublic2016-04-29 21:492016-05-06 10:11
Reporterollehar Assigned Toollehar  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Target Version2.50.xFixed in Version2.50.x 
Summary11089: When side-menu is closed, the side-body shifts from right to left at page load
Description

When side-menu is closed, the side-body shifts from left to right at page load.

This is because side-menu is adjusted in JS, sidemenu.js.

This problem appears in all jumbo screens (activate survey etc).

Solutions:

  1. Set side-body width in PHP. Requires that side-body is rendered only in one place, but is now rendered in many places. Tried to factor out but gave up due to _renderWrappedTemplate, which accepts an array of views (which view has the side-body class, and when??).

  2. Render in pure JS instead of jQuery document ready. But more than width is set, so we might need/want jQuery.

Suggestions welcome!

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)latest
I will donate to the project if issue is resolvedNo
Browser-
Database type & version-
Server OS (if known)-
Webserver software & version (if known)-
PHP Version-

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-04-30 16:16

developer   ~38054

Last edited: 2016-04-30 19:55

js/no-js solution ?

Used in https://html5boilerplate.com/ or https://github.com/Modernizr/Modernizr/blob/master/src/setClasses.js#L20

In fact : i don't understand this "bug" ;)
ollehar

ollehar

2016-05-02 15:25

administrator   ~38108

No JS is needed, because JS is what causes the bug.
ollehar

ollehar

2016-05-03 10:44

administrator   ~38134

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=18864
c_schmitz

c_schmitz

2016-05-06 10:11

administrator   ~38234

Version 2.50+ Build 160506 released

Related Changesets

LimeSurvey: master e89c54bc

2016-05-03 10:43

ollehar


Details Diff		 Fixed issue 11089: When side-menu is closed, the side-body shifts from right to left at page load Affected Issues
11089
mod - application/controllers/admin/assessments.php Diff File
mod - application/controllers/admin/surveypermission.php Diff File
mod - application/controllers/admin/tokens.php Diff File
mod - application/helpers/frontend_helper.php Diff File
mod - application/views/admin/conditions/conditionshead_view.php Diff File
mod - application/views/admin/dataentry/caption_view.php Diff File
mod - application/views/admin/dataentry/dataentry_header_view.php Diff File
mod - application/views/admin/dataentry/import.php Diff File
mod - application/views/admin/dataentry/iteratesurvey.php Diff File
mod - application/views/admin/dataentry/vvimport.php Diff File
mod - application/views/admin/emailtemplates/emailtemplates_view.php Diff File
mod - application/views/admin/export/exportresults_view.php Diff File
mod - application/views/admin/export/spss_view.php Diff File
mod - application/views/admin/export/statistics_user_view.php Diff File
mod - application/views/admin/export/statistics_view.php Diff File
mod - application/views/admin/export/vv_view.php Diff File
mod - application/views/admin/expressions/test/survey_logic_file.php Diff File
mod - application/views/admin/quotas/editquota_view.php Diff File
mod - application/views/admin/quotas/newanswer_view.php Diff File
mod - application/views/admin/quotas/newanswertwo_view.php Diff File
mod - application/views/admin/quotas/newquota_view.php Diff File
mod - application/views/admin/quotas/viewquotas_view.php Diff File
mod - application/views/admin/responses/browseidheader_view.php Diff File
mod - application/views/admin/responses/browseindex_view.php Diff File
mod - application/views/admin/responses/browsetimeheader_view.php Diff File
mod - application/views/admin/responses/listResponses_view.php Diff File
mod - application/views/admin/saved/savedlist_view.php Diff File
mod - application/views/admin/super/sidebody.php Diff File
mod - application/views/admin/super/sidemenu.php Diff File
mod - application/views/admin/survey/Question/answerOptions_view.php Diff File
mod - application/views/admin/survey/Question/editQuestion_view.php Diff File
mod - application/views/admin/survey/Question/editdefaultvalues_view.php Diff File
mod - application/views/admin/survey/Question/importQuestion_view.php Diff File
mod - application/views/admin/survey/Question/import_view.php Diff File
mod - application/views/admin/survey/Question/listquestions.php Diff File
mod - application/views/admin/survey/Question/question_view.php Diff File
mod - application/views/admin/survey/QuestionGroups/addGroup_view.php Diff File
mod - application/views/admin/survey/QuestionGroups/editGroup_view.php Diff File
mod - application/views/admin/survey/QuestionGroups/group_view.php Diff File
mod - application/views/admin/survey/QuestionGroups/importGroup_view.php Diff File
mod - application/views/admin/survey/QuestionGroups/import_view.php Diff File
mod - application/views/admin/survey/QuestionGroups/listquestiongroups.php Diff File
mod - application/views/admin/survey/_activation_feedback.php Diff File
mod - application/views/admin/survey/activateSurvey_view.php Diff File
mod - application/views/admin/survey/deactivateSurvey_view.php Diff File
mod - application/views/admin/survey/deleteSurvey_view.php Diff File
mod - application/views/admin/survey/editLocalSettings_main_view.php Diff File
mod - application/views/admin/survey/editSurvey_view.php Diff File
mod - application/views/admin/survey/importSurveyResources_view.php Diff File
mod - application/views/admin/survey/organizeGroupsAndQuestions_view.php Diff File
mod - application/views/admin/survey/queXMLSurvey_view.php Diff File
mod - application/views/admin/token/addtokenpost.php Diff File
mod - application/views/admin/token/bounce.php Diff File
mod - application/views/admin/token/browse.php Diff File
mod - application/views/admin/token/csvpost.php Diff File
mod - application/views/admin/token/csvupload.php Diff File
mod - application/views/admin/token/dummytokenform.php Diff File
mod - application/views/admin/token/exportdialog.php Diff File
mod - application/views/admin/token/import.php Diff File
mod - application/views/admin/token/invite.php Diff File
mod - application/views/admin/token/ldapform.php Diff File
mod - application/views/admin/token/ldappost.php Diff File
mod - application/views/admin/token/managetokenattributes.php Diff File
mod - application/views/admin/token/remind.php Diff File
mod - application/views/admin/token/tokenform.php Diff File
mod - application/views/admin/token/tokensummary.php Diff File
mod - application/views/admin/token/tokenwarning.php Diff File
mod - application/views/admin/translate/translateheader_view.php Diff File
mod - styles/Sea_Green/css/lime-admin-common.css Diff File
mod - styles/Sea_Green/scripts/sidemenu.js Diff File

Issue History

Date Modified Username Field Change
2016-04-29 21:49 ollehar New Issue
2016-04-30 16:16 DenisChenu Note Added: 38054
2016-04-30 19:55 DenisChenu Note Edited: 38054
2016-05-02 15:24 ollehar Sticky Issue No => Yes
2016-05-02 15:25 ollehar Assigned To => ollehar
2016-05-02 15:25 ollehar Status new => assigned
2016-05-02 15:25 ollehar Note Added: 38108
2016-05-02 15:26 ollehar Summary When side-menu is closed, the side-body shifts from left to right at page load => When side-menu is closed, the side-body shifts from right to left at page load
2016-05-03 10:44 ollehar Changeset attached => LimeSurvey master e89c54bc
2016-05-03 10:44 ollehar Note Added: 38134
2016-05-03 10:44 ollehar Resolution open => fixed
2016-05-03 21:45 ollehar Status assigned => resolved
2016-05-03 21:45 ollehar Fixed in Version => 2.5
2016-05-04 10:28 c_schmitz Sticky Issue Yes => No
2016-05-06 10:11 c_schmitz Note Added: 38234
2016-05-06 10:11 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing