View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
10954Feature requestsTheme editorpublic2016-04-15 09:132016-06-06 15:41
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynoneSeverityfeature 
Status closedResolutionfixed 
Summary10954: Remove Glyphicon usage and use only font-awesome
Description

We load font-awesome in public template, and bootstrap have Glyohicon (font-awesome before).

glyphicon free don't have a lot of icon
font-awesome have a lot lot of icon , and ALL icons set are really free

The error string have glyphicon glyphicon-info-sign. Think it best to use font-awesome

Additional Information

If really needed .. use glyphyicon, but then don't add font-awesome ....

TagsNo tags attached.
Bug heat4
Story point estimate
Users affected %

Users monitoring this issue

There are no users monitoring this issue.

Activities

LouisGac

LouisGac

2016-04-15 10:45

developer   ~37428

I totally agree with this one.
Something I'd like to do since a long time.
Long story short:
Bootstrap 3 provides glyphicons, so we started with it. But the free glyphicons are limited, so we finally moved to font-awesome (which is much more into the "open source" mentality)
DenisChenu

DenisChenu

2016-04-15 11:48

developer   ~37437

OK, can fix it : always include font-awesome + fix some HTML produced.

font-awesome in https://github.com/LimeSurvey/LimeSurvey/blob/master/application/config/third_party.php seems the best.
DenisChenu

DenisChenu

2016-04-18 19:05

developer   ~37506

https://github.com/LimeSurvey/LimeSurvey/pull/478
DenisChenu

DenisChenu

2016-04-24 18:15

developer   ~37740

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=18703

Related Changesets

LimeSurvey: master 34215e0d

2016-04-18 17:03:06

DenisChenu

Details Diff 		New feature 10954 : always add font-awesome in public and admin
Dev: move top fa for public part
Dev: admoin part have a lot of glyphicon		 Affected Issues
10954
mod - application/controllers/UploaderController.php Diff File
mod - application/controllers/survey/index.php Diff File
mod - application/helpers/common_helper.php Diff File
mod - application/views/admin/super/header.php Diff File
mod - application/views/layouts/installer.php Diff File
mod - application/views/survey/questions/arrays/dualscale/answer.php Diff File
mod - application/views/survey/questions/date/selector/answer.php Diff File
mod - application/views/survey/system/questionhelp/mandatory_tip.php Diff File
mod - application/views/survey/system/questionhelp/questionhelp.php Diff File
mod - application/views/survey/system/questionhelp/tips.php Diff File
mod - application/views/surveys/publicSurveyList.php Diff File
rm - installer/css/font-awesome.css Diff File
rm - installer/fonts/DejaVuSans - CREDITS Diff File
rm - installer/fonts/DejaVuSans.ttf Diff File
rm - installer/fonts/FontAwesome.otf Diff File
rm - installer/fonts/FreeSans - CREDITS Diff File
rm - installer/fonts/FreeSans.ttf Diff File
rm - installer/fonts/TlwgTypist - Thai.ttf.txt Diff File
rm - installer/fonts/UnBatang - Korean.ttf.txt Diff File
rm - installer/fonts/fireflysung - Chinese.ttf.txt Diff File
rm - installer/fonts/fontawesome-webfont.eot Diff File
rm - installer/fonts/fontawesome-webfont.svg Diff File
rm - installer/fonts/fontawesome-webfont.ttf Diff File
rm - installer/fonts/fontawesome-webfont.woff Diff File
rm - installer/fonts/fontawesome-webfont.woff2 Diff File
rm - installer/fonts/glyphicons-halflings-regular.svg Diff File
rm - installer/fonts/glyphicons-halflings-regular.ttf Diff File
rm - installer/fonts/glyphicons-halflings-regular.woff Diff File
rm - installer/fonts/glyphicons-halflings-regular.woff2 Diff File
rm - installer/fonts/migmix-1p-regular - Japanese.ttf.txt Diff File
mod - templates/default/config.xml Diff File
rm - templates/default/fonts/FontAwesome.otf Diff File
rm - templates/default/fonts/fontawesome-webfont.eot Diff File
rm - templates/default/fonts/fontawesome-webfont.svg Diff File
rm - templates/default/fonts/fontawesome-webfont.ttf Diff File
rm - templates/default/fonts/fontawesome-webfont.woff Diff File
mod - templates/news_paper/config.xml Diff File
rm - templates/news_paper/css/font-awesome.css Diff File
rm - templates/news_paper/fonts/fontawesome-webfont.eot Diff File
rm - templates/news_paper/fonts/fontawesome-webfont.ttf Diff File
rm - templates/news_paper/fonts/fontawesome-webfont.woff Diff File
rm - templates/news_paper/fonts/fontawesome-webfont.woff2 Diff File
mod - templates/ubuntu_orange/config.xml Diff File
rm - templates/ubuntu_orange/fonts/FontAwesome.otf Diff File
rm - templates/ubuntu_orange/fonts/fontawesome-webfont.eot Diff File
rm - templates/ubuntu_orange/fonts/fontawesome-webfont.svg Diff File
rm - templates/ubuntu_orange/fonts/fontawesome-webfont.woff Diff File
rm - templates/ubuntu_orange/fonts/fontawesome-webfont.woff2 Diff File
rm - third_party/font-awesome/css/font-awesome.css Diff File
rm - third_party/font-awesome/css/font-awesome.min.css Diff File
rm - third_party/font-awesome/fonts/FontAwesome.otf Diff File
rm - third_party/font-awesome/fonts/fontawesome-webfont.eot Diff File
rm - third_party/font-awesome/fonts/fontawesome-webfont.svg Diff File
rm - third_party/font-awesome/fonts/fontawesome-webfont.ttf Diff File
rm - third_party/font-awesome/fonts/fontawesome-webfont.woff Diff File
rm - third_party/font-awesome/less/mixins.less Diff File
rm - third_party/font-awesome/scss/_mixins.scss Diff File
add - third_party/fontawesome/.gitignore Diff File
add - third_party/fontawesome/.npmignore Diff File
add - third_party/fontawesome/HELP-US-OUT.txt Diff File
add - third_party/fontawesome/bower.json Diff File
add - third_party/fontawesome/css/font-awesome.css.map Diff File
add - third_party/fontawesome/css/font-awesome.min.css Diff File
add - third_party/fontawesome/fonts/4.4.0/index.html Diff File
add - third_party/fontawesome/fonts/fontawesome-webfont.eot Diff File
add - third_party/fontawesome/fonts/fontawesome-webfont.woff Diff File
add - third_party/fontawesome/fonts/fontawesome-webfont.woff2 Diff File
add - third_party/fontawesome/less/mixins.less Diff File
add - third_party/fontawesome/less/screen-reader.less Diff File
add - third_party/fontawesome/scss/_mixins.scss Diff File
add - third_party/fontawesome/scss/_screen-reader.scss Diff File

LimeSurvey: master 84e4ac68

2016-04-24 16:15:02

DenisChenu

Details Diff 		Merge pull request #478 from Shnoulle/master_fontawesome

New feature 10954 : always add font-awesome in public and admin		 Affected Issues
10954
mod - application/config/third_party.php Diff File
mod - application/controllers/survey/index.php Diff File
mod - application/helpers/common_helper.php Diff File
mod - application/views/admin/super/header.php Diff File
mod - application/views/layouts/installer.php Diff File
mod - application/views/survey/questions/arrays/dualscale/answer.php Diff File
mod - application/views/survey/questions/date/selector/answer.php Diff File
mod - application/views/survey/system/questionhelp/mandatory_tip.php Diff File
mod - application/views/survey/system/questionhelp/questionhelp.php Diff File
mod - application/views/survey/system/questionhelp/tips.php Diff File
mod - application/views/surveys/publicSurveyList.php Diff File
rm - installer/css/font-awesome.css Diff File
rm - installer/fonts/DejaVuSans - CREDITS Diff File
rm - installer/fonts/DejaVuSans.ttf Diff File
rm - installer/fonts/FontAwesome.otf Diff File
rm - installer/fonts/FreeSans - CREDITS Diff File
rm - installer/fonts/FreeSans.ttf Diff File
rm - installer/fonts/TlwgTypist - Thai.ttf.txt Diff File
rm - installer/fonts/UnBatang - Korean.ttf.txt Diff File
rm - installer/fonts/fireflysung - Chinese.ttf.txt Diff File
rm - installer/fonts/fontawesome-webfont.eot Diff File
rm - installer/fonts/fontawesome-webfont.svg Diff File
rm - installer/fonts/fontawesome-webfont.ttf Diff File
rm - installer/fonts/fontawesome-webfont.woff Diff File
rm - installer/fonts/fontawesome-webfont.woff2 Diff File
rm - installer/fonts/glyphicons-halflings-regular.svg Diff File
rm - installer/fonts/glyphicons-halflings-regular.ttf Diff File
rm - installer/fonts/glyphicons-halflings-regular.woff Diff File
rm - installer/fonts/glyphicons-halflings-regular.woff2 Diff File
rm - installer/fonts/migmix-1p-regular - Japanese.ttf.txt Diff File
mod - templates/default/config.xml Diff File
rm - templates/default/fonts/FontAwesome.otf Diff File
rm - templates/default/fonts/fontawesome-webfont.eot Diff File
rm - templates/default/fonts/fontawesome-webfont.svg Diff File
rm - templates/default/fonts/fontawesome-webfont.ttf Diff File
rm - templates/default/fonts/fontawesome-webfont.woff Diff File
mod - templates/news_paper/config.xml Diff File
rm - templates/news_paper/css/font-awesome.css Diff File
rm - templates/news_paper/fonts/fontawesome-webfont.eot Diff File
rm - templates/news_paper/fonts/fontawesome-webfont.ttf Diff File
rm - templates/news_paper/fonts/fontawesome-webfont.woff Diff File
rm - templates/news_paper/fonts/fontawesome-webfont.woff2 Diff File
mod - templates/ubuntu_orange/config.xml Diff File
rm - templates/ubuntu_orange/fonts/FontAwesome.otf Diff File
rm - templates/ubuntu_orange/fonts/fontawesome-webfont.eot Diff File
rm - templates/ubuntu_orange/fonts/fontawesome-webfont.svg Diff File
rm - templates/ubuntu_orange/fonts/fontawesome-webfont.woff Diff File
rm - templates/ubuntu_orange/fonts/fontawesome-webfont.woff2 Diff File
rm - third_party/font-awesome/css/font-awesome.css Diff File
rm - third_party/font-awesome/css/font-awesome.min.css Diff File
rm - third_party/font-awesome/fonts/FontAwesome.otf Diff File
rm - third_party/font-awesome/fonts/fontawesome-webfont.eot Diff File
rm - third_party/font-awesome/fonts/fontawesome-webfont.svg Diff File
rm - third_party/font-awesome/fonts/fontawesome-webfont.ttf Diff File
rm - third_party/font-awesome/fonts/fontawesome-webfont.woff Diff File
rm - third_party/font-awesome/less/mixins.less Diff File
rm - third_party/font-awesome/scss/_mixins.scss Diff File
add - third_party/fontawesome/.gitignore Diff File
add - third_party/fontawesome/.npmignore Diff File
add - third_party/fontawesome/HELP-US-OUT.txt Diff File
add - third_party/fontawesome/bower.json Diff File
add - third_party/fontawesome/css/font-awesome.css.map Diff File
add - third_party/fontawesome/css/font-awesome.min.css Diff File
add - third_party/fontawesome/fonts/4.4.0/index.html Diff File
add - third_party/fontawesome/fonts/fontawesome-webfont.eot Diff File
add - third_party/fontawesome/fonts/fontawesome-webfont.woff Diff File
add - third_party/fontawesome/fonts/fontawesome-webfont.woff2 Diff File
add - third_party/fontawesome/less/mixins.less Diff File
add - third_party/fontawesome/less/screen-reader.less Diff File
add - third_party/fontawesome/scss/_mixins.scss Diff File
add - third_party/fontawesome/scss/_screen-reader.scss Diff File

Issue History

Date Modified Username Field Change
2016-04-15 09:13 DenisChenu New Issue
2016-04-15 09:13 DenisChenu Status new => assigned
2016-04-15 09:13 DenisChenu Assigned To => LouisGac
2016-04-15 10:45 LouisGac Note Added: 37428
2016-04-15 11:48 DenisChenu Note Added: 37437
2016-04-15 17:47 LouisGac Assigned To LouisGac => DenisChenu
2016-04-18 19:05 DenisChenu Note Added: 37506
2016-04-24 18:15 DenisChenu Changeset attached => LimeSurvey master 34215e0d
2016-04-24 18:15 DenisChenu Changeset attached => LimeSurvey master 84e4ac68
2016-04-24 18:15 DenisChenu Note Added: 37740
2016-04-24 18:15 DenisChenu Resolution open => fixed
2016-04-24 18:26 DenisChenu Status assigned => resolved
2016-04-24 18:26 DenisChenu Fixed in Version => 2.5+
2016-06-06 15:41 c_schmitz Status resolved => closed