10654: Notice messages shown when disabling ComfortUpdate - LimeSurvey bugs and feature requests

This issue affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update
10654	Bug reports	ComfortUpdate	public	2016-03-02 21:32	2016-04-06 11:36

Reporter	adolfocorreia	Assigned To	c_schmitz
Priority	normal	Severity	minor
Status	closed	Resolution	fixed
Product Version	2.50.x
Fixed in Version	2.50.x

Summary	10654: Notice messages shown when disabling ComfortUpdate
Description	When I disable ComfortUpdate (setting 'updatable' => 0 in config.php), I get the following messages on the top of all pages: Notice: Trying to get property of non-object in /var/www/html/pesquisa/application/core/Survey_Common_Action.php on line 512 Notice: Trying to get property of non-object in /var/www/html/pesquisa/application/core/Survey_Common_Action.php on line 391 A simple check on the value of the 'updatable' setting in Survey_Common_Action.php file should be enough to fix this issue. Thanks!
Steps To Reproduce	Set 'updatable' => 0 in config.php and open the home page.
Tags	No tags attached.

Bug heat	2
Complete LimeSurvey version number (& build)	build 160228
I will donate to the project if issue is resolved	No
Browser
Database type & version	SQL Server 2008
Server OS (if known)	Linux CentOS 7.2
Webserver software & version (if known)	Apache 2.4.6
PHP Version	PHP 5.4.16
Git branch / Pull Request URL

User List	There are no users monitoring this issue.

c_schmitz 2016-04-04 16:09 administrator ~36982	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=18295

c_schmitz 2016-04-04 16:17 administrator ~36983	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=18296

c_schmitz 2016-04-06 11:36 administrator ~37031	Version 2.50+ Build 160405 released

LimeSurvey: master c82a3e48 2016-04-04 16:09 c_schmitz Details Diff	Fixed isssue 10654: Notice messages shown when disabling update	Affected Issues 10654
	mod - application/core/Survey_Common_Action.php	Diff File
LimeSurvey: master ca407857 2016-04-04 16:16 c_schmitz Details Diff	Fixed isssue 10654: Notice messages shown when disabling update	Affected Issues 10654
	mod - application/core/Survey_Common_Action.php	Diff File

Date Modified	Username	Field	Change
2016-03-02 21:32	adolfocorreia	New Issue
2016-03-02 21:32	adolfocorreia	Status	new => assigned
2016-03-02 21:32	adolfocorreia	Assigned To	=> c_schmitz
2016-04-04 16:09	c_schmitz	Changeset attached	=> LimeSurvey master c82a3e48
2016-04-04 16:09	c_schmitz	Note Added: 36982
2016-04-04 16:09	c_schmitz	Resolution	open => fixed
2016-04-04 16:09	c_schmitz	Status	assigned => resolved
2016-04-04 16:09	c_schmitz	Fixed in Version	=> 2.5
2016-04-04 16:17	c_schmitz	Changeset attached	=> LimeSurvey master ca407857
2016-04-04 16:17	c_schmitz	Note Added: 36983
2016-04-06 11:36	c_schmitz	Note Added: 37031
2016-04-06 11:36	c_schmitz	Status	resolved => closed