View Issue Details

Jump to NotesJump to History
This issue affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
10489Bug reportsSurvey editingpublic2016-02-16 19:072016-06-03 15:22
Reporterpmonstad Assigned ToLouisGac 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Summary10489: inconsistent use of pop up boxes/warnings
Description

There are a inconsistency in how LS present warnings. The old pop up style and a new bootstrap variant. The last can be seen in screenshot.

I prefer the bootstrap one and suggest we replace the old pop up style? Carsten, I think you are the man to ask about this. If this is the case I can start putting them into the bug tracker. I guess this is not a priority right now, but a more consistent gui should be a goal on a longer time horizon. What do you say?

TagsNo tags attached.
Attached Files
Skjermbilde 2016-02-17 kl. 09.11.16.png (58,663 bytes)   
Skjermbilde 2016-02-17 kl. 09.11.16.png (58,663 bytes)   
bootstr.png (87,774 bytes)   
bootstr.png (87,774 bytes)   
Bug heat4
Complete LimeSurvey version number (& build)160215
I will donate to the project if issue is resolvedNo
Browserirrelevant
Database type & versionirrelevant
Server OS (if known)irrelevant
Webserver software & version (if known)irrelevant
PHP Versionirrelevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2016-02-16 21:55

administrator   ~35267

Screenshot?
LouisGac

LouisGac

2016-02-17 13:23

developer   ~35308

absolutely, I wrote a detail comment about it in the gitHub :
https://github.com/LimeSurvey/LimeSurvey/pull/438

An homogenization of all the alert/modals/dialog/message-box in LimeSurvey is for sure absolutely needed.

Right now, we have :

  1. javascript alerts : they are easy to replace
  2. jquery dialogs : they can be tricky to remove when linked to jQgrid. They should be replaced by Bootstrap modals (see what have been done for subquestions/answers quick add)
  3. Bootstrap alerts : they are used for Yii flash messages, they should be kept.
  4. Bootstrap modals : should be generalized
  5. LimeSurvey message box using bootstrap jumbotron (like in survey activation). Some of them must be kept, some of them must be replaced by modals, some of them must be replaced by alerts.

The case of the js confirmation alert is easy : they should be replaced by bootstrap modal. You can have a look in the home page settings, I used Bootstrap modal with a snippet of javascript. See :
https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/Boxes.php#l140
https://github.com/LimeSurvey/LimeSurvey/blob/master/scripts/admin/homepagesettings.js#l69

But before generalizing this approach, it needs a second cycle of dev :

  1. The modal should be entirely translated ("Ok" and "Cancel"), and the text should be modular (Yes/No, confirm/cancel, continue/.. or whatever )
  2. A view for the modal should be created, rather than using javascript HTML injection.
  3. Because this view should be included in many different views, and because of point 1, a widget would be the perfect approach.

You can have a look about how is working the PannelBoxWidget, which is pretty simple :
https://github.com/LimeSurvey/LimeSurvey/tree/master/application/extensions/PannelBoxWidget
LouisGac

LouisGac

2016-06-03 15:22

developer   ~39204

right now, most of the pop up boxes/warnings have been standardized.
Better to create a specific report with a screenshot for each last ones.

Issue History

Date Modified Username Field Change
2016-02-16 19:07 pmonstad New Issue
2016-02-16 21:55 c_schmitz Note Added: 35267
2016-02-17 09:13 pmonstad File Added: Skjermbilde 2016-02-17 kl. 09.11.16.png
2016-02-17 09:13 pmonstad File Added: bootstr.png
2016-02-17 13:23 LouisGac Note Added: 35308
2016-02-25 17:19 ollehar Assigned To => ollehar
2016-02-25 17:19 ollehar Status new => assigned
2016-03-08 12:38 ollehar Assigned To ollehar =>
2016-03-08 12:38 ollehar Status assigned => new
2016-06-03 15:22 LouisGac Note Added: 39204
2016-06-03 15:22 LouisGac Status new => closed
2016-06-03 15:22 LouisGac Assigned To => LouisGac
2016-06-03 15:22 LouisGac Resolution open => fixed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing