View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
10289Bug reportsResponse browsingpublic2016-03-11 10:04
Reporterollehar Assigned Toollehar  
PriorityhighSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.50.x 
Target Version2.50.xFixed in Version2.50.x 
Summary10289: Sorting responses by completed "Yes/No/All" does not work properly
Description

Sorting responses by completed "Yes/No/All" does not work properly

Steps To Reproduce

Make a survey, make some answers (some complete, some not), go to responses, try to sort by Completed. It only works sometimes.

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)latest
I will donate to the project if issue is resolvedNo
Browser
Database type & version?
Server OS (if known)linux
Webserver software & version (if known)chromium
PHP Version5.6

Users monitoring this issue

There are no users monitoring this issue.

Activities

ollehar

ollehar

2016-02-03 16:16

administrator   ~34545

Also, in 2.5 there's a '0' where there should be a magnifying glass icon.

ollehar

ollehar

2016-02-03 16:37

administrator   ~34548

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=17130

ollehar

ollehar

2016-02-04 10:47

administrator   ~34564

The commit was for another fix (the '0').

LouisGac

LouisGac

2016-02-08 19:37

developer   ~34741

so is it fixed or not ?

ollehar

ollehar

2016-02-09 10:38

administrator   ~34779

It is not fixed.

LouisGac

LouisGac

2016-02-09 11:19

developer   ~34784

maybe first check if it was working in 2.06 ?

DenisChenu

DenisChenu

2016-02-09 11:20

developer   ~34785

Last edited: 2016-02-09 11:21

There are a fix in 2.06 for this.

https://github.com/LimeSurvey/LimeSurvey/commit/75e4de45b4f4f124ac8e105201753a507e06f1be

I don't know if we still use incompleteAnsFilterState in json, but after the fix : i use it in "default" filter for request, ande removing the test in json.

https://github.com/LimeSurvey/LimeSurvey/commit/75e4de45b4f4f124ac8e105201753a507e06f1be#diff-15547196721577f485345c4a68f0c5d0R678

Only use to set the incompleteAnsFilterState

PS: it work in 2.06

ollehar

ollehar

2016-02-09 11:24

administrator   ~34786

Also, things that didn't work in 2.06 should still be fixed in 2.5, IMHO.

DenisChenu

DenisChenu

2016-03-04 08:20

developer   ~35945

Yes, but here : it work on 2.06 : things working on 2.06 must be fixed in 2.5 :)

LouisGac

LouisGac

2016-03-04 09:55

developer   ~35952

ok, if working in 2.06+, it became an high piority

ollehar

ollehar

2016-03-09 15:31

administrator   ~36214

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=17863

c_schmitz

c_schmitz

2016-03-11 09:17

administrator   ~36339

Version 2.50 Build 160310 released

DenisChenu

DenisChenu

2016-03-11 09:39

developer   ~36343

Maybe put another bug or reopen this one.

In 2.06 : if incompleteAnsFilterState is Yes or No : a default filter is added before get the json.

See : https://github.com/LimeSurvey/LimeSurvey/commit/75e4de45b4f4f124ac8e105201753a507e06f1be#diff-15547196721577f485345c4a68f0c5d0R416

LouisGac

LouisGac

2016-03-11 09:45

developer   ~36348

in general : it's better to open another bug.

DenisChenu

DenisChenu

2016-03-11 10:04

developer   ~36353

OK :)

DenisChenu

DenisChenu

2016-03-11 10:04

developer   ~36355

New bug to be reported

Related Changesets

LimeSurvey: master 644b1381

2016-02-03 15:37:36

ollehar

Details Diff
Fixed issue 10289: Replace 0 with actual icon for viewing details Affected Issues
10289
mod - application/controllers/admin/responses.php Diff File

LimeSurvey: master 4fe647d7

2016-03-09 14:20:26

ollehar

Details Diff
Fixed issue 10289: Sorting responses by completed "Yes/No/All" does not work properly Affected Issues
10289
mod - application/controllers/admin/responses.php Diff File

Issue History

Date Modified Username Field Change
2016-02-03 15:44 ollehar New Issue
2016-02-03 16:16 ollehar Note Added: 34545
2016-02-03 16:37 ollehar Changeset attached => LimeSurvey master 644b1381
2016-02-03 16:37 ollehar Note Added: 34548
2016-02-03 16:37 ollehar Assigned To => ollehar
2016-02-03 16:37 ollehar Resolution open => fixed
2016-02-03 16:41 ollehar Assigned To ollehar =>
2016-02-03 18:46 DenisChenu Assigned To => ollehar
2016-02-03 18:46 DenisChenu Status new => assigned
2016-02-04 10:36 LouisGac Status assigned => resolved
2016-02-04 10:47 ollehar Note Added: 34564
2016-02-04 10:47 ollehar Status resolved => new
2016-02-08 16:05 ollehar Status new => confirmed
2016-02-08 19:37 LouisGac Note Added: 34741
2016-02-09 10:38 ollehar Note Added: 34779
2016-02-09 10:38 ollehar Assigned To ollehar =>
2016-02-09 11:19 LouisGac Note Added: 34784
2016-02-09 11:20 DenisChenu Note Added: 34785
2016-02-09 11:21 DenisChenu Note Edited: 34785
2016-02-09 11:24 ollehar Note Added: 34786
2016-02-09 12:09 ollehar Assigned To => ollehar
2016-02-09 12:09 ollehar Status confirmed => assigned
2016-02-09 12:09 ollehar Assigned To ollehar =>
2016-02-09 12:54 DenisChenu Status assigned => new
2016-03-03 19:24 LouisGac Priority normal => low
2016-03-04 08:20 DenisChenu Note Added: 35945
2016-03-04 09:55 LouisGac Note Added: 35952
2016-03-04 09:55 LouisGac Priority low => high
2016-03-09 14:00 ollehar Assigned To => ollehar
2016-03-09 14:00 ollehar Status new => assigned
2016-03-09 15:22 ollehar Status assigned => resolved
2016-03-09 15:22 ollehar Fixed in Version => 2.5
2016-03-09 15:31 ollehar Changeset attached => LimeSurvey master 4fe647d7
2016-03-09 15:31 ollehar Note Added: 36214
2016-03-11 09:17 c_schmitz Note Added: 36339
2016-03-11 09:17 c_schmitz Status resolved => closed
2016-03-11 09:39 DenisChenu Note Added: 36343
2016-03-11 09:39 DenisChenu Status closed => feedback
2016-03-11 09:39 DenisChenu Resolution fixed => reopened
2016-03-11 09:45 LouisGac Note Added: 36348
2016-03-11 09:45 LouisGac Status feedback => resolved
2016-03-11 09:45 LouisGac Resolution reopened => fixed
2016-03-11 10:04 DenisChenu Note Added: 36353
2016-03-11 10:04 DenisChenu Note Added: 36355
2016-03-11 10:04 DenisChenu Status resolved => closed