View Issue Details

Related ChangesetsJump to NotesJump to History
This issue affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
10056Bug reportsSurvey participants (Tokens)public2015-11-23 15:352015-12-15 13:15
Reporterfvanderstarre Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.06+ 
Fixed in Version2.06+ 
Summary10056: "Generate tokens" and "Create dummy tokens" results are different (mixed vs. lower case)
Description

When using "Generate tokens" the results are mixed case; but when using "Create dummy tokens" just lower case (plus digits in both).

Steps To Reproduce

Create survey using tokens, use different token generating mechanisms as described.

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)2.06+ 151018
I will donate to the project if issue is resolvedNo
BrowserAny
Database type & versionMS SQL server 2008R2 10.50.6220 (X64)
Server OS (if known)DB server: Windows NT 6.1 <X64> build 7601 SP1
Webserver software & version (if known)Linux RHEL 7, Apache 2.4.6
PHP Version5.6.13
Git branch / Pull Request URL

Users monitoring this issue

There are no users monitoring this issue.

Activities

mfavetti

mfavetti

2015-12-02 00:52

developer   ~33644

Last edited: 2015-12-02 00:53

"Create dummy tokens" uses randomChars from common_helper.php which chooses $tokenLength from "23456789abcdefghijkmnpqrstuvwxyz" and uses PHP's mt_rand

Generate Tokens uses generateRandomString from Yii's SecurityManager

The fix would be simply changing them to both use the same.

I can make the pull request, but there is a design decision for the team first. Which one should be used?
c_schmitz

c_schmitz

2015-12-04 09:29

administrator   ~33664

Both should use generateRandomString - if you can create a patch PR that would be really nice.
c_schmitz

c_schmitz

2015-12-04 17:22

administrator   ~33714

zerwalter?
mfavetti

mfavetti

2015-12-04 19:31

developer   ~33720

Ok, I'll submit the PR as soon as it's done.
mfavetti

mfavetti

2015-12-04 20:22

developer   ~33721

Ok, submitted.
c_schmitz

c_schmitz

2015-12-08 16:01

administrator   ~33753

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=16404
c_schmitz

c_schmitz

2015-12-08 16:01

administrator   ~33754

Thank you very much!
c_schmitz

c_schmitz

2015-12-15 13:15

administrator   ~33953

2.06+ Build 151215 released

Related Changesets

LimeSurvey: master fbc45234

2015-12-04 20:19

mfavetti


Details Diff		 Fixed Issue 10056: Inconsistency between tokens generated by 'Create dummy tokens' and 'Generate tokens' Affected Issues
10056
mod - application/controllers/admin/tokens.php Diff File

LimeSurvey: master 39cf89db

2015-12-08 16:00

c_schmitz


Details Diff		 Merge pull request #394 from zerwalter/fix-token-generation

Fixed Issue 10056: Inconsistency between tokens generated by 'Create dummy tokens' and 'Generate tokens'		 Affected Issues
10056
mod - application/controllers/admin/tokens.php Diff File

Issue History

Date Modified Username Field Change
2015-11-23 15:35 fvanderstarre New Issue
2015-12-02 00:52 mfavetti Note Added: 33644
2015-12-02 00:53 mfavetti Note Edited: 33644
2015-12-04 09:29 c_schmitz Note Added: 33664
2015-12-04 17:22 c_schmitz Note Added: 33714
2015-12-04 17:22 c_schmitz Assigned To => c_schmitz
2015-12-04 17:22 c_schmitz Status new => feedback
2015-12-04 19:31 mfavetti Note Added: 33720
2015-12-04 20:22 mfavetti Note Added: 33721
2015-12-08 16:01 mfavetti Changeset attached => LimeSurvey master fbc45234
2015-12-08 16:01 c_schmitz Changeset attached => LimeSurvey master 39cf89db
2015-12-08 16:01 c_schmitz Note Added: 33753
2015-12-08 16:01 c_schmitz Resolution open => fixed
2015-12-08 16:01 c_schmitz Note Added: 33754
2015-12-08 16:01 c_schmitz Status feedback => resolved
2015-12-08 16:01 c_schmitz Fixed in Version => 2.06+
2015-12-15 13:15 c_schmitz Note Added: 33953
2015-12-15 13:15 c_schmitz Status resolved => closed
2016-12-08 10:39 c_schmitz Category Tokens => Survey participants (Tokens)