LimeSurvey: master 5be16643

Diff Back to Repository
Author Committer Branch Timestamp Parent
twilllig GitHub master 2024-02-14 15:59 master aded0fed
Changeset

QE-588 return validation errors (#3727)

    • moved validation to validateOperation function and return errors in response
    • moved validation to validateOperation function and return errors in response

  • fixed failing unit tests

  • fixed number of lines in function

  • fixed psalm issues

  • fixed more psalm issues

  • fixed more psalm issues

  • fixed more psalm issues

  • added unit tests for opHandler validation

  • throw NotFoundException for empty props + removed stacktrace from response

  • add user friendly message to response, rename ErronousOperation to ExceptionError

  • fix codeformat

  • added unit test for structure of response

  • QE-777 - add field name to the validation response

  • fix questiongroup l10n save, when additional languages are not existent

  • Dev: Fix Tranformer::validateKey(), exception expects a string

Co-authored-by: Kevin Foster kevin.foster.uk@gmail.com
mod - application/libraries/Api/Command/V1/SurveyPatch/OpHandlerAnswer.php Diff File
mod - application/libraries/Api/Command/V1/SurveyPatch/OpHandlerAnswerDelete.php Diff File
mod - application/libraries/Api/Command/V1/SurveyPatch/OpHandlerLanguageSettingsUpdate.php Diff File
mod - application/libraries/Api/Command/V1/SurveyPatch/OpHandlerQuestionAttributeUpdate.php Diff File
mod - application/libraries/Api/Command/V1/SurveyPatch/OpHandlerQuestionCreate.php Diff File
mod - application/libraries/Api/Command/V1/SurveyPatch/OpHandlerQuestionDelete.php Diff File
mod - application/libraries/Api/Command/V1/SurveyPatch/OpHandlerQuestionGroup.php Diff File
mod - application/libraries/Api/Command/V1/SurveyPatch/OpHandlerQuestionGroupL10n.php Diff File
mod - application/libraries/Api/Command/V1/SurveyPatch/OpHandlerQuestionGroupReorder.php Diff File
mod - application/libraries/Api/Command/V1/SurveyPatch/OpHandlerQuestionL10nUpdate.php Diff File
mod - application/libraries/Api/Command/V1/SurveyPatch/OpHandlerQuestionUpdate.php Diff File
mod - application/libraries/Api/Command/V1/SurveyPatch/OpHandlerSubQuestion.php Diff File
mod - application/libraries/Api/Command/V1/SurveyPatch/OpHandlerSubquestionDelete.php Diff File
mod - application/libraries/Api/Command/V1/SurveyPatch/OpHandlerSurveyUpdate.php Diff File
mod - application/libraries/Api/Command/V1/SurveyPatch/PatcherSurvey.php Diff File
rm - application/libraries/Api/Command/V1/SurveyPatch/Response/ErronousOperationItem.php Diff
rm - application/libraries/Api/Command/V1/SurveyPatch/Response/ErronousOperations.php Diff
add - application/libraries/Api/Command/V1/SurveyPatch/Response/ExceptionErrorItem.php Diff File
add - application/libraries/Api/Command/V1/SurveyPatch/Response/ExceptionErrors.php Diff File
add - application/libraries/Api/Command/V1/SurveyPatch/Response/SurveyResponse.php Diff File
mod - application/libraries/Api/Command/V1/SurveyPatch/Response/TempIdMapping.php Diff File
add - application/libraries/Api/Command/V1/SurveyPatch/Response/ValidationErrorItem.php Diff File
add - application/libraries/Api/Command/V1/SurveyPatch/Response/ValidationErrors.php Diff File
mod - application/libraries/Api/Command/V1/SurveyPatch/Traits/OpHandlerExceptionTrait.php Diff File
rm - application/libraries/Api/Command/V1/SurveyPatch/Traits/OpHandlerL10nTrait.php Diff
add - application/libraries/Api/Command/V1/SurveyPatch/Traits/OpHandlerValidationTrait.php Diff File
mod - application/libraries/Api/Command/V1/Transformer/Input/TransformerInputAnswer.php Diff File
mod - application/libraries/Api/Command/V1/Transformer/Input/TransformerInputQuestion.php Diff File
mod - application/libraries/Api/Command/V1/Transformer/Input/TransformerInputQuestionGroupL10ns.php Diff File
add - application/libraries/Api/Command/V1/Transformer/Input/TransformerInputQuestionGroupReorder.php Diff File
mod - application/libraries/Api/Command/V1/Transformer/Input/TransformerInputSubQuestion.php Diff File
mod - application/libraries/Api/Command/V1/Transformer/Input/TransformerInputSurveyLanguageSettings.php Diff File
mod - application/libraries/Api/Transformer/Transformer.php Diff File
mod - application/libraries/ObjectPatch/OpHandler/OpHandlerActiveRecordUpdate.php Diff File
mod - application/libraries/ObjectPatch/OpHandler/OpHandlerInterface.php Diff File
mod - application/libraries/ObjectPatch/Patcher.php Diff File
mod - application/models/services/QuestionAggregateService/AttributesService.php Diff File
mod - application/models/services/QuestionGroupService.php Diff File
mod - application/views/surveyAdministration/partial/topbar/surveyTopbarRight_view.php Diff File
mod - tests/unit/api/opHandlers/OpHandlerAnswerDeleteTest.php Diff File
mod - tests/unit/api/opHandlers/OpHandlerAnswerTest.php Diff File
mod - tests/unit/api/opHandlers/OpHandlerLanguageSettingsTest.php Diff File
mod - tests/unit/api/opHandlers/OpHandlerQuestionCreateTest.php Diff File
mod - tests/unit/api/opHandlers/OpHandlerQuestionGroupL10nTest.php Diff File
mod - tests/unit/api/opHandlers/OpHandlerQuestionGroupReorderTest.php Diff File
mod - tests/unit/api/opHandlers/OpHandlerQuestionGroupTest.php Diff File
mod - tests/unit/api/opHandlers/OpHandlerQuestionL10nTest.php Diff File
mod - tests/unit/api/opHandlers/OpHandlerQuestionUpdateTest.php Diff File
mod - tests/unit/api/opHandlers/OpHandlerSubquesDeleteTest.php Diff File
mod - tests/unit/api/opHandlers/OpHandlerSubquestionUpdateTest.php Diff File
mod - tests/unit/api/opHandlers/OpHandlerSurveyUpdateTest.php Diff File
mod - tests/unit/api/transformer/TransformerInputAnswerTest.php Diff File
mod - tests/unit/api/transformer/TransformerInputQuestionAggregateTest.php Diff File
add - tests/unit/api/transformer/TransformerInputQuestionGroupReorderTest.php Diff File
mod - tests/unit/objectpatch/PatcherTest.php Diff File
add - tests/unit/objectpatch/SurveyResponseTest.php Diff File