View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 09056 | Bug reports | Plugins | public | 2014-05-27 10:43 | 2026-11-20 19:08 |
| Reporter | DenisChenu | Assigned To | c_schmitz | ||
| Priority | normal | Severity | minor | ||
| Status | resolved | Resolution | fixed | ||
| Summary | 09056: Security : Pulgin settings password is shown in HTML source | ||||
| Description | If you have a password plugin, it shown in HTML source. Think we need to update only if not empty, and don't put in HTML | ||||
| Steps To Reproduce | Activate https://gitorious.org/demo-limesurvey/examplesettings and update the password, | ||||
| Additional Information | Maybe we have to put it crypted in DB ? Then using password is more safe, but more complicated. | ||||
| Tags | No tags attached. | ||||
| Bug heat | 8 | ||||
| Complete LimeSurvey version number (& build) | |||||
| I will donate to the project if issue is resolved | |||||
| Browser | |||||
| Database type & version | |||||
| Server OS (if known) | |||||
| Webserver software & version (if known) | |||||
| PHP Version | |||||
| Git branch / Pull Request URL | https://github.com/LimeSurvey/LimeSurvey/pull/2743 | ||||
| related to | 12603 | closed | Setting emailsmtppassword is saved as clear text | |
| related to | 18375 | closed | gabrieljenik | Security : Some plugin settings need encryption |
|
autocomplete="off" not working anymore https://twitter.com/FxSiteCompat/status/477244922387763202 (IE11 too and chrome (not know the number)) Think an empty string can do the job. |
|
|
autocomplete attribute works on password fields? |
|
|
autocomplete="off" : no you still se "Do you want to save password" with it :) But it's not related here. |
|
|
@gabrieljenik it's for develop or master here ? |
|
|
Well crypt part is just for develop as it is kind of a new feature. |
|
I check to have a complete working system without way to broke any plugins :)
|
|
|
Plugin test |
|
|
here by OPTIN to be sure at 100% for plugin compatibility https://github.com/LimeSurvey/LimeSurvey/pull/2651 Why not by default : can broke some plugin using SettingWidget |
|
|
Same than before , just update to las master and move repo on LimeSurvey |
|
|
Left some comments on the PR. I recall you asked about this story on discord. |
|
|
Other related |
|
Some «web ergonomics specialist» or web quality ? |
|
I meant Carsten or Olle. |
|
|
This describes a problem in an existing feature rather than a development task, so it is moved to the bug reports. |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=41399 |
|
|
For usability it's really better to have a checkbox "Update password" And here: Potential issue with previous plugin if they have their own systeml. |
|
|
LimeSurvey: master cff832ac 2026-11-20 18:36 Details Diff |
Fixed issue 09056: [security] Information disclosure in the plugin settings. Severity: Low (CVSS 2.7, AV:N/AC:L/PR:H/UI:N/S:U/C:L/I:N/A:N). An authenticated user with read permission on the global settings, or on the settings of a survey, could read passwords stored in plugin settings, such as the password of the LDAP search account, in the HTML source of the settings page. Affects versions 2.05 and later. Reported by: DenisChenu. Dev Plugins that show the settings widget on their own pages can hide stored passwords with the new class PasswordSettingMask |
Affected Issues 09056 |
|
| mod - application/controllers/SurveyAdministrationController.php | Diff File | ||
| mod - application/controllers/admin/PluginManagerController.php | Diff File | ||
| add - application/libraries/PluginManager/PasswordSettingMask.php | Diff File | ||
| mod - application/models/services/SurveyAggregateService/GeneralSettings.php | Diff File | ||
| add - tests/unit/plugins/PasswordSettingMaskTest.php | Diff File | ||
| add - tests/unit/services/SurveyAggregateService/GeneralSettings/GeneralSettingsPluginPasswordTest.php | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-05-27 10:43 | DenisChenu | New Issue | |
| 2014-06-17 14:42 | DenisChenu | Note Added: 30130 | |
| 2017-08-23 12:47 | DenisChenu | Relationship added | related to 12603 |
| 2019-03-12 16:24 | Mazi | Issue Monitored: Mazi | |
| 2019-06-12 18:31 | DenisChenu | Assigned To | => DenisChenu |
| 2019-06-12 18:31 | DenisChenu | Status | new => assigned |
| 2022-09-26 18:04 | DenisChenu | Assigned To | DenisChenu => gabrieljenik |
| 2022-09-26 18:23 | gabrieljenik | Issue cloned: 18375 | |
| 2022-09-26 18:23 | gabrieljenik | Relationship added | related to 18375 |
| 2022-10-05 14:30 | gabrieljenik | Bug heat | 4 => 6 |
| 2022-10-05 14:31 | DenisChenu | Bug heat | 6 => 4 |
| 2022-10-06 11:50 | DenisChenu | Assigned To | gabrieljenik => DenisChenu |
| 2022-10-06 13:34 | gabrieljenik | Note Added: 72152 | |
| 2022-10-06 13:34 | gabrieljenik | Bug heat | 4 => 6 |
| 2022-10-06 15:46 | DenisChenu | Note Added: 72153 | |
| 2022-10-06 15:46 | DenisChenu | Note Added: 72154 | |
| 2022-10-06 18:00 | gabrieljenik | Note Added: 72155 | |
| 2022-10-06 18:17 | DenisChenu | Note Added: 72157 | |
| 2022-10-07 19:39 | DenisChenu | Note Added: 72169 | |
| 2022-10-07 19:39 | DenisChenu | File Added: TestPasswordSetting.zip | |
| 2022-10-18 18:12 | DenisChenu | Git branch / Pull Request URL | => https://github.com/LimeSurvey/LimeSurvey/pull/2651 |
| 2022-10-18 18:15 | DenisChenu | Assigned To | DenisChenu => |
| 2022-10-18 18:15 | DenisChenu | Status | assigned => ready for code review |
| 2022-10-18 18:15 | DenisChenu | Note Added: 72354 | |
| 2022-11-23 14:55 | DenisChenu | Git branch / Pull Request URL | https://github.com/LimeSurvey/LimeSurvey/pull/2651 => https://github.com/LimeSurvey/LimeSurvey/pull/2743 |
| 2022-11-23 14:55 | DenisChenu | Note Added: 72862 | |
| 2022-11-23 14:55 | DenisChenu | Assigned To | => ollehar |
| 2022-11-23 14:55 | DenisChenu | Assigned To | ollehar => gabrieljenik |
| 2022-11-23 14:56 | DenisChenu | Note Added: 72863 | |
| 2022-11-23 14:56 | DenisChenu | Note Added: 72864 | |
| 2022-11-23 17:32 | gabrieljenik | Note Added: 72868 | |
| 2022-11-23 17:44 | DenisChenu | Note Added: 72870 | |
| 2022-11-23 17:53 | DenisChenu | Note Added: 72871 | |
| 2022-11-23 18:00 | DenisChenu | Assigned To | gabrieljenik => |
| 2022-11-23 18:23 | gabrieljenik | Note Added: 72873 | |
| 2022-11-23 18:26 | DenisChenu | Note Added: 72875 | |
| 2023-10-20 09:42 | DenisChenu | Assigned To | => DenisChenu |
| 2023-10-20 09:42 | DenisChenu | Status | ready for code review => assigned |
| 2026-11-19 22:49 | c_schmitz | Note Added: 87767 | |
| 2026-11-19 22:49 | c_schmitz | Bug heat | 6 => 8 |
| 2026-11-19 22:49 | c_schmitz | Project | @10@ => Bug reports |
| 2026-11-20 18:41 | c_schmitz | Changeset attached | => LimeSurvey master cff832ac |
| 2026-11-20 18:41 | c_schmitz | Note Added: 87868 | |
| 2026-11-20 18:41 | c_schmitz | Assigned To | DenisChenu => c_schmitz |
| 2026-11-20 18:41 | c_schmitz | Status | assigned => resolved |
| 2026-11-20 18:41 | c_schmitz | Resolution | open => fixed |
| 2026-11-20 19:08 | DenisChenu | Note Added: 87869 |