View Issue Details

This issue affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
09056Bug reportsPluginspublic2026-11-19 22:49
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynormalSeverityminor 
Status assignedResolutionopen 
Summary09056: Security : Pulgin settings password is shown in HTML source
Description

If you have a password plugin, it shown in HTML source. Think we need to update only if not empty, and don't put in HTML

Steps To Reproduce

Activate https://gitorious.org/demo-limesurvey/examplesettings and update the password,
update the settings again and look at HTML source

Additional Information

Maybe we have to put it crypted in DB ? Then using password is more safe, but more complicated.

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)
I will donate to the project if issue is resolved
Browser
Database type & version
Server OS (if known)
Webserver software & version (if known)
PHP Version
Git branch / Pull Request URLhttps://github.com/LimeSurvey/LimeSurvey/pull/2743

Relationships

related to 12603 closeddominikvitt Bug reports Setting emailsmtppassword is saved as clear text 

Users monitoring this issue

Mazi

Activities

DenisChenu

DenisChenu

2014-06-17 14:42

developer   ~30130

autocomplete="off" not working anymore https://twitter.com/FxSiteCompat/status/477244922387763202 (IE11 too and chrome (not know the number))

Think an empty string can do the job.

gabrieljenik

gabrieljenik

2022-10-06 13:34

developer   ~72152

autocomplete attribute works on password fields?

DenisChenu

DenisChenu

2022-10-06 15:46

developer   ~72153

autocomplete="off" : no you still se "Do you want to save password" with it :)

But it's not related here.

DenisChenu

DenisChenu

2022-10-06 15:46

developer   ~72154

@gabrieljenik it's for develop or master here ?
It's need for master too , but since crypt in DB is for develop ?
Unsure

gabrieljenik

gabrieljenik

2022-10-06 18:00

developer   ~72155

Well crypt part is just for develop as it is kind of a new feature.
But truth is we need it for security purposes.
So, could well also go to master, right?

DenisChenu

DenisChenu

2022-10-06 18:17

developer   ~72157

So, could well also go to master, right?

I check to have a complete working system without way to broke any plugins :)
2 solutions

  • set settings to current value if it's not updated
  • don't send to settings array (if it's not updated)
DenisChenu

DenisChenu

2022-10-07 19:39

developer   ~72169

Plugin test

DenisChenu

DenisChenu

2022-10-18 18:15

developer   ~72354

here by OPTIN to be sure at 100% for plugin compatibility

https://github.com/LimeSurvey/LimeSurvey/pull/2651

Why not by default : can broke some plugin using SettingWidget
It's OK for any plugin using saveSettings or newSurveySetiings

DenisChenu

DenisChenu

2022-11-23 14:55

developer   ~72862

https://github.com/LimeSurvey/LimeSurvey/pull/2743

DenisChenu

DenisChenu

2022-11-23 14:56

developer   ~72863

Same than before , just update to las master and move repo on LimeSurvey

DenisChenu

DenisChenu

2022-11-23 14:56

developer   ~72864

https://github.com/LimeSurvey/LimeSurvey/pull/2743

gabrieljenik

gabrieljenik

2022-11-23 17:32

developer   ~72868

Left some comments on the PR.

I recall you asked about this story on discord.
Not sure how that ended up.
Probably would be good to have someone else to review it.

DenisChenu

DenisChenu

2022-11-23 17:44

developer   ~72870

Other related
https://github.com/LimeSurvey/LimeSurvey/pull/2651
https://github.com/LimeSurvey/LimeSurvey/pull/2650

DenisChenu

DenisChenu

2022-11-23 17:53

developer   ~72871

Probably would be good to have someone else to review it.

Some «web ergonomics specialist» or web quality ?
https://directory.opquast.com/fr/certificat/31650N/
;)

gabrieljenik

gabrieljenik

2022-11-23 18:23

developer   ~72873

Probably would be good to have someone else to review it.

I meant Carsten or Olle.
I believe my review is not enough here.

DenisChenu

DenisChenu

2022-11-23 18:26

developer   ~72875

@Jelo or @holch maybe ?

c_schmitz

c_schmitz

2026-11-19 22:49

administrator   ~87767

This describes a problem in an existing feature rather than a development task, so it is moved to the bug reports.

Issue History

Date Modified Username Field Change
2014-05-27 10:43 DenisChenu New Issue
2014-06-17 14:42 DenisChenu Note Added: 30130
2017-08-23 12:47 DenisChenu Relationship added related to 12603
2019-03-12 16:24 Mazi Issue Monitored: Mazi
2019-06-12 18:31 DenisChenu Assigned To => DenisChenu
2019-06-12 18:31 DenisChenu Status new => assigned
2022-09-26 18:04 DenisChenu Assigned To DenisChenu => gabrieljenik
2022-09-26 18:23 gabrieljenik Issue cloned: 18375
2022-10-05 14:30 gabrieljenik Bug heat 4 => 6
2022-10-05 14:31 DenisChenu Bug heat 6 => 4
2022-10-06 11:50 DenisChenu Assigned To gabrieljenik => DenisChenu
2022-10-06 13:34 gabrieljenik Note Added: 72152
2022-10-06 13:34 gabrieljenik Bug heat 4 => 6
2022-10-06 15:46 DenisChenu Note Added: 72153
2022-10-06 15:46 DenisChenu Note Added: 72154
2022-10-06 18:00 gabrieljenik Note Added: 72155
2022-10-06 18:17 DenisChenu Note Added: 72157
2022-10-07 19:39 DenisChenu Note Added: 72169
2022-10-07 19:39 DenisChenu File Added: TestPasswordSetting.zip
2022-10-18 18:12 DenisChenu Git branch / Pull Request URL => https://github.com/LimeSurvey/LimeSurvey/pull/2651
2022-10-18 18:15 DenisChenu Assigned To DenisChenu =>
2022-10-18 18:15 DenisChenu Status assigned => ready for code review
2022-10-18 18:15 DenisChenu Note Added: 72354
2022-11-23 14:55 DenisChenu Git branch / Pull Request URL https://github.com/LimeSurvey/LimeSurvey/pull/2651 => https://github.com/LimeSurvey/LimeSurvey/pull/2743
2022-11-23 14:55 DenisChenu Note Added: 72862
2022-11-23 14:55 DenisChenu Assigned To => ollehar
2022-11-23 14:55 DenisChenu Assigned To ollehar => gabrieljenik
2022-11-23 14:56 DenisChenu Note Added: 72863
2022-11-23 14:56 DenisChenu Note Added: 72864
2022-11-23 17:32 gabrieljenik Note Added: 72868
2022-11-23 17:44 DenisChenu Note Added: 72870
2022-11-23 17:53 DenisChenu Note Added: 72871
2022-11-23 18:00 DenisChenu Assigned To gabrieljenik =>
2022-11-23 18:23 gabrieljenik Note Added: 72873
2022-11-23 18:26 DenisChenu Note Added: 72875
2023-10-20 09:42 DenisChenu Assigned To => DenisChenu
2023-10-20 09:42 DenisChenu Status ready for code review => assigned
2026-11-19 22:49 c_schmitz Note Added: 87767
2026-11-19 22:49 c_schmitz Bug heat 6 => 8
2026-11-19 22:49 c_schmitz Project Development => Bug reports