View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 19851 | Bug reports | Usability/user experience | public | 2024-11-22 14:46 | 2026-11-01 00:49 |
| Reporter | DenisChenu | Assigned To | c_schmitz | ||
| Priority | none | Severity | minor | ||
| Status | resolved | Resolution | fixed | ||
| Product Version | 6.6.x | ||||
| Summary | 19851: When not loggued : update some form didn't show 401 or redirect to login | ||||
| Description | When you submit some form you get an infinite loop … and you can wait until die ;) | ||||
| Steps To Reproduce | Steps to reproduceLogin Expected resultShow a 401 : must be loggued error Actual resultInfinite loop | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Bug heat | 6 | ||||
| Complete LimeSurvey version number (& build) | 6.8.1 | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | firefox | ||||
| Database type & version | not relevant | ||||
| Server OS (if known) | not relevant | ||||
| Webserver software & version (if known) | not relevant | ||||
| PHP Version | not relevant | ||||
| Git branch / Pull Request URL | N/A | ||||
|
The response are a redirect |
|
|
@DenisChenu, can you take this one? |
|
|
@tibor.pacalat , @c_schmitz : the solution : send a 400 error if it's a POST request is OK (and it's not a login request) ? |
|
|
@DenisChenu, if I get this right it is just a bad user experience (infinite loop) but nothing critical or security related? |
|
|
@Mazi : yes bad user experience. Nothing critical, no real issue. |
|
|
More complex to find where is done than I think here … |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=41212 |
|
|
LimeSurvey: master cfd53ad3 2026-11-01 00:47 Details Diff |
Fixed issue 19851: After being logged out (e.g. in another tab), saving a question and other admin actions silently did nothing instead of asking to log in again Dev LSBaseController now answers all XHR requests of a logged-out user (not only ?ajax=1) with HTTP 401 and the not-logged-in JSON, like AdminController already did Dev New adminbasics ajaxError handler shows a "You have been logged out" modal with a "Log in" link that returns to the current page Dev It replaces the old ajax login form modal, which never worked: Its import failed on case-sensitive file systems, and its login was rejected by the CSRF check Dev CLSGridView and the question editor no longer show their raw error alerts on HTTP 401 |
Affected Issues 19851 |
|
| mod - application/controllers/LSBaseController.php | Diff File | ||
| mod - application/extensions/admin/grid/CLSGridView.php | Diff File | ||
| mod - application/helpers/admin/ajax_helper.php | Diff File | ||
| add - application/views/admin/authentication/ajaxLoggedOut.php | Diff File | ||
| rm - application/views/admin/authentication/ajaxLogin.php | Diff | ||
| mod - assets/packages/adminbasics/build/adminbasics.js | Diff File | ||
| mod - assets/packages/adminbasics/build/adminbasics.min.js | Diff File | ||
| mod - assets/packages/adminbasics/src/adminbasicsmain.js | Diff File | ||
| mod - assets/packages/adminbasics/src/parts/ajaxHelper.js | Diff File | ||
| mod - assets/scripts/admin/questionEditor.js | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-11-22 14:46 | DenisChenu | New Issue | |
| 2024-11-22 14:46 | DenisChenu | File Added: Capture vidéo du 2024-11-22 14-42-35.webm | |
| 2024-11-22 14:48 | DenisChenu | Note Added: 81499 | |
| 2024-11-22 14:48 | DenisChenu | File Added: image.png | |
| 2024-11-22 14:48 | DenisChenu | Bug heat | 0 => 2 |
| 2024-11-25 20:39 | Mazi | Note Added: 81510 | |
| 2024-11-25 20:39 | Mazi | Bug heat | 2 => 4 |
| 2024-11-26 08:52 | DenisChenu | Note Added: 81511 | |
| 2025-01-06 12:49 | Mazi | Note Added: 81737 | |
| 2025-01-06 16:32 | DenisChenu | Note Added: 81741 | |
| 2025-01-06 16:32 | DenisChenu | Assigned To | => DenisChenu |
| 2025-01-06 16:32 | DenisChenu | Status | new => assigned |
| 2025-09-25 17:15 | DenisChenu | Note Added: 83484 | |
| 2026-11-01 00:49 | c_schmitz | Changeset attached | => LimeSurvey master cfd53ad3 |
| 2026-11-01 00:49 | c_schmitz | Note Added: 87063 | |
| 2026-11-01 00:49 | c_schmitz | Assigned To | DenisChenu => c_schmitz |
| 2026-11-01 00:49 | c_schmitz | Status | assigned => resolved |
| 2026-11-01 00:49 | c_schmitz | Resolution | open => fixed |
| 2026-11-01 00:49 | c_schmitz | Bug heat | 4 => 6 |