View Issue Details

This issue affects 1 person(s).
 2
IDProjectCategoryView StatusLast Update
18660Bug reportsOtherpublic2026-11-20 16:57
Reportergabrieljenik Assigned Toc_schmitz  
PrioritynoneSeverityminor 
Status resolvedResolutionfixed 
Summary18660: Upload Controller has desde code for preview mode
Description

While reviewing 18658, noticed there is dead code for preview mode.

It is dead because preview flag is being picked up wrongly from session:
$preview = Yii::app()->session['preview'];

Steps To Reproduce

Preview mode is expected to not save the file on the server.
If this is just a preview, don't save the file

I guess it is being saved now while it is not expected.

TagsNo tags attached.
Bug heat2
Complete LimeSurvey version number (& build)5.6.8
I will donate to the project if issue is resolvedNo
BrowserChrome, Firefox, Safari
Database type & version447
Server OS (if known)
Webserver software & version (if known)
PHP VersionNA
Git branch / Pull Request URL

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2026-11-20 16:57

administrator   ~87844

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=41387

Related Changesets

LimeSurvey: master e6798183

2026-11-20 16:57

c_schmitz


Details Diff
Fixed issue 18660: Plugins using the beforeProcessFileUpload event were never told that a file was uploaded in preview mode
Dev Removed the never-reached preview branch of the upload controller
Affected Issues
18660
mod - application/controllers/UploaderController.php Diff File

Issue History

Date Modified Username Field Change
2023-02-28 15:57 gabrieljenik New Issue
2023-02-28 15:57 gabrieljenik Issue generated from: 18658
2023-02-28 15:57 gabrieljenik Project Bug reports => @10@
2026-11-19 22:50 c_schmitz Status new => acknowledged
2026-11-19 22:50 c_schmitz Product Version 5.6.x =>
2026-11-20 16:57 c_schmitz Changeset attached => LimeSurvey master e6798183
2026-11-20 16:57 c_schmitz Note Added: 87844
2026-11-20 16:57 c_schmitz Assigned To => c_schmitz
2026-11-20 16:57 c_schmitz Status acknowledged => resolved
2026-11-20 16:57 c_schmitz Resolution open => fixed
2026-11-20 16:57 c_schmitz Bug heat 0 => 2