View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 18138 | Bug reports | Survey editing | public | 2022-05-20 21:01 | 2026-10-13 18:02 |
| Reporter | gabrieljenik | Assigned To | c_schmitz | ||
| Priority | none | Severity | partial_block | ||
| Status | resolved | Resolution | fixed | ||
| Product Version | 5.3.x | ||||
| Summary | 18138: When entering the survey setting screen, the survey theme being loaded needs reviewal. | ||||
| Description | The process needs reviewal. When you enter the administration page of a survey, the theme being picked up (the one got in getSurveyInfo) is not the one of the survey, but the one of the group. That is, even if the survey does not inherit from the group, on those screens it ends up "inheriting" it anyway. Why? Because of this:
Since the survey administration screens go through SurveyAdministrationController::actionRendersidemenulink() , setOptionsFromDatabase() is called, causing $survey->options to have the values from the group instead of the survey. Then the same controller, in the beforeRender() calls LimeExpressionManager::StartProcessingPage(false, true), which ends up calling templatereplace("{SID}") (not sure why is that needed). There, the template returned by getSurveyInfo is the one used, merging the attributes of the survey with those of "options" (which are the ones that went wrong). | ||||
| Steps To Reproduce | Picked up while reviewing 18085 | ||||
| Tags | No tags attached. | ||||
| Bug heat | 4 | ||||
| Complete LimeSurvey version number (& build) | 5.3.10 220419 | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | Chrome | ||||
| Database type & version | Postgresql, EnterpriseDB 10.9.17 | ||||
| Server OS (if known) | Windows | ||||
| Webserver software & version (if known) | NGINX | ||||
| PHP Version | PHP 8, php-cgi | ||||
| related to | 18116 | closed | gabrieljenik | Ability to disable animation layer regarding saving in header section |
|
It's a bad ordering ?
I tghink we have a discussion about an array_merge( Somewhere |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=40829 |
|
|
LimeSurvey: master b54fd224 2026-10-13 18:02 Details Diff |
Fixed issue 18138: Survey settings pages used the survey group's theme and settings instead of the survey's own |
Affected Issues 18138 |
|
| mod - application/controllers/SurveyAdministrationController.php | Diff File | ||
| add - tests/unit/controllers/SurveyAdministrationControllerInheritedOptionsTest.php | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-05-20 21:01 | gabrieljenik | New Issue | |
| 2022-05-20 21:01 | gabrieljenik | Issue generated from: 18085 | |
| 2022-05-21 15:48 | DenisChenu | Note Added: 69957 | |
| 2022-05-21 15:48 | DenisChenu | Bug heat | 0 => 2 |
| 2022-05-24 15:23 | DenisChenu | Relationship added | related to 18116 |
| 2022-05-27 22:49 | gabrieljenik | Status | new => confirmed |
| 2026-10-13 18:02 | c_schmitz | Changeset attached | => LimeSurvey master b54fd224 |
| 2026-10-13 18:02 | c_schmitz | Note Added: 86433 | |
| 2026-10-13 18:02 | c_schmitz | Assigned To | => c_schmitz |
| 2026-10-13 18:02 | c_schmitz | Status | confirmed => resolved |
| 2026-10-13 18:02 | c_schmitz | Resolution | open => fixed |
| 2026-10-13 18:02 | c_schmitz | Bug heat | 2 => 4 |