View Issue Details

This issue affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
17858Bug reportsTheme editorpublic2026-10-24 20:00
ReporterDenisChenu Assigned Toc_schmitz  
PrioritynoneSeveritypartial_block 
Status resolvedResolutionfixed 
Product Version5.2.x 
Summary17858: Template option badly saved with image:theme
Description

When using specific option : it can be saved as image::theme even if unneeded and notwanted.

Steps To Reproduce

Steps to reproduce

get https://dl.sondages.pro/skelvanilla.zip 10.4.12 https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla/-/commit/f46bf81a4928ddc48fa2c9dfeb3d86fd6e5bc3b6
Import
Set a different theme for a survey
Save : theme is empty

Expected result

theme is OK

Actual result

theme is saved with image::theme:: prefix.

TagsNo tags attached.
Attached Files
Peek 31-01-2022 13-30.gif (1,328,885 bytes)
Bug heat4
Complete LimeSurvey version number (& build)5.2.11
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant
Git branch / Pull Request URLN/A

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2022-01-31 13:43

developer   ~68149

javascript update it just before save …

DenisChenu

DenisChenu

2022-01-31 16:55

developer   ~68154

Workaround for skelvanilla : https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla/-/commit/014d061aa666ed631d2e4cb79102a1112f328147

test version : https://dl.sondages.pro/skelvanilla_10.4.12.zip

DenisChenu

DenisChenu

2022-07-28 10:20

developer   ~71216

API broker , must revert and put to dev ?

DenisChenu

DenisChenu

2024-06-12 15:52

developer   ~80278

Need to test on 6 (think it same)

c_schmitz

c_schmitz

2026-10-24 20:00

administrator   ~86750

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=41007

Related Changesets

LimeSurvey: master 7390d950

2026-10-24 19:59

c_schmitz


Details Diff
Fixed issue 17858: A custom theme option holding a non-image file (e.g. a CSS variation) was saved with an "image::theme::" prefix and stopped working
Dev Only values with an image extension (or already virtual paths) are sanitized now, so the cssframework exclusion is no longer needed
Affected Issues
17858
mod - application/helpers/SurveyThemeHelper.php Diff File
mod - application/models/TemplateConfiguration.php Diff File
mod - tests/unit/helpers/SurveyThemeHelperTest.php Diff File
mod - tests/unit/models/TemplateConfigurationTest.php Diff File

Issue History

Date Modified Username Field Change
2022-01-31 13:42 DenisChenu New Issue
2022-01-31 13:42 DenisChenu File Added: Peek 31-01-2022 13-30.gif
2022-01-31 13:43 DenisChenu Note Added: 68149
2022-01-31 13:43 DenisChenu Bug heat 0 => 2
2022-01-31 16:55 DenisChenu Note Added: 68154
2022-02-01 09:38 galads Assigned To => galads
2022-02-01 09:38 galads Status new => acknowledged
2022-07-28 10:20 DenisChenu Assigned To galads => DenisChenu
2022-07-28 10:20 DenisChenu Assigned To DenisChenu => ollehar
2022-07-28 10:20 DenisChenu Note Added: 71216
2024-06-12 15:52 DenisChenu Assigned To ollehar =>
2024-06-12 15:52 DenisChenu Status acknowledged => feedback
2024-06-12 15:52 DenisChenu Note Added: 80278
2026-10-24 20:00 c_schmitz Changeset attached => LimeSurvey master 7390d950
2026-10-24 20:00 c_schmitz Note Added: 86750
2026-10-24 20:00 c_schmitz Assigned To => c_schmitz
2026-10-24 20:00 c_schmitz Status feedback => resolved
2026-10-24 20:00 c_schmitz Resolution open => fixed
2026-10-24 20:00 c_schmitz Bug heat 2 => 4