View Issue Details

This issue affects 1 person(s).
 2
IDProjectCategoryView StatusLast Update
17531Bug reportsSurvey editingpublic2026-10-29 20:29
Reportermkofahl Assigned Toc_schmitz  
PrioritynoneSeverityminor 
Status resolvedResolutionfixed 
Product Version5.x 
Summary17531: missing error message in surveys bounce settings
Description

in https://github.com/LimeSurvey/LimeSurvey/blob/master/application/controllers/admin/tokens.php#L2395 $survey->save() may return false, but there's always a success message.

TagsNo tags attached.
Bug heat2
Complete LimeSurvey version number (& build) 5.1.2+210813
I will donate to the project if issue is resolvedNo
Browser
Database type & versionPostgreSQL 10
Server OS (if known)
Webserver software & version (if known)
PHP Version7
Git branch / Pull Request URL

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2026-10-29 20:29

administrator   ~87005

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=41159

Related Changesets

LimeSurvey: master 38885c2a

2026-10-29 20:29

c_schmitz


Details Diff
Fixed issue 17531: Saving the bounce settings always reported success, even when the settings were not saved
Dev Tokens::bouncesettings() checks the result of $survey->save() and shows the validation errors instead of the success message
Affected Issues
17531
mod - application/controllers/admin/Tokens.php Diff File

Issue History

Date Modified Username Field Change
2021-08-20 10:04 mkofahl New Issue
2021-08-23 07:30 galads Assigned To => galads
2021-08-23 07:30 galads Status new => acknowledged
2026-10-29 20:29 c_schmitz Changeset attached => LimeSurvey master 38885c2a
2026-10-29 20:29 c_schmitz Note Added: 87005
2026-10-29 20:29 c_schmitz Assigned To galads => c_schmitz
2026-10-29 20:29 c_schmitz Status acknowledged => resolved
2026-10-29 20:29 c_schmitz Resolution open => fixed
2026-10-29 20:29 c_schmitz Bug heat 0 => 2