View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 14999 | Bug reports | Theme editor | public | 2019-06-24 09:54 | 2026-11-01 16:32 |
| Reporter | DenisChenu | Assigned To | c_schmitz | ||
| Priority | none | Severity | minor | ||
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.17.x | ||||
| Summary | 14999: Unable to unregister or replace script file | ||||
| Description | I try to work on an alternative JS solution on multiple checkbox with comment. | ||||
| Steps To Reproduce | Add | ||||
| Additional Information | And since script is loaded in qanda : can not be replaced Current solution : adding this at end of layout_global
But since there are an | ||||
| Tags | No tags attached. | ||||
| Bug heat | 4 | ||||
| Complete LimeSurvey version number (& build) | 6 | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | not relevant | ||||
| Database type & version | not relevant | ||||
| Server OS (if known) | not relevant | ||||
| Webserver software & version (if known) | not relevant | ||||
| PHP Version | not relevant | ||||
| Git branch / Pull Request URL | |||||
|
There are some other issue in Multiple choice with comments html produced
Can be fixed extend question answers.twig file, but think I think it's better to have it in core. |
|
|
I think this is not a issue anymore since you theoretically can use question themes. Correct? |
|
|
Some question update solution (all with PHP script) can not use question theme. I think it can be great if we have : Plugin adding question theme in such situation (see this forum post : https://forums.limesurvey.org/forum/plugins/159039-adaptive-maxdiff-plugin-for-limesurvey-6-experimental ) ?
|
|
|
Check to close |
|
(For 3 : it can be a DEV issue for 7.X : move all register script file to registerScriptFile twig function in answers : (None currently] (Here I try to do it in survey theme.) Here the issue are This function unregisters only POS_HEAD script : https://github.com/yiisoft/yii/blob/a2d4af95af420d1d77116e91b50d8c9cbff62673/framework/web/CClientScript.php#L25 We need a way to (i think both solutions are valid in my opinoion).
I can create both PR |
|
|
Did I create a PR with solution #1 or #2 ? |
|
|
I would say #2 |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=41226 |
|
|
LimeSurvey: master 0ceb1cf8 2026-11-01 16:30 Details Diff |
Fixed issue 14999: Survey themes could not remove a script file with unregisterScriptFile Dev LSYii_ClientScript::unregisterScriptFile() only looked at POS_HEAD, but question scripts are registered at POS_BEGIN/POS_END; it now removes the file from all positions Dev When the asset manager is used (debug off) the file is registered under its published tmp/assets URL, this URL is now removed too |
Affected Issues 14999 |
|
| mod - application/core/LSYii_ClientScript.php | Diff File | ||
| mod - application/core/LS_Twig_Extension.php | Diff File | ||
| add - tests/unit/LSYiiClientScriptUnregisterScriptFileTest.php | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-06-24 09:54 | DenisChenu | New Issue | |
| 2019-06-24 09:58 | DenisChenu | Note Added: 52493 | |
| 2025-11-19 18:05 | c_schmitz | Note Added: 83853 | |
| 2025-11-19 18:05 | c_schmitz | Bug heat | 2 => 4 |
| 2025-11-20 08:26 | DenisChenu | Note Added: 83862 | |
| 2025-11-20 08:27 | DenisChenu | Assigned To | => DenisChenu |
| 2025-11-20 08:27 | DenisChenu | Status | new => feedback |
| 2025-11-20 08:27 | DenisChenu | Complete LimeSurvey version number (& build) | 3.17.5 github => 6 |
| 2025-11-20 08:27 | DenisChenu | Note Added: 83863 | |
| 2026-01-12 11:15 | DenisChenu | Note Added: 84082 | |
| 2026-01-12 11:15 | DenisChenu | Assigned To | DenisChenu => c_schmitz |
| 2026-01-12 11:15 | DenisChenu | Note Added: 84083 | |
| 2026-01-12 11:15 | DenisChenu | Status | feedback => assigned |
| 2026-03-20 15:32 | c_schmitz | Note Added: 84501 | |
| 2026-03-20 15:32 | c_schmitz | Assigned To | c_schmitz => DenisChenu |
| 2026-11-01 16:32 | c_schmitz | Changeset attached | => LimeSurvey master 0ceb1cf8 |
| 2026-11-01 16:32 | c_schmitz | Note Added: 87075 | |
| 2026-11-01 16:32 | c_schmitz | Assigned To | DenisChenu => c_schmitz |
| 2026-11-01 16:32 | c_schmitz | Status | assigned => resolved |
| 2026-11-01 16:32 | c_schmitz | Resolution | open => fixed |