View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
06757Bug reportsSurvey takingpublic2013-01-29 02:00
Reporterjweberhofer Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Fixed in Version2.00+ 
Summary06757: Double encoded quotes in hints for "other" selections within multiple choices
Description

When a other-text can be entered for a multiple chioce selection I see the following hints on the screen:


Bitte beantworten Sie diese Frage.
Wenn notwendig, bitte spezifizieren Sie das 'bei jemand anderem und zwar:' Textfeld
Wenn notwendig, bitte spezifizieren Sie das 'bei jemand anderem und zwar:' Textfeld

The ' signs are double-encoded.

TagsNo tags attached.
Attached Files
Bug heat6
Complete LimeSurvey version number (& build)121019
I will donate to the project if issue is resolvedNo
BrowserFirefox 16
Database type & versionMySQL 5.5.25
Server OS (if known)opensuse 12.1
Webserver software & version (if known)Apache/2.2.21
PHP Version5.3.8

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2012-10-23 14:08

developer   ~21559

Carsten : see http://bugs.limesurvey.org/view.php?id=6550#c20726

2 option:

  • don't change code but put information in wiki/glotpress for HTML entity caracter (don't use it, or directly in utf8)
  • see the core code to accept html caracter in string and translation string.

We can update the core, but we can change the translation : http://translate.limesurvey.org/projects/limesurvey2/de/default?filters[term]=Wenn+notwendig&filters[user_login]=&filters[status]=current&filter=Filter&sort[by]=priority&sort[how]=desc

Denis

c_schmitz

c_schmitz

2012-10-24 10:01

administrator   ~21582

Imho it needs a code change but only where the string is actually used.
We should not in general change the core code for translations but only where these special cases are used.

c_schmitz

c_schmitz

2012-10-24 10:02

administrator   ~21583

jweberhofer, can you attach a 1 question sample survey demonstrating the issue, please?

jweberhofer

jweberhofer

2012-10-24 10:29

reporter   ~21584

I've attached a survey. Previewing the question only does not show the hints (bug?), previewing the group does.

DenisChenu

DenisChenu

2012-10-24 10:40

developer   ~21585

Carsten : Maybe is translation string we can have something like that:
"Do someting", but the transataltion di something like that:

"Do 'something'", the we can not know if there are quote/double-quote in the translated string.

Here,think we can use $escapemode = 'unescaped', but i'm afraid of security issue.

c_schmitz

c_schmitz

2012-10-24 12:56

administrator   ~21593

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=9994

jweberhofer

jweberhofer

2012-10-24 13:02

reporter   ~21594

The fourth parameter "double_encode" from htmlspecialchars() might be of interest, too; setting to false, it does no longer double-encode. I don't know the code good enough to know if can might result in a security issue.

c_schmitz

c_schmitz

2012-10-24 14:16

administrator   ~21603

LimeSurvey 2.00+ Build 121024 released. Please update.

DenisChenu

DenisChenu

2013-01-29 02:00

developer   ~23860

Fix committed to 1.92 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=11410

Related Changesets

LimeSurvey: master 914cd39e

2012-10-24 03:11:09

c_schmitz

Details Diff
Fixed issue 06757: Double encoded quotes in hints for "other" selections within multiple choices Affected Issues
06757
mod - application/helpers/expressions/em_manager_helper.php Diff File

LimeSurvey: 1.92 4c2f91c5

2012-12-21 10:06:20

DenisChenu

Details Diff
Fixed issue 06757: Double encoded quotes in hints for "other" selections within multiple choices or single choice Affected Issues
06757
mod - classes/expressions/LimeExpressionManager.php Diff File

Issue History

Date Modified Username Field Change
2012-10-23 12:35 jweberhofer New Issue
2012-10-23 13:06 c_schmitz Assigned To => DenisChenu
2012-10-23 13:06 c_schmitz Status new => assigned
2012-10-23 14:06 DenisChenu Assigned To DenisChenu => c_schmitz
2012-10-23 14:08 DenisChenu Note Added: 21559
2012-10-24 10:01 c_schmitz Note Added: 21582
2012-10-24 10:02 c_schmitz Note Added: 21583
2012-10-24 10:27 jweberhofer File Added: limesurvey_issue_6757.lss
2012-10-24 10:29 jweberhofer Note Added: 21584
2012-10-24 10:40 DenisChenu Note Added: 21585
2012-10-24 12:11 c_schmitz Status assigned => resolved
2012-10-24 12:11 c_schmitz Fixed in Version => 2.00+
2012-10-24 12:11 c_schmitz Resolution open => fixed
2012-10-24 12:56 c_schmitz Changeset attached => LimeSurvey master 914cd39e
2012-10-24 12:56 c_schmitz Note Added: 21593
2012-10-24 13:02 jweberhofer Note Added: 21594
2012-10-24 14:16 c_schmitz Note Added: 21603
2012-10-24 14:16 c_schmitz Status resolved => closed
2013-01-29 02:00 DenisChenu Changeset attached => LimeSurvey 1.92 4c2f91c5
2013-01-29 02:00 DenisChenu Note Added: 23860