View Issue Details

This bug affects 1 person(s).
 14
IDProjectCategoryView StatusLast Update
18648Bug reportsOtherpublic2023-10-16 08:41
Reporter2BITS_PL Assigned Totibor.pacalat  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version5.6.x 
Summary18648: Unable to upload a file with theme animations enabled
Description

The Participant cannot upload files when the Fruity theme is set for the survey with the "Animation Body" feature enabled.

Also confirmed on demo.limesurvey.org (v5.6.6)

Steps To Reproduce

Steps to reproduce

Add a question like "Upload Files" to your survey.
Set Poll Subject: "Fruit"
Go to: "Theme Options" and set "Inherit everything" to No
Go to the "Animations" tab and enable "Animate body" (animation type doesn't matter but I tested on fadeInRight)

Proceed to completing the survey by clicking the Upload file button.

Expected result

It should bring up a modal window with the option to upload a file

Actual result

A modal window opens, but it is under a gray layer and there is no option to add files.

TagsNo tags attached.
Bug heat14
Complete LimeSurvey version number (& build)Version 5.4.11+221114
I will donate to the project if issue is resolvedNo
Browser
Database type & versionSQL Server 2019
Server OS (if known)
Webserver software & version (if known)
PHP Versionv8.0.27 NTS x64

Users monitoring this issue

There are no users monitoring this issue.

Activities

ollehar

ollehar

2023-02-22 12:00

administrator   ~73930

Can you please click F12 in the browser and give us a screenshot of any errors shown in the JavaScript console? Thank you.

2BITS_PL

2BITS_PL

2023-02-22 15:57

reporter   ~73936

I have no JS errors locally. And on the demo it shows something:
https://demo.limesurvey.org/index.php?r=survey/index&sid=254515&newtest=Y&lang=en

If you change the "Animation body" to "No", then it works fine.
https://demo.limesurvey.org/index.php?r=themeOptions/updateSurvey&surveyid=254515

In my opinion, the point is that animated elements in CSS are embedded later. A simple example, with the Animated Body option enabled, open a survey, open the DevToll in it and for the #outerframeContainer element and disable "animation-name", and everything will be back to normal, except that the element will not be animated.

2BITS_PL

2BITS_PL

2023-08-04 14:53

reporter   ~76434

I need information if and when the fix will be deployed.

ollehar

ollehar

2023-08-07 13:36

administrator   ~76453

@tibor.pacalat, if you have time to check later.

tibor.pacalat

tibor.pacalat

2023-08-07 18:11

administrator   ~76465

I can confirm that this is happening.

gabrieljenik

gabrieljenik

2023-08-15 16:28

manager   ~76601

v5: https://github.com/LimeSurvey/LimeSurvey/pull/3356

gabrieljenik

gabrieljenik

2023-08-15 16:28

manager   ~76602

When this is tested, lot of transformations should be tested as to review they are not impacted.

DenisChenu

DenisChenu

2023-09-07 18:28

developer   ~76905

Need the reason why it was added maybe to test ?

default is none

gabrieljenik

gabrieljenik

2023-09-07 18:36

manager   ~76908

Need the reason why it was added maybe to test ?

"None" it was not added, is the new value after update.
Problem was about an overlayer when that setting was different

guest

guest

2023-09-28 14:03

viewer   ~77395

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35557

tibor.pacalat

tibor.pacalat

2023-09-28 14:03

administrator   ~77396

Tested and merged.

gabrieljenik

gabrieljenik

2023-09-28 16:44

manager   ~77409

Does this happen on v6?

tibor.pacalat

tibor.pacalat

2023-09-28 17:09

administrator   ~77412

@gabrieljenik Yes it does. Can we agree on protocol, who should check which versions are affected? It is really bad the way we do it at the moment, reopening closed tickets because this was not checked before handing it further.

gabrieljenik

gabrieljenik

2023-09-28 17:59

manager   ~77420

Can we agree on protocol,

I think the best is that you decide which versions should tickets be applied to. v5, v6, v5+6, ...

It is really bad the way we do it at the moment, reopening closed tickets because this was not checked before handing it further.

Tickets turn to resolved automatically, is not done manually.

tibor.pacalat

tibor.pacalat

2023-09-28 18:04

administrator   ~77423

Ok, I'll try to do that. I usually put tickets to resolved after I merge PRs attached to the ticket in.

gabrieljenik

gabrieljenik

2023-09-28 18:12

manager   ~77425

I usually put tickets to resolved after I merge PRs attached to the ticket in.

OK, then I think we should wait until all versions are good for putting it on resolved.

LimeBot

LimeBot

2023-10-04 11:30

administrator   ~77501

Fixed in Release 5.6.40+231005

gabrieljenik

gabrieljenik

2023-10-05 00:04

manager   ~77513

@tibor.pacalat Does master also requires the fix?

tibor.pacalat

tibor.pacalat

2023-10-05 11:46

administrator   ~77516

@gabrieljenik yes it does.

gabrieljenik

gabrieljenik

2023-10-05 15:49

manager   ~77522

Porting it

gabrieljenik

gabrieljenik

2023-10-11 01:06

manager   ~77616

v5: https://github.com/LimeSurvey/LimeSurvey/pull/3529

guest

guest

2023-10-12 14:15

viewer   ~77661

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35607

guest

guest

2023-10-12 14:15

viewer   ~77662

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35608

tibor.pacalat

tibor.pacalat

2023-10-12 14:16

administrator   ~77663

Tested and merged.

LimeBot

LimeBot

2023-10-16 08:41

administrator   ~77723

Fixed in Release 6.3.0+231016

Related Changesets

LimeSurvey: 5.x 4acd0478

2023-09-28 16:03

Gabriel Jenik

Committer: GitHub


Details Diff
Fixed issue 18648: Unable to upload a file with theme animations enabled (#3356)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>
Affected Issues
18648
mod - themes/survey/fruity/views/subviews/header/custom_header.twig Diff File

LimeSurvey: master 69efa21e

2023-10-12 16:15

Gabriel Jenik

Committer: GitHub


Details Diff
Fixed issue 18648: Unable to upload a file with theme animations enabled (03529) Affected Issues
18648
mod - themes/survey/fruity/views/subviews/header/custom_header.twig Diff File

LimeSurvey: master 69efa21e

2023-10-12 16:15

Gabriel Jenik

Committer: GitHub


Details Diff
Fixed issue 18648: Unable to upload a file with theme animations enabled (03529) Affected Issues
18648
mod - themes/survey/fruity/views/subviews/header/custom_header.twig Diff File

Issue History

Date Modified Username Field Change
2023-02-22 11:57 2BITS_PL New Issue
2023-02-22 12:00 ollehar Note Added: 73930
2023-02-22 12:00 ollehar Bug heat 0 => 2
2023-02-22 15:57 2BITS_PL Note Added: 73936
2023-02-22 15:57 2BITS_PL Bug heat 2 => 4
2023-03-09 14:51 gabrieljenik Status new => acknowledged
2023-03-14 15:25 gabrieljenik Status acknowledged => confirmed
2023-08-04 14:53 2BITS_PL Note Added: 76434
2023-08-07 13:35 ollehar Assigned To => tibor.pacalat
2023-08-07 13:35 ollehar Status confirmed => assigned
2023-08-07 13:36 ollehar Note Added: 76453
2023-08-07 16:58 gabrieljenik Severity block => partial_block
2023-08-07 18:11 tibor.pacalat Status assigned => confirmed
2023-08-07 18:11 tibor.pacalat Note Added: 76465
2023-08-07 18:11 tibor.pacalat Bug heat 4 => 6
2023-08-08 23:53 gabrieljenik Assigned To tibor.pacalat => gabrieljenik
2023-08-15 16:28 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-08-15 16:28 gabrieljenik Status confirmed => ready for code review
2023-08-15 16:28 gabrieljenik Note Added: 76601
2023-08-15 16:28 gabrieljenik Bug heat 6 => 8
2023-08-15 16:28 gabrieljenik Note Added: 76602
2023-09-07 18:28 DenisChenu Assigned To DenisChenu => gabrieljenik
2023-09-07 18:28 DenisChenu Status ready for code review => ready for testing
2023-09-07 18:28 DenisChenu Note Added: 76905
2023-09-07 18:28 DenisChenu Bug heat 8 => 10
2023-09-07 18:36 gabrieljenik Note Added: 76908
2023-09-25 20:17 gabrieljenik Assigned To gabrieljenik => tibor.pacalat
2023-09-25 20:17 gabrieljenik Status ready for testing => ready for merge
2023-09-28 14:03 Changeset attached => LimeSurvey 5.x 4acd0478
2023-09-28 14:03 guest Note Added: 77395
2023-09-28 14:03 guest Bug heat 10 => 12
2023-09-28 14:03 tibor.pacalat Status ready for merge => resolved
2023-09-28 14:03 tibor.pacalat Resolution open => fixed
2023-09-28 14:03 tibor.pacalat Note Added: 77396
2023-09-28 16:44 gabrieljenik Note Added: 77409
2023-09-28 16:45 gabrieljenik Status resolved => feedback
2023-09-28 16:45 gabrieljenik Resolution fixed => reopened
2023-09-28 17:09 tibor.pacalat Note Added: 77412
2023-09-28 17:59 gabrieljenik Note Added: 77420
2023-09-28 18:04 tibor.pacalat Note Added: 77423
2023-09-28 18:12 gabrieljenik Note Added: 77425
2023-10-04 11:30 LimeBot Note Added: 77501
2023-10-04 11:30 LimeBot Status feedback => closed
2023-10-04 11:30 LimeBot Resolution reopened => fixed
2023-10-04 11:30 LimeBot Bug heat 12 => 14
2023-10-05 00:04 gabrieljenik Note Added: 77513
2023-10-05 00:04 gabrieljenik Status closed => feedback
2023-10-05 00:04 gabrieljenik Resolution fixed => reopened
2023-10-05 11:46 tibor.pacalat Note Added: 77516
2023-10-05 11:46 tibor.pacalat Assigned To tibor.pacalat => gabrieljenik
2023-10-05 15:49 gabrieljenik Status feedback => assigned
2023-10-05 15:49 gabrieljenik Note Added: 77522
2023-10-11 01:06 gabrieljenik Status assigned => ready for code review
2023-10-11 01:06 gabrieljenik Note Added: 77616
2023-10-11 01:06 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-10-12 11:11 DenisChenu Assigned To DenisChenu => tibor.pacalat
2023-10-12 11:11 DenisChenu Status ready for code review => ready for testing
2023-10-12 14:15 Changeset attached => LimeSurvey master 69efa21e
2023-10-12 14:15 Changeset attached => LimeSurvey master 69efa21e
2023-10-12 14:15 guest Note Added: 77661
2023-10-12 14:15 guest Note Added: 77662
2023-10-12 14:16 tibor.pacalat Status ready for testing => resolved
2023-10-12 14:16 tibor.pacalat Note Added: 77663
2023-10-16 08:41 LimeBot Note Added: 77723
2023-10-16 08:41 LimeBot Status resolved => closed
2023-10-16 08:41 LimeBot Resolution reopened => fixed