View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
03529Bug reportsSurvey takingpublic2009-09-15 12:30
Reporterjanokary Assigned Tojcleeland  
PrioritynormalSeveritycrash 
Status closedResolutionfixed 
Product Version1.85+ 
Fixed in Version1.85+ 
Summary03529: END URL
Description

I use limesurvey185plus-build7337-20090720
There seams to be a problem* with END URL in the case of Set survey quotas. On the other hand in the normal Exit survey they work fine.

  • the variables simply don't get translate to values.
Additional Information

I made the test in my server using version limesurvey185plus-build7337-20090720

but also in your demo setup
just check this version
there are 2 question
choose option 1 in the first question
it is really self explanatory
http://demo.limesurvey.org/index.php?sid=68818&newtest=Y&lang=en

just choose option 1 in the first question

TagsNo tags attached.
Attached Files
index.7z (780 bytes)
limesurvey_survey_68818_ver2.csv (4,541 bytes)   
# LimeSurvey Survey Dump
# DBVersion 138
# This is a dumped survey from the LimeSurvey Script
# http://www.limesurvey.org/
# Do not change this header!

#
# SURVEYS TABLE
#
"sid","owner_id","admin","active","expires","startdate","adminemail","private","faxto","format","template","language","additional_languages","datestamp","usecookie","notification","allowregister","allowsave","autonumber_start","autoredirect","allowprev","printanswers","ipaddr","refurl","datecreated","publicstatistics","publicgraphs","listpublic","htmlemail","tokenanswerspersistence","assessments","usecaptcha","usetokens","bounce_email","attributedescriptions"
"68818","1","Your Name","Y","","","your@email.org","Y","","S","default","en","","N","N","0","N","Y","6","N","Y","N","N","N","2009-07-31","N","N","N","Y","N","N","D","N","your@email.org",""

#
# GROUPS TABLE
#
"gid","sid","group_name","group_order","description","language"
"3","68818","1","0","1","en"

#
# QUESTIONS TABLE
#
"qid","sid","gid","type","title","question","preg","help","other","mandatory","lid","lid1","question_order","language"
"3","68818","3","!","1","case only one answer\ncase 2 unlimited","","","N","Y","0","0","0","en"
"4","68818","3","X","2","There is no problem with this option\nIf you continue you will get the correct URL\nand the variables translated to the right values.\nGo back and select the first option and see the problem.","","","N","N","0","0","1","en"

#
# ANSWERS TABLE
#
"qid","code","answer","default_value","assessment_value","sortorder","language"
"3","1","This is the Answer where quotas are closed !!!!!!!! ","N","0","1","en"
"3","2","No quotas for this option","N","0","2","en"

#
# CONDITIONS TABLE
#

#
# LABELSETS TABLE
#

#
# LABELS TABLE
#

#
# QUESTION_ATTRIBUTES TABLE
#

#
# ASSESSMENTS TABLE
#

#
# SURVEYS_LANGUAGESETTINGS TABLE
#
"surveyls_survey_id","surveyls_language","surveyls_title","surveyls_description","surveyls_welcometext","surveyls_endtext","surveyls_url","surveyls_urldescription","surveyls_email_invite_subj","surveyls_email_invite","surveyls_email_remind_subj","surveyls_email_remind","surveyls_email_register_subj","surveyls_email_register","surveyls_email_confirm_subj","surveyls_email_confirm","surveyls_dateformat"
"68818","en","END URL","test","","","http://www.mywebsite.com?sid={SID}&savedid={SAVEDID}","http://www.mywebsite.com?sid={SID}&savedid={SAVEDID}","Invitation to participate in survey","Dear {FIRSTNAME},\n\nYou have been invited to participate in a survey.\n\nThe survey is titled:\n""{SURVEYNAME}""\n\n""{SURVEYDESCRIPTION}""\n\nTo participate, please click on the link below.\n\nSincerely,\n\n{ADMINNAME} ({ADMINEMAIL})\n\n----------------------------------------------\nClick here to do the survey:\n{SURVEYURL}","Reminder to participate in survey","Dear {FIRSTNAME},\n\nRecently we invited you to participate in a survey.\n\nWe note that you have not yet completed the survey, and wish to remind you that the survey is still available should you wish to take part.\n\nThe survey is titled:\n""{SURVEYNAME}""\n\n""{SURVEYDESCRIPTION}""\n\nTo participate, please click on the link below.\n\nSincerely,\n\n{ADMINNAME} ({ADMINEMAIL})\n\n----------------------------------------------\nClick here to do the survey:\n{SURVEYURL}","Survey registration confirmation","Dear {FIRSTNAME},\n\nYou, or someone using your email address, have registered to participate in an online survey titled {SURVEYNAME}.\n\nTo complete this survey, click on the following URL:\n\n{SURVEYURL}\n\nIf you have any questions about this survey, or if you did not register to participate and believe this email is in error, please contact {ADMINNAME} at {ADMINEMAIL}.","Confirmation of completed survey","Dear {FIRSTNAME},\n\nThis email is to confirm that you have completed the survey titled {SURVEYNAME} and your response has been saved. Thank you for participating.\n\nIf you have any further questions about this email, please contact {ADMINNAME} at {ADMINEMAIL}.\n\nSincerely,\n\n{ADMINNAME}","1"

#
# QUOTA TABLE
#
"id","sid","name","qlimit","action","active","autoload_url"
"3","68818","one quota","1","2","1","0"

#
# QUOTA_MEMBERS TABLE
#
"id","sid","qid","quota_id","code"
"4","68818","3","3","1"

#
# QUOTA_LANGUAGESETTINGS TABLE
#
"quotals_id","quotals_quota_id","quotals_language","quotals_name","quotals_message","quotals_url","quotals_urldescrip"
"3","3","en","one quota","Sorry your responses have exceeded a quota on this survey.","http://www.publicissue.gr?sid={SID}&token={TOKEN}&savedid={SAVEDID}","rigth click this link"

Bug heat10
Complete LimeSurvey version number (& build)7337
I will donate to the project if issue is resolved
Browserfirefox
Database type & versionall
Server OS (if known)all
Webserver software & version (if known)all
PHP Versionall

Users monitoring this issue

janokary

Activities

user372

2009-07-31 13:56

  ~08998

Last edited: 2009-07-31 13:57

@ janokary: Please attach your sample survey structure to this ticket - Thx!

janokary

janokary

2009-07-31 14:02

reporter   ~08999

@ElMatador69
It is live on your demo server
http://demo.limesurvey.org/admin/admin.php?sid=68818
just click here to see for you own.
http://demo.limesurvey.org/index.php?sid=68818&newtest=Y&lang=en

I also exported it and attached here too as you requested.

Thank you ElMatador69

janokary

janokary

2009-09-07 13:32

reporter   ~09420

I took a look at the code and solved it. Please see the diff file of index.php.

I it is possible, please notify me if you attach the code in the next weekly stable+ release.

Look at the attached file here
http://bugs.limesurvey.org/file_download.php?file_id=2435&type=bug

janokary

janokary

2009-09-07 13:34

reporter   ~09421

Reminder sent to: user372, jcleeland

Please look at the issue. I made some modifications in index.php an now it works

jelo

jelo

2009-09-07 14:33

partner   ~09422

I imported your attached survey.

The defined quota "1" has a limit of 1. But the URL field for this quota is empty.
The quota answer wasn't set either. Since that can be an import problem it would be nice if you try to reproduce this bug with the newest build.

What is the Exit URL for the quota you defined?

janokary

janokary

2009-09-07 15:02

reporter   ~09431

Oh! this is not my survey.
Mine was delete (7z file)
c_schmitz File Deleted: limesurvey_survey_68818.7z

Look at Issue History

I upload it once again here
http://bugs.limesurvey.org/file_download.php?file_id=2437&type=bug

Try it in Version 1.85+ (7561)

You'll have to answer 4 times answer code 1 by changing quota settings

  1. just to rich quota
  2. Quota action Terminate survey
    Autoload no
  3. Quota action Terminate survey
    Autoload Yes
  4. Quota action Terminate survey with warning
    Autoload no
janokary

janokary

2009-09-07 15:06

reporter   ~09435

With the original index.php
the end url:
http://www.publicissue.gr?sid={SID}&token={TOKEN}&savedid={SAVEDID}

variables do not get translate.

But with my modification it works fine.

look also at convertation here
http://www.limesurvey.org/en/support/forums/6-development/28977-end-url.html

jelo

jelo

2009-09-07 15:25

partner   ~09439

I cannot reproduce this error.

At least in Version 1.85+ (7561) it is working fine.

Did you activate the survey before testing? Not all variables are filled when you just test a survey.

janokary

janokary

2009-09-07 15:40

reporter   ~09440

The bug is always reproduced in my case in version 1.85+ (7561)

It only works with my modified index.php

I use PHP: 5.2.9

and firefox 3.5.2

Survey is activated and tokens table is created.
and the survey is switched to close mode.

What is the END URL you see ?

jelo

jelo

2009-09-07 23:27

partner   ~09450

My fault, sorry. Took a bit more time to check again.
I can reproduce the error.

jcleeland

jcleeland

2009-09-08 03:03

reporter   ~09455

Hi everyone,

Just to let you know I'm onto this - Janokary, your modification will addresses and fixes the problem, but I'm just looking for a neater way to do it. When I wrote this function I overlooked adding conversions for these other variables.

Jason

jcleeland

jcleeland

2009-09-08 03:24

reporter   ~09456

Fixed in revision 7598

janokary

janokary

2009-09-08 07:27

reporter   ~09459

Hi jcleeland thank you very much. Surely a more neat fix to the problem is always appreciated. This is indeed only a fix!
Thanks for your time.

Issue History

Date Modified Username Field Change
2009-07-31 13:43 janokary New Issue
2009-07-31 13:43 janokary Status new => assigned
2009-07-31 13:43 janokary Assigned To => user372
2009-07-31 13:43 janokary Build Number => 7337
2009-07-31 13:43 janokary Browser => firefox
2009-07-31 13:43 janokary Database & DB-Version => all
2009-07-31 13:43 janokary Operating System (Server) => all
2009-07-31 13:43 janokary Webserver => all
2009-07-31 13:43 janokary PHP Version => all
2009-07-31 13:56 user372 Note Added: 08998
2009-07-31 13:56 user372 Assigned To user372 => jcleeland
2009-07-31 13:56 user372 Status assigned => feedback
2009-07-31 13:57 user372 Note Edited: 08998
2009-07-31 13:59 janokary File Added: limesurvey_survey_68818.7z
2009-07-31 14:02 janokary Note Added: 08999
2009-08-12 12:45 user372 File Added: limesurvey_survey_68818.csv
2009-08-19 01:23 c_schmitz File Deleted: limesurvey_survey_68818.7z
2009-09-07 13:25 janokary Issue Monitored: janokary
2009-09-07 13:27 janokary File Added: index.7z
2009-09-07 13:32 janokary Note Added: 09420
2009-09-07 13:34 janokary Issue Monitored: user372
2009-09-07 13:34 janokary Note Added: 09421
2009-09-07 14:33 jelo Note Added: 09422
2009-09-07 14:57 janokary File Added: limesurvey_survey_68818_ver2.csv
2009-09-07 15:02 janokary Note Added: 09431
2009-09-07 15:06 janokary Note Added: 09435
2009-09-07 15:25 jelo Note Added: 09439
2009-09-07 15:40 janokary Note Added: 09440
2009-09-07 23:27 jelo Note Added: 09450
2009-09-08 03:03 jcleeland Note Added: 09455
2009-09-08 03:24 jcleeland Note Added: 09456
2009-09-08 03:24 jcleeland Status feedback => resolved
2009-09-08 03:24 jcleeland Fixed in Version => 1.85+
2009-09-08 03:24 jcleeland Resolution open => fixed
2009-09-08 07:27 janokary Note Added: 09459
2009-09-15 12:30 c_schmitz Status resolved => closed
2010-10-25 00:18 c_schmitz Category Survey at Runtime => Survey taking