View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 10
IDProjectCategoryView StatusDate SubmittedLast Update
18602Bug reportsSurvey participants (Tokens)public2023-01-23 13:542023-09-18 09:10
Reportergabrieljenik Assigned Totibor.pacalat  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version5.4.x 
Summary18602: When surveys are copied without copying attachments, attachment info is copied but not updated.
Description

Remove the attachments, but show an additional message in the result screen if that happened.

Steps To Reproduce

Identified while reviewing 18557

TagsNo tags attached.
Bug heat10
Complete LimeSurvey version number (& build)5.4.15+221212
I will donate to the project if issue is resolvedNo
Browser
Database type & versionmariadb 10.5.16
Server OS (if known)Linux Gentoo
Webserver software & version (if known)
PHP Version7.4.33

Relationships

Relationship GraphDependency Graph
related to 18557 closedkfoster Email Template Attachments appear to carry over with copied survey, but do not work 

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2023-01-25 14:02

manager   ~73559

Should we remove the attachments info when not copying resources?

In the image select question, when not copying, the broken link remains.
When linking a file in the welcome message and not copying the message, the broken link remains.
So, should we clear the attachments for emails?

What if we:

  • Add a warning on the email screens saying some attachments are not valid.
  • Highlight or mark the attachments which are not valid.
  • Add a message when copying saying some attachments are not valid anymore as resources where not copied.

As for the possible broken links on image selects or other texts in the survey:

  • Add a message when copying saying some links should be reviewed as resources where not copied.
    (For another ticket).

Still, right now, non valid attachments are not attached, so, keeping the non valid attachments doesn't harm.

Not sure if this is worth of tacling this at this time.
c_schmitz

c_schmitz

2023-01-25 15:13

administrator   ~73562

These suggestions sound fine to me.
gabrieljenik

gabrieljenik

2023-02-06 16:19

manager   ~73703

Waiting for 18557 to be merged before pushing the solution into a PR
https://github.com/LimeSurvey/LimeSurvey/tree/bug/18602--Email-Template-Attachments-appear-to-carry-over-with-copied-survey--but-do-not-work-2
gabrieljenik

gabrieljenik

2023-08-31 20:49

manager   ~76836

v5: https://github.com/LimeSurvey/LimeSurvey/pull/3418
guest

guest

2023-09-04 08:22

viewer   ~76858

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35431
guest

guest

2023-09-04 08:22

viewer   ~76859

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35432
LimeBot

LimeBot

2023-09-04 10:53

administrator   ~76865

Fixed in Release 5.6.37+230905
gabrieljenik

gabrieljenik

2023-09-04 14:52

manager   ~76868

Master is pending
gabrieljenik

gabrieljenik

2023-09-07 19:28

manager   ~76910

Master: https://github.com/LimeSurvey/LimeSurvey/pull/3430
tibor.pacalat

tibor.pacalat

2023-09-13 12:18

administrator   ~76974

Last edited: 2023-09-13 14:12

I confirm that I see the feedback and notifications.

@gabrieljenik there is another issue that I found while I was testing this https://bugs.limesurvey.org/view.php?id=19082, but I don't think it is related.

Screenshot 2023-09-13 at 12.04.30.png (35,396 bytes)   
Screenshot 2023-09-13 at 12.04.30.png (35,396 bytes)   
Screenshot 2023-09-13 at 12.11.31.png (90,389 bytes)   
Screenshot 2023-09-13 at 12.11.31.png (90,389 bytes)   
Screenshot 2023-09-13 at 12.14.23.png (366,662 bytes)
gabrieljenik

gabrieljenik

2023-09-13 16:30

manager   ~77006

@gabrieljenik there is another issue that I found while I was testing this https://bugs.limesurvey.org/view.php?id=19082, but I don't think it is related.

Does it happen without the fix loaded?
tibor.pacalat

tibor.pacalat

2023-09-13 16:33

administrator   ~77007

Yes it does, it is not related, this was more of a - do you agree? ;)
guest

guest

2023-09-13 17:07

viewer   ~77013

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35467
LimeBot

LimeBot

2023-09-18 09:10

administrator   ~77101

Fixed in Release 6.2.7+230918

Related Changesets

LimeSurvey: 5.x 7e6246af

2023-09-04 10:22

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 18602: When surveys are copied without copying attachments, attachment info is copied but not updated (#3418)

* Fixed issue 18602: When surveys are copied without copying attachments, attachment info is copied but not updated

* Fixed issue 18602: When surveys are copied without copying attachments, attachment info is copied but not updated

* Fixed issue 18602: When surveys are copied without copying attachments, attachment info is copied but not updated

---------

Co-authored-by: lapiudevgit <devgit@lapiu.biz>		 Affected Issues
18602
mod - application/controllers/admin/EmailTemplates.php Diff File
mod - application/helpers/admin/import_helper.php Diff File
mod - application/views/admin/emailtemplates/email_language_template_tab.php Diff File
mod - assets/packages/emailtemplates/emailtemplates.js Diff File
mod - assets/packages/emailtemplates/emailtemplates.min.js Diff File

LimeSurvey: 5.x 7e6246af

2023-09-04 10:22

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 18602: When surveys are copied without copying attachments, attachment info is copied but not updated (#3418)

* Fixed issue 18602: When surveys are copied without copying attachments, attachment info is copied but not updated

* Fixed issue 18602: When surveys are copied without copying attachments, attachment info is copied but not updated

* Fixed issue 18602: When surveys are copied without copying attachments, attachment info is copied but not updated

---------

Co-authored-by: lapiudevgit <devgit@lapiu.biz>		 Affected Issues
18602
mod - application/controllers/admin/EmailTemplates.php Diff File
mod - application/helpers/admin/import_helper.php Diff File
mod - application/views/admin/emailtemplates/email_language_template_tab.php Diff File
mod - assets/packages/emailtemplates/emailtemplates.js Diff File
mod - assets/packages/emailtemplates/emailtemplates.min.js Diff File

LimeSurvey: master b938b37e

2023-09-13 18:40

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 18602: When surveys are copied without copying attachments, attachment info is copied but not updated (#3430) Affected Issues
18602
mod - application/controllers/admin/EmailTemplates.php Diff File
mod - application/helpers/admin/import_helper.php Diff File
mod - application/views/admin/emailtemplates/email_language_template_tab.php Diff File
mod - assets/packages/emailtemplates/emailtemplates.js Diff File
add - assets/packages/emailtemplates/emailtemplates.min.js Diff File

Issue History

Date Modified Username Field Change
2023-01-23 13:54 gabrieljenik New Issue
2023-01-23 13:54 gabrieljenik Issue generated from: 18557
2023-01-23 13:54 gabrieljenik Relationship added related to 18557
2023-01-23 13:55 gabrieljenik Assigned To => gabrieljenik
2023-01-23 13:55 gabrieljenik Status new => confirmed
2023-01-25 14:02 gabrieljenik Note Added: 73559
2023-01-25 14:02 gabrieljenik Bug heat 0 => 2
2023-01-25 15:13 c_schmitz Note Added: 73562
2023-01-25 15:13 c_schmitz Bug heat 2 => 4
2023-01-27 13:32 gabrieljenik Status confirmed => assigned
2023-01-27 13:33 gabrieljenik Assigned To gabrieljenik =>
2023-01-27 13:33 gabrieljenik Status assigned => confirmed
2023-01-31 20:08 gabrieljenik Summary Email Template Attachments appear to carry over with copied survey, but do not work => When surveys are copied without copying attachments, attachment info is copied but not updated.
2023-01-31 20:08 gabrieljenik Description Updated
2023-01-31 20:10 gabrieljenik Issue cloned: 18610
2023-01-31 20:14 gabrieljenik Issue cloned: 18611
2023-01-31 20:22 gabrieljenik Issue cloned: 18612
2023-02-06 16:18 gabrieljenik Assigned To => gabrieljenik
2023-02-06 16:18 gabrieljenik Status confirmed => assigned
2023-02-06 16:19 gabrieljenik Note Added: 73703
2023-08-31 20:49 gabrieljenik Note Added: 76836
2023-09-04 08:22 Changeset attached => LimeSurvey 5.x 7e6246af
2023-09-04 08:22 Changeset attached => LimeSurvey 5.x 7e6246af
2023-09-04 08:22 guest Note Added: 76858
2023-09-04 08:22 guest Note Added: 76859
2023-09-04 08:22 guest Bug heat 4 => 6
2023-09-04 08:22 guest Bug heat 4 => 6
2023-09-04 10:53 LimeBot Note Added: 76865
2023-09-04 10:53 LimeBot Status assigned => closed
2023-09-04 10:53 LimeBot Resolution open => fixed
2023-09-04 10:53 LimeBot Bug heat 6 => 8
2023-09-04 14:52 gabrieljenik Status closed => assigned
2023-09-04 14:52 gabrieljenik Note Added: 76868
2023-09-07 19:28 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-09-07 19:28 gabrieljenik Status assigned => ready for code review
2023-09-07 19:28 gabrieljenik Note Added: 76910
2023-09-08 16:01 DenisChenu Assigned To DenisChenu => gabrieljenik
2023-09-08 16:01 DenisChenu Status ready for code review => ready for testing
2023-09-12 13:42 gabrieljenik Assigned To gabrieljenik => tibor.pacalat
2023-09-12 13:42 gabrieljenik Status ready for testing => ready for merge
2023-09-13 12:18 tibor.pacalat Note Added: 76974
2023-09-13 12:18 tibor.pacalat File Added: Screenshot 2023-09-13 at 12.04.30.png
2023-09-13 12:18 tibor.pacalat File Added: Screenshot 2023-09-13 at 12.11.31.png
2023-09-13 12:18 tibor.pacalat File Added: Screenshot 2023-09-13 at 12.14.23.png
2023-09-13 12:18 tibor.pacalat Bug heat 8 => 10
2023-09-13 12:42 tibor.pacalat Note Edited: 76974
2023-09-13 14:12 tibor.pacalat Note Edited: 76974
2023-09-13 16:30 gabrieljenik Note Added: 77006
2023-09-13 16:33 tibor.pacalat Note Added: 77007
2023-09-13 16:41 tibor.pacalat Status ready for merge => resolved
2023-09-13 17:07 Changeset attached => LimeSurvey master b938b37e
2023-09-13 17:07 guest Note Added: 77013
2023-09-18 09:10 LimeBot Note Added: 77101
2023-09-18 09:10 LimeBot Status resolved => closed