View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
17322 | Bug reports | Security | public | 2021-05-25 12:38 | 2022-02-28 12:58 |
Reporter | DenisChenu | Assigned To | pstelling | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.25.20 | ||||
Summary | 17322: Need different time and count for lock out access for token VS admin user | ||||
Description | Since Brute-force attack with tokens to enter survey is possible : https://bugs.limesurvey.org/view.php?id=15239 We use same settings for lock out token and klock out admin. But
| ||||
Steps To Reproduce | ? | ||||
Additional Information | token : bot access : 1 seconds after 3 try is the best | ||||
Tags | No tags attached. | ||||
Bug heat | 286 | ||||
Complete LimeSurvey version number (& build) | 3.27.0 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | not relevant | ||||
Database type & version | not relevant | ||||
Server OS (if known) | not relevant | ||||
Webserver software & version (if known) | not relevant | ||||
PHP Version | not relevant | ||||
related to | 17323 | closed | galads | Feature requests | Captchas have no non-visual alternative |
related to | 17695 | closed | gabrieljenik | Bug reports | Exceeding the number of maximum access code validation attempts |
I can fix it (freely), it's an easy needed fix |
|
A fix for "Brute-force attack with tokens to enter survey" is already provided and there is a delay when the token is entered incorrectly several times. |
|
We use same time for Admin user and token user. BUT : it's a totally different attack. yes : there are a Brute force : but it use the same time and try than admin user. Admin user brute force attack can use
Token user can only be automatic caracters : randomly chooisen Else : the right give are really more dangerous
The 1st issue is to use the same system for a totally different concept. If you can not understand this : i can not explain more. |
|
I understand this absolutely fine but this sounds like a feature request and not a bug. Please create a PR and I will take it up from there |
|
But : this issue was introduced in a https://github.com/LimeSurvey/LimeSurvey/blob/0b24642017090b0a16f867ab7c10c9d73f5629d7/docs/release_notes.txt#L214 in 3.X when new feature is forbidden … then ? Can i fix it for 3.X or not ? |
|
yes, you can. |
|
I'm using 3.x version behind a reverse proxy and behind kubernetes. |
|
Indeed, Denis. HTTP_X_FORWARDED_FOR can be a comma separated list of IPv4 addresses. Maybe I can post a patch on this. Do you accept github Pull requests? More, on this, I would say the IP address can be easily faked with crafted http requests from an attacker. I wouldn't pay so much attention on this. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33284 |
|
Fixed in Release 5.3.0+220228 |
|
LimeSurvey: master 8fdbfdab 2022-02-25 12:42 Committer: GitHub Details Diff |
Fixed issue 17322: [security] Separate settings for administration & participants for handling failed login attempts (#2251) Fixed issue 17322: [security] Separate settings for administration & participants for handling failed login attempts |
Affected Issues 17322 |
|
mod - application/config/config-defaults.php | Diff File | ||
mod - application/config/version.php | Diff File | ||
mod - application/controllers/admin/Authentication.php | Diff File | ||
mod - application/controllers/admin/GlobalSettings.php | Diff File | ||
mod - application/controllers/survey/index.php | Diff File | ||
mod - application/core/LSUserIdentity.php | Diff File | ||
mod - application/helpers/frontend_helper.php | Diff File | ||
add - application/helpers/update/updates/Update_481.php | Diff File | ||
mod - application/models/FailedLoginAttempt.php | Diff File | ||
mod - application/views/admin/globalsettings/_security.php | Diff File | ||
mod - installer/create-database.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2021-05-25 12:38 | DenisChenu | New Issue | |
2021-05-25 12:38 | DenisChenu | Note Added: 64532 | |
2021-05-25 13:50 | DenisChenu | Relationship added | related to 17323 |
2021-06-18 10:31 | galads | Note Added: 64951 | |
2021-06-18 10:32 | galads | Assigned To | => galads |
2021-06-18 10:32 | galads | Status | new => feedback |
2021-06-18 10:55 | DenisChenu | Note Added: 64952 | |
2021-06-18 10:55 | DenisChenu | Status | feedback => assigned |
2021-06-22 16:07 | galads | Note Added: 64979 | |
2021-06-22 16:08 | galads | Assigned To | galads => DenisChenu |
2021-06-22 16:08 | galads | Status | assigned => feedback |
2021-06-22 16:08 | galads | Status | feedback => assigned |
2021-06-22 16:23 | DenisChenu | Note Added: 64981 | |
2021-07-12 11:56 | c_schmitz | Note Added: 65371 | |
2021-07-12 12:41 | galads | Status | assigned => confirmed |
2021-07-12 12:41 | galads | Status | confirmed => assigned |
2021-11-04 10:45 | DenisChenu | Relationship added | related to 17695 |
2021-11-10 07:59 | c_schmitz | Bug heat | 266 => 272 |
2022-02-17 11:20 | DenisChenu | Assigned To | DenisChenu => pstelling |
2022-02-18 14:52 | tassoman | Note Added: 68325 | |
2022-02-18 14:52 | tassoman | Bug heat | 272 => 274 |
2022-02-18 14:55 | tassoman | Issue Monitored: tassoman | |
2022-02-18 14:55 | tassoman | Bug heat | 274 => 276 |
2022-02-18 17:14 | DenisChenu | Bug heat | 276 => 282 |
2022-02-18 17:16 | DenisChenu | Note Added: 68327 | |
2022-02-18 17:23 | tassoman | Note Added: 68329 | |
2022-02-25 11:50 | pstelling | Changeset attached | => LimeSurvey master 8fdbfdab |
2022-02-25 11:50 | pstelling | Note Added: 68409 | |
2022-02-25 11:50 | pstelling | Bug heat | 282 => 284 |
2022-02-25 11:50 | pstelling | Resolution | open => fixed |
2022-02-28 12:58 | LimeBot | Note Added: 68432 | |
2022-02-28 12:58 | LimeBot | Status | assigned => closed |
2022-02-28 12:58 | LimeBot | Bug heat | 284 => 286 |