16834: When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

16834	Bug reports	Theme editor	public	2020-11-16 17:23	2022-07-05 19:47

Reporter	gabrieljenik	Assigned To	gabrieljenik
Priority	low	Severity	partial_block
Status	closed	Resolution	fixed
Product Version	4.3.27

Summary	16834: When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error
Description	Clone of 16733, which was for LTS. This is for master When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error Instead of getting a "File to Big error", we got a CRSF token error. Very missleading
Tags	No tags attached.

Bug heat	2
Complete LimeSurvey version number (& build)	4.3.27
I will donate to the project if issue is resolved	No
Browser
Database type & version	Mysql
Server OS (if known)
Webserver software & version (if known)
PHP Version	7

User List	There are no users monitoring this issue.

gabrieljenik 2021-04-29 14:54 manager ~64188	Created UploadValidator service helper. Fix applied to: Theme import (Themes list and Theme editor) File upload in Theme editor (uploading files to a theme) Image upload (in global theme options) Image upload (in survey theme options CPDB (Import CSV) Labelset import Token import Question import (had to add 'action' and 'sid' to the URL) There are few which could be pending These are pending to be fixed: UploaderController questiongroups surveyadmin - Import survey - Need to split the method (used for copy and import), or move the 'action' to the URL. frontend_helper, checkUploadedFileValidity ? dataentry - Import VV file (need to split the method or assume an upload action when the request is POST)

gabrieljenik 2021-05-20 17:53 manager ~64492	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31805

gabrieljenik 2021-05-21 10:29 manager ~64497	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31810

gabrieljenik 2021-06-10 11:45 manager ~64826	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=32014

gabrieljenik 2022-07-05 19:47 manager ~70754	Has been merged.

LimeSurvey: master 6cefba87 2021-05-20 19:53 gabrieljenik Committer: GitHub Details Diff	Fixed issue 16834: When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error (#1861) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>	Affected Issues 16834
	mod - application/controllers/QuestionAdministrationController.php	Diff File
	mod - application/controllers/SurveyAdministrationController.php	Diff File
	mod - application/controllers/admin/labels.php	Diff File
	mod - application/controllers/admin/participantsaction.php	Diff File
	mod - application/controllers/admin/themes.php	Diff File
	mod - application/controllers/admin/tokens.php	Diff File
	add - application/models/services/UploadValidator.php	Diff File
LimeSurvey: master 8b115841 2021-05-20 19:53 gabrieljenik Committer: ollehar Details Diff	Fixed issue 16834: When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error (#1861) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>	Affected Issues 16834
	mod - application/controllers/QuestionAdministrationController.php	Diff File
	mod - application/controllers/SurveyAdministrationController.php	Diff File
	mod - application/controllers/admin/labels.php	Diff File
	mod - application/controllers/admin/participantsaction.php	Diff File
	mod - application/controllers/admin/themes.php	Diff File
	mod - application/controllers/admin/tokens.php	Diff File
	add - application/models/services/UploadValidator.php	Diff File
LimeSurvey: master 6e0fb280 2021-05-20 19:53 gabrieljenik Committer: ollehar Details Diff	Fixed issue 16834: When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error (#1861) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>	Affected Issues 16834
	mod - application/controllers/QuestionAdministrationController.php	Diff File
	mod - application/controllers/SurveyAdministrationController.php	Diff File
	mod - application/controllers/admin/labels.php	Diff File
	mod - application/controllers/admin/participantsaction.php	Diff File
	mod - application/controllers/admin/themes.php	Diff File
	mod - application/controllers/admin/tokens.php	Diff File
	add - application/models/services/UploadValidator.php	Diff File

Date Modified	Username	Field	Change
2020-11-16 17:23	gabrieljenik	New Issue
2020-11-16 17:23	gabrieljenik	Status	new => assigned
2020-11-16 17:23	gabrieljenik	Assigned To	=> gabrieljenik
2020-11-16 17:23	gabrieljenik	Issue generated from: 16733
2020-11-16 17:23	gabrieljenik	Relationship added	related to 16733
2021-03-10 21:07	ollehar	Priority	none => low
2021-04-29 14:54	gabrieljenik	Note Added: 64188
2021-04-29 14:54	gabrieljenik	Status	assigned => ready for code review
2021-05-20 17:53	gabrieljenik	Changeset attached	=> LimeSurvey master 6cefba87
2021-05-20 17:53	gabrieljenik	Note Added: 64492
2021-05-20 17:53	gabrieljenik	Resolution	open => fixed
2021-05-21 10:29	ollehar	Changeset attached	=> LimeSurvey master 8b115841
2021-05-21 10:29	gabrieljenik	Note Added: 64497
2021-06-10 11:45	ollehar	Changeset attached	=> LimeSurvey master 6e0fb280
2021-06-10 11:45	gabrieljenik	Note Added: 64826
2022-07-05 19:47	gabrieljenik	Status	ready for code review => closed
2022-07-05 19:47	gabrieljenik	Note Added: 70754

View Issue Details

Relationships

Users monitoring this issue

Activities

Related Changesets

Issue History