View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
16733 | Bug reports | Theme editor | public | 2020-10-13 01:49 | 2021-01-28 21:52 |
Reporter | gabrieljenik | Assigned To | gabrieljenik | ||
Priority | none | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.24.0 | ||||
Summary | 16733: When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error | ||||
Description | When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error | ||||
Tags | No tags attached. | ||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | 3.24.0 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | Mysql | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | 7 | ||||
related to | 16834 | closed | gabrieljenik | When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error |
related to | 17026 | closed | gabrieljenik | Custom themes not uploading files |
We have some checker in Upload Question tye : maybe we can create an helper or an extension ? |
|
Sure, that's good idea. |
|
If you found time ;) |
|
I think this is failing as well on the Token CSV import |
|
I think it's failling as well onn VVimport :) |
|
Fix applied to: Theme import (Themes list and Theme editor) These are fixed and pendign to be applied: CPDB (Import CSV) UploaderController https://github.com/LimeSurvey/LimeSurvey/pull/1633 See comments on github. |
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30710 |
|
Fixed in Release 3.25.0+201117 |
|
Reopening for applying the patch on the other uploads, now that the main part has been merged |
|
Now applying the patch to:
PR: https://github.com/LimeSurvey/LimeSurvey/pull/1658 We should port this to LS4 after. Right? |
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30771 |
|
Fixed in Release 3.25.3+201208 |
|
This breaks the file upload on themes. Cannot upload files anymore. |
|
I think it was there all time, since long time ago. |
|
ok, determined the issue existed before. Closing again. |
|
LimeSurvey: 3.x-LTS eef20220 2020-11-10 11:41 Committer: GitHub Details Diff |
Bug/16733 when importing a theme bigger in size than the allowed php.ini settings, there is no proper description of the error (#1633) * Fixed issue 16733: When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error Adding helper functions for checking uploads filesize * Fixed issue 16733: When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error Applying fix on - Theme import (Themes list and Theme editor) - File upload in Theme editor (uploading files to a theme) - Image upload (in global theme options) - Image upload (in survey theme options * Fixed issue 16733: When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error Creating Uploadhelper and moving helper functions to class methods. |
Affected Issues 16733 |
|
mod - application/controllers/admin/surveyadmin.php | Diff File | ||
mod - application/controllers/admin/themes.php | Diff File | ||
add - application/core/LSUploadHelper.php | Diff File | ||
mod - application/views/admin/themeoptions/import_modal.php | Diff File | ||
mod - application/views/admin/themeoptions/update.php | Diff File | ||
mod - application/views/admin/themes/importform_view.php | Diff File | ||
mod - themes/survey/bootswatch/options/options.twig | Diff File | ||
mod - themes/survey/fruity/options/options.twig | Diff File | ||
mod - themes/survey/vanilla/options/options.twig | Diff File | ||
LimeSurvey: 3.x-LTS 5961c2e5 2020-12-07 11:20 Committer: GitHub Details Diff |
Fixed issue 16733: When importing a theme bigger in size than the allowed php.ini settings, there is no proper description of the error (#1658) * Fixed issue 16733: When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error Patching on the CPDB (Import CSV) * Fixed issue 16733: When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error Patching on the token upload * Fixed issue 16733: When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error Patching on the question import * Fixed issue 16733: When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error Patching on the labels import |
Affected Issues 16733 |
|
mod - application/controllers/admin/labels.php | Diff File | ||
mod - application/controllers/admin/participantsaction.php | Diff File | ||
mod - application/controllers/admin/questions.php | Diff File | ||
mod - application/controllers/admin/tokens.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-10-13 01:49 | gabrieljenik | New Issue | |
2020-10-13 11:40 | DenisChenu | Note Added: 60169 | |
2020-10-13 16:45 | gabrieljenik | Note Added: 60174 | |
2020-10-13 16:57 | DenisChenu | Note Added: 60175 | |
2020-10-13 17:01 | cdorin | Assigned To | => gabrieljenik |
2020-10-13 17:01 | cdorin | Status | new => assigned |
2020-10-16 16:19 | gabrieljenik | Note Added: 60233 | |
2020-10-16 16:47 | DenisChenu | Note Added: 60234 | |
2020-10-23 14:56 | gabrieljenik | Note Added: 60390 | |
2020-11-10 10:41 | gabrieljenik | Changeset attached | => LimeSurvey 3.x-LTS eef20220 |
2020-11-10 10:41 | gabrieljenik | Note Added: 60598 | |
2020-11-10 10:41 | gabrieljenik | Resolution | open => fixed |
2020-11-16 09:31 | lime_release_bot | Note Added: 60649 | |
2020-11-16 09:31 | lime_release_bot | Status | assigned => closed |
2020-11-16 17:17 | gabrieljenik | Status | closed => feedback |
2020-11-16 17:17 | gabrieljenik | Resolution | fixed => reopened |
2020-11-16 17:17 | gabrieljenik | Note Added: 60670 | |
2020-11-16 17:21 | gabrieljenik | Note Added: 60671 | |
2020-11-16 17:23 | gabrieljenik | Issue cloned: 16834 | |
2020-11-16 17:23 | gabrieljenik | Relationship added | related to 16834 |
2020-12-07 10:21 | gabrieljenik | Changeset attached | => LimeSurvey 3.x-LTS 5961c2e5 |
2020-12-07 10:21 | gabrieljenik | Note Added: 60845 | |
2020-12-07 10:21 | gabrieljenik | Resolution | reopened => fixed |
2020-12-07 11:36 | lime_release_bot | Note Added: 60854 | |
2020-12-07 11:36 | lime_release_bot | Status | feedback => closed |
2021-01-06 14:57 | c_schmitz | Status | closed => feedback |
2021-01-06 14:57 | c_schmitz | Resolution | fixed => reopened |
2021-01-06 14:57 | c_schmitz | Note Added: 61443 | |
2021-01-06 15:37 | gabrieljenik | Issue cloned: 16948 | |
2021-01-06 15:37 | gabrieljenik | Note Added: 61444 | |
2021-01-06 15:41 | c_schmitz | Status | feedback => resolved |
2021-01-06 15:41 | c_schmitz | Resolution | reopened => fixed |
2021-01-06 15:41 | c_schmitz | Status | resolved => closed |
2021-01-06 15:41 | c_schmitz | Note Added: 61445 | |
2021-01-28 21:52 | gabrieljenik | Issue cloned: 17026 | |
2021-01-28 21:52 | gabrieljenik | Relationship added | related to 17026 |