View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
09430Bug reportsPluginspublic2015-02-11 15:57
Reporteraesteban Assigned Toaesteban  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05+ 
Target Version2.05+ 
Summary09430: AuditLog: Password logged as modified every time an user is modified
Description

When modifying an user, password is logged as modified even if it wasn't.

Steps To Reproduce

1.- Enable AuditLog
2.- Modify Full Name of existing user (don't modify password)

Result: New entry in AuditLog DB table who logs password and full name as modified fields.

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)34b9f3e408d90c28e59c9ad0b668
I will donate to the project if issue is resolvedNo
BrowserFirefox
Database type & versionPostgresql 9.3
Server OS (if known)Ubuntu 14.04
Webserver software & version (if known)Nginx 1.4.6
PHP Version5.5.9

Users monitoring this issue

There are no users monitoring this issue.

Activities

aesteban

aesteban

2014-12-29 19:44

developer   ~31388

This is a Postgresql specific error. Bytea BD type is loaded as stream in Postgres instead of string. Due to that comparison

($aNewValues['password']!=$aOldValues['password'])

is always false because types are not the same.

aesteban

aesteban

2014-12-29 20:26

developer   ~31389

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14808

aesteban

aesteban

2014-12-29 20:30

developer   ~31390

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14809

c_schmitz

c_schmitz

2015-02-11 15:57

administrator   ~31678

Version 2.05 Build 150211 released

Related Changesets

LimeSurvey: master 25c0231c

2014-12-29 20:25

aesteban


Details Diff
Fixed issue 09430: AuditLog: Password logged as modified every time an user is modified
Dev: Before, fake hashes were saved. After this patch, we save a descriptive message
Affected Issues
09430
mod - plugins/AuditLog/AuditLog.php Diff File

LimeSurvey: 2.06 deb9f25b

2014-12-29 20:25

aesteban


Details Diff
Fixed issue 09430: AuditLog: Password logged as modified every time an user is modified
Dev: Before, fake hashes were saved. After this patch, we save a descriptive message
Affected Issues
09430
mod - plugins/AuditLog/AuditLog.php Diff File

Issue History

Date Modified Username Field Change
2014-12-28 16:48 aesteban New Issue
2014-12-28 16:48 aesteban Status new => assigned
2014-12-28 16:48 aesteban Assigned To => aesteban
2014-12-29 19:44 aesteban Note Added: 31388
2014-12-29 20:26 aesteban Changeset attached => LimeSurvey master 25c0231c
2014-12-29 20:26 aesteban Note Added: 31389
2014-12-29 20:26 aesteban Resolution open => fixed
2014-12-29 20:27 aesteban Status assigned => resolved
2014-12-29 20:30 aesteban Changeset attached => LimeSurvey 2.06 deb9f25b
2014-12-29 20:30 aesteban Note Added: 31390
2015-02-11 15:57 c_schmitz Note Added: 31678
2015-02-11 15:57 c_schmitz Status resolved => closed