View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
09398Feature requestsImport/Exportpublic2015-10-09 13:56
Reportertammo Assigned Tomdekker  
PrioritynormalSeverityfeature 
Status closedResolutionfixed 
Summary09398: SPSS output error
Description

When outputting an SPSS data set (syntax and datafile) a variable that shows the last page the user was on, is omitted.

In de syntax (on a survey with no extra attributes in the token table) it is V13 which is missing in the syntax (V12 and V14 are present, V13 is not) and in the data file.

Additional Information

GET DATA
/TYPE=TXT
/FILE='survey_742376_SPSS_data_file.dat'
/DELCASE=LINE
/DELIMITERS=","
/QUALIFIER="'"
/ARRANGEMENT=DELIMITED
/FIRSTCASE=1
/IMPORTCASE=ALL
/VARIABLES=
V1 A100
V2 A100
V3 A100
V4 A100
V5 A100
V6 A100
V7 A100
V8 A100
V9 A100
V10 A7
V11 A16
V12 DATETIME23.2 (after this V13 is missing!)
V14 A94
V15 DATETIME23.2
V16 DATETIME23.2
V17 A15
V18 A2
V19 A3
V20 A1
V21 A1
V22 A370
V23 A2
V24 A2
V25 F1.0
V26 F13.12

TagsNo tags attached.
Bug heat10
Story point estimate
Users affected %

Users monitoring this issue

JanE

Activities

JanE

JanE

2014-12-10 15:59

reporter   ~31237

I have created a pull request to include the lastpage in the export:
https://github.com/LimeSurvey/LimeSurvey/pull/257

tammo

tammo

2014-12-11 15:08

partner   ~31240

As it turned out, in the 2.05 (and also in earlier versions, like 1.92) the lastpage variable was not outputted to SPSS syntax and SPSS data. Our solution was to patch the Limesurvey export.php, so it is in the normal SPSS output now.

mdekker

mdekker

2014-12-15 13:07

reporter   ~31252

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14738

tammo

tammo

2015-08-05 08:11

partner   ~32881

Please close this bug report, since it was solved.

Mazi

Mazi

2015-10-09 13:39

updater   ~33325

Tammo, so you are saying that the fix applied by Menno fixed this problem (which is also mentioned at https://www.limesurvey.org/en/forum/can-i-do-this-with-limesurvey/100598-error-in-spss-export-text-fields?start=15#126962)?!

tammo

tammo

2015-10-09 13:43

partner   ~33326

This is a different fix. This one only addresses the missing V13. It was committed and merged.

The other one addressed many other things, and was never committed. But probably a developer put things right again, since all errors I found in LS disappeared after updating. So the other pull request may not be necessary anymore; I don't know if it contains information that is of use for developers.

tammo

tammo

2015-10-09 13:45

partner   ~33327

Apologies, the other fix was committed and a pull request was made, but it never got merged, due to us not being able to test with Stata.

Side note: outputting to several different platform will make testing very difficult, bevause not many people will have a good overview on all platforms.

Mazi

Mazi

2015-10-09 13:49

updater   ~33328

Thanks for your feedback. I suggest to:

  1. Close this one.

  2. Add a note to your pull request that the issues mentioned should be fixed at LS 2.06.

What do you think?

tammo

tammo

2015-10-09 13:52

partner   ~33329

"should be fixed" meaning: 1. "are probably fixed" or 2. "will still need to be fixed"?

But definitely; this one should be closed (meaning: please close it, since a reporter cannot do that)

;-)

Related Changesets

LimeSurvey: master 045fc8fa

2014-12-15 12:07:40

mdekker

Details Diff
Merge pull request #257 from Jan-E/master

Fixed 09398 - Include lastpage in export
Affected Issues
09398
mod - application/helpers/export_helper.php Diff File

Issue History

Date Modified Username Field Change
2014-12-10 14:32 tammo New Issue
2014-12-10 15:58 JanE Issue Monitored: JanE
2014-12-10 15:59 JanE Note Added: 31237
2014-12-11 15:08 tammo Note Added: 31240
2014-12-15 13:07 mdekker Changeset attached => LimeSurvey master 045fc8fa
2014-12-15 13:07 mdekker Note Added: 31252
2014-12-15 13:07 mdekker Assigned To => mdekker
2014-12-15 13:07 mdekker Resolution open => fixed
2015-08-05 08:11 tammo Note Added: 32881
2015-10-09 13:39 Mazi Note Added: 33325
2015-10-09 13:39 Mazi Status new => feedback
2015-10-09 13:43 tammo Note Added: 33326
2015-10-09 13:43 tammo Status feedback => assigned
2015-10-09 13:45 tammo Note Added: 33327
2015-10-09 13:49 Mazi Note Added: 33328
2015-10-09 13:52 tammo Note Added: 33329
2015-10-09 13:56 Mazi Status assigned => closed
2015-10-09 13:56 Mazi Fixed in Version => 2.05+
2021-08-03 05:44 guest Bug heat 8 => 10