View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 10
IDProjectCategoryView StatusDate SubmittedLast Update
09346Bug reportsSurvey participants (Tokens)public2014-11-03 07:552014-11-05 09:53
ReporterSchulenLDK Assigned ToMazi  
PriorityimmediateSeveritypartial_block 
Status closedResolutionno change required 
Product Version2.05+ 
Summary09346: Access tokens aren't case sensitiv
Description

When you declare some access tokens with upper and lower letters these aren't case sensitive by limesurvey. When you have the token System01 you can login with token SYSTEM01 or system01 or SyStem01 and so on.

TagsNo tags attached.
Bug heat10
Complete LimeSurvey version number (& build)140911
I will donate to the project if issue is resolvedNo
BrowserFirefox 31.1.2 ESR
Database type & versionMySQL 5.6.12
Server OS (if known)OpenSuse 13.1
Webserver software & version (if known)Apache 2.4.6
PHP Version5.4.20

Users monitoring this issue

SchulenLDK

Activities

gabrieljenik

gabrieljenik

2014-11-04 22:30

manager   ~30910

Case sensitive search option depends on the collation.
In orer for not to mess with DB options, a manual PHP compare should be done after finding the record.

Don't know how to assign this to my self.
gabrieljenik

gabrieljenik

2014-11-04 22:42

manager   ~30911

Fix Commit: https://github.com/LimeSurvey/LimeSurvey/commit/ee9d006a61163525c37101b77b8ec303813e9b42

Pull Request: https://github.com/LimeSurvey/LimeSurvey/pull/230
sammousa

sammousa

2014-11-05 08:29

reporter   ~30913

Do we even want this?

This breaks backwards compatibility and does not really add anything since the number of token strings is unlimited for all practical purposes.

Also if we want it to be case sensitive, we should just change the collation of the tables instead of doing another check in PHP. Doing a part of the query in PHP is not good design in my opinion.
DenisChenu

DenisChenu

2014-11-05 08:37

developer   ~30914

<q> Do we even want this?</q>Yep, still the question :)
c_schmitz

c_schmitz

2014-11-05 09:48

administrator   ~30915

While the approach used by gabrieljenik is a smart one (because we are cross-DB) I think we should not fix this for the reasons sammousa mentioned.

gabrieljenik, I am sorry for the confusion - still thank you very much for the contribution.

Issue History

Date Modified Username Field Change
2014-11-03 07:55 SchulenLDK New Issue
2014-11-03 07:55 SchulenLDK Issue Monitored: SchulenLDK
2014-11-04 22:30 gabrieljenik Note Added: 30910
2014-11-04 22:42 gabrieljenik Note Added: 30911
2014-11-05 08:29 sammousa Note Added: 30913
2014-11-05 08:37 DenisChenu Note Added: 30914
2014-11-05 09:48 c_schmitz Note Added: 30915
2014-11-05 09:52 Mazi Status new => closed
2014-11-05 09:53 Mazi Assigned To => Mazi
2014-11-05 09:53 Mazi Resolution open => no change required
2016-12-08 10:39 c_schmitz Category Tokens => Survey participants (Tokens)
2021-08-17 05:01 guest Bug heat 8 => 10