I will review this!.

@gabrieljenik : it's a conceptual issue, we have to make choice :)

OK, I release this then... I shall assign it to you?

Hi, Can not be in dev meeting today. But i don't know if we fix ir or not. If you have another idea ? It can be really great !

PS: 2.06, not 2.05

@gabrieljenik : sorry : take it, i made an error on bug number ... We need to fix it :)

OK, I got the issue.

What if we add some rules to the JS in order for not to store numbers with more than 20 characters before the decimal separator and no more than 10 after the decimal separator?

On the other hand,

• add a validation for not lettning admins setting max characters larger than 30 for numerical inputs?
• add a warning in the manual?

An issue could arise if the value is generated as a calculation from an equation question. I don't know what we can do in those situations. If the number to be stored has more than 20 characters before the decimal point, we are not going to be able to store that number in the DB. We have reached the limit. How shall we handle it?

A JS solution is not the only ne to do. But it's a good starting point

Fixing 2.05 in survey-runtime : https://github.com/LimeSurvey/LimeSurvey/blob/master/scripts/survey_runtime.js#L173 seems OK for me.

Not sure if this is going to be enough...

Master >> https://github.com/LimeSurvey/LimeSurvey/pull/268
v2.06 >> https://github.com/LimeSurvey/LimeSurvey/pull/269

Let me know what you think. This issue is not pulling out as easy as other fixes. :)

Shall I

• add a validation for not letting admins setting max characters larger than 30 for numerical inputs?
• add a warning in the manual?

Seems OK for me, a war,ig in manual is OK too.
max characters < 31 (with the dot) can be done only in 2.1, when we move Question advanced settings in SettingsWidget i think (same for max value and min value)

The beaviour when setting "numbers_only = T" for equation question types would be included the fix I made? I believe the JS function is not called for equation question types.

What do you think?

@gabiel : not the same : Equation question type are allways text in DB :).

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15008

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15013

Actually resolved for bug. But think we need rework on EM too (use new is_decimal function ? What for short_text/only number ? etc ...)

2.05+ Build 150508 released