Ported what's there. Does not work completely yet mainly due to missing parts if non-anonymous tokens are activated.

Carsten, you surely have a test survey for the non-anonymous tokens? Can you please upload it so we can do further testing?

Thanks!

Attached.

Carsten, if I remember correctly you had fixed the issue with non-anonymous surveys right away, so can we close this one?

No, it is not fixed. As said the treatment of token fields is completely missing, even in the original patch - it needs to be coded.

First part : fix the XSS and add complete answer : https://github.com/Shnoulle/LimeSurvey-shnoulle/commit/a499de8a5362205cb2ab6593c86a231362ac9247

And really better CSS too

https://github.com/LimeSurvey/LimeSurvey/pull/224

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14638

This don't fix XSS ( and still a really broken CSS)

In getJson :
Undefined variable: limit (..../limesurvey_GIT/206/application/controllers/admin/responses.php:558)
Undefined variable: tokenRequest (..../limesurvey_GIT/206/application/controllers/admin/responses.php:567
Undefined variable: order (..../limesurvey_GIT/206/application/controllers/admin/responses.php:571)

But more filter : show 50 response, and search is apply only on this 50 response ....

You need to request the json each time the user make a search ....

Hi Denis,

can you try to merge your XSS fixes?

@search limit: Do you mean that when switching the drop down for the number of to be listed answers a new query needs to be made?
Because as I see it no action is performed when changing the value at the drop down from e.g. default 25 to 100.
Or is this because my test survey has less than 25 data sets?

Yes, it's because your test survey is less to 25 : Add 25 answers , you see only page 1/1 : see :

• https://github.com/LimeSurvey/LimeSurvey/pull/224/files#diff-60a24a020d02e627a3c40bd63376f0c7L119 : with loadonce : you don't search again the table when update.
• Tiy need to return the complete count and page : https://github.com/LimeSurvey/LimeSurvey/pull/224/files#diff-15547196721577f485345c4a68f0c5d0R512 with the jqgrid documentation : http://www.trirand.com/jqgridwiki/doku.php?id=wiki:retrieving_data#json_data

OK, i review CSS and JS for XSS and better display.

PS: just take the XSS (bug 09260 http://bugs.limesurvey.org/view.php?id=9260)

Fixed the jqgrid with ajax part : sort and filter .

But :

• Need to fix the upload question type
• Need to filter by token firstname/lastname (maybe adding attribute)
• Fix the order type for some question type
• Add the startdate lastpage etc ....

Denis, can we close this one?

• Need to fix the upload question type
• Need to filter by token firstname/lastname (maybe adding attribute)
• Fix the order type for some question type
• Add the startdate lastpage etc ....

• In 2.05 : we have startdate/lastpage. Not in 2.06
• Upload question type are not done: did we need it like before ? Or not ? But we need to allow download single file somewhere.

2 other are more feature request

Unless these issues are not resolved a 2.06 makes no sense, IMHO.

Another fix to do : Delete response line is not possible actually.

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14974

Not directly related

startdate/ lastoage etc... fixed
token(s) : fixed
TODO : upload question type

Leave the "advanced search" for GSOC https://manual.limesurvey.org/Project_ideas_for_GSoC_2015#Revamp_database_grids_in_LimeSurvey

2.05 same system is done except for http://bugs.limesurvey.org/view.php?id=9545

@MAzi : yesterday pradesh contact me by IRC, saying there are "just" the upload file system. He do this one ? (the upload question type). And make a real non broken system ?