View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
09066 | Feature requests | Plugins | public | 2014-06-04 11:58 | 2015-08-21 15:51 |
Reporter | DenisChenu | Assigned To | DenisChenu | ||
Priority | normal | Severity | @50@ | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.05+ | ||||
Fixed in Version | 2.05+ | ||||
Summary | 09066: afterSurveyComplete aren't call from Quota | ||||
Description | Quota don't send afterSurveyComplete plugin event | ||||
Steps To Reproduce | Activate a plugin using afterSurveyComplete (demo plugin is OK). | ||||
Additional Information | Not sure we need exactly same event, but a new set 'quota'/'completed' seems good. | ||||
Tags | No tags attached. | ||||
Bug heat | 6 | ||||
Story point estimate | |||||
Users affected % | |||||
Well, a survey is not complete if a quota is fulfilled. So a new event is needed. |
|
This quota system need some rewrite, and move to a specific controllers and/or helpers. Did a core system (not a plugin) can use plugin event ? Here : we can use beforeSurveyPage (i think) for test quota/set token to Q/ show the page to the user. |
|
I found an error with quota: i added the same question with multiple answers example: register for event 1) morning, 2) afternoon, 3) all day These two should be merged into one, preferrably on one of the models (survey or quota, i don't really care) |
|
(No time to investigate further, and no git at hand... this is my edited common_helper: /**
|
|
Seems beter here, and surely rigth ... not same function for same behaviour ... :) |
|
Rewriting checkQuota, using getQuotaCompletedCount then we can update getQuotaCompletedCount with better count @mdekker : You can report the second problem with quota on multi question type ? |
|
@mdekker : with some inspiration from your fix : http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14308 Some other thing to do in quota |
|
Documentation :http://manual.limesurvey.org/AfterSurveyQuota |
|
LimeSurvey: master 0bbcb174 2014-07-02 18:34 Details Diff |
Fixed issue 09127: Invalid quota broke quota view Fixed issue : Miscalculation of completed quota for Multi Question type Dev: see :http://bugs.limesurvey.org/view.php?id=9066#c30080 for miscalculation Dev: Todo : use getQuotaCompletedCount in checkQuota function Dev: Todo remove quota members when removing a sub question, but allways need a fix for old survey |
Affected Issues 09066, 09127 |
|
mod - application/helpers/common_helper.php | Diff File | ||
LimeSurvey: master 53503581 2014-07-05 17:03 Details Diff |
Fixed issue 07895: Quota are not tested for hidden question (relevance to 1) New feature 09066: afterSurveyComplete aren't call from Quota : afterSurveyQuota Dev: update all function needed for quota system |
Affected Issues 07895, 09066 |
|
mod - application/helpers/common_helper.php | Diff File | ||
mod - application/helpers/expressions/em_manager_helper.php | Diff File | ||
mod - application/helpers/frontend_helper.php | Diff File | ||
LimeSurvey: master 2bef7def 2014-07-05 17:28 Details Diff |
Dev: 09066 child : use autoload_url for quota |
Affected Issues 07895, 09066 |
|
mod - application/helpers/frontend_helper.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2014-06-04 11:58 | DenisChenu | New Issue | |
2014-06-06 16:15 | c_schmitz | Note Added: 30069 | |
2014-06-06 17:47 | DenisChenu | Note Added: 30073 | |
2014-06-11 15:39 | mdekker | Note Added: 30080 | |
2014-06-11 15:46 | mdekker | Note Added: 30081 | |
2014-06-11 17:06 | DenisChenu | Note Added: 30084 | |
2014-07-01 18:19 | DenisChenu | Note Added: 30253 | |
2014-07-01 18:20 | DenisChenu | Note Edited: 30253 | |
2014-07-01 18:21 | DenisChenu | Note Edited: 30253 | |
2014-07-02 18:36 | DenisChenu | Changeset attached | => LimeSurvey master 0bbcb174 |
2014-07-02 18:36 | DenisChenu | Note Added: 30257 | |
2014-07-02 18:37 | DenisChenu | Assigned To | => DenisChenu |
2014-07-02 18:37 | DenisChenu | Status | new => assigned |
2014-07-05 17:14 | DenisChenu | Changeset attached | => LimeSurvey master 53503581 |
2014-07-05 17:14 | DenisChenu | Project | Bug reports => Feature requests |
2014-07-05 17:15 | DenisChenu | Status | assigned => resolved |
2014-07-05 17:15 | DenisChenu | Fixed in Version | => 2.05+ |
2014-07-05 17:15 | DenisChenu | Resolution | open => fixed |
2014-07-05 17:15 | DenisChenu | Note Added: 30278 | |
2014-07-05 17:15 | DenisChenu | Status | resolved => feedback |
2014-07-05 17:15 | DenisChenu | Resolution | fixed => reopened |
2014-07-05 17:16 | DenisChenu | Status | feedback => resolved |
2014-07-05 17:16 | DenisChenu | Resolution | reopened => fixed |
2014-07-05 17:30 | DenisChenu | Changeset attached | => LimeSurvey master 2bef7def |
2015-08-21 15:51 | c_schmitz | Status | resolved => closed |