View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
08947Bug reportsPluginspublic2014-06-18 16:40
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05+ 
Target Version2.06+Fixed in Version2.06+ 
Summary08947: Unable to see undersocre in plugin settings (and some other CSS issue)
Description

When we have a text element in plugin settings, we are unabe to see underscore (for exemple)

Additional Information

Think it's best to remove a lot of css and use bootsrap here (and after everywhere).
http://getbootstrap.com/2.3.2/base-css.html#forms

.form-horizontal
.control-group
etc ...

Can take it

TagsNo tags attached.
Attached Files
Bug heat8
Complete LimeSurvey version number (& build)140409
I will donate to the project if issue is resolvedNo
BrowserFF 28
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2014-04-12 18:46

developer   ~29721

Bootstrap style ?

sammousa

sammousa

2014-04-22 15:23

reporter   ~29843

By the way, this is actually bootstrap style.

It just goes wrong with the dreaded box-sizing.

Since we have (and i think we should keep) * { box-sizing: border-box } in our css.

We should however change this to exclude text inputs:

  • { box-sizing: border-box; }
    input[type=text], input[type=password] { box-sizing: content-box; }

Also dont forget vendor prefixes.

DenisChenu

DenisChenu

2014-04-22 15:26

developer   ~29844

Last edited: 2014-04-22 15:28

Yes, but bootstrap Horizontal form need:
.form-horizontal : easy
.control-group : easy
.control-label : done
.controls : to do (Wrap any associated controls in .controls for proper alignment).

PS:

  • { box-sizing: border-box } i realy dislike the in css
    Think
    must be html, body, div, span, applet, object, iframe, h1, h2, h3, h4, h5, h6, p, blockquote, pre, a, abbr, acronym, address, big, cite, code, del, dfn, em, img, ins, kbd, q, s, samp, small, strike, strong, sub, sup, tt, var, b, u, i, center, dl, dt, dd, ol, ul, li, fieldset, form, label, legend, table, caption, tbody, tfoot, thead, tr, th, td, article, aside, canvas, details, embed, figure, figcaption, footer, header, hgroup, menu, nav, output, ruby, section, summary, time, mark, audio, video
DenisChenu

DenisChenu

2014-04-22 19:00

developer   ~29847

Last edited: 2014-04-22 19:02

@sammousa : what is the idea to use * { box-sizing: border-box; } ?

We really don't need it and we have to remove too:
.settingswidget .setting > input, .settingswidget .setting > textarea {
width: 60%;
}
ANd more : why force height AND line-height to 30px : this broke multi line lable.

PS: we already have form30 and form40 css class, why add an womplete new system ....

DenisChenu

DenisChenu

2014-05-27 20:21

developer   ~30025

Started here : https://github.com/Shnoulle/LimeSurvey-shnoulle/tree/206-pluginsettings

DenisChenu

DenisChenu

2014-05-29 16:43

developer   ~30032

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14228

c_schmitz

c_schmitz

2014-06-18 16:40

administrator   ~30177

LimeSurvey 2.05+ Build 140618 released.

Related Changesets

LimeSurvey: 2.06 132ba28a

2014-05-29 14:43:42

DenisChenu

Details Diff
Fixed issue 08947: Unable to see underscore in plugin settings (and some other CSS issue)
Dev: add some bootsrap style, get bootsrap 3.1 for width of label and controls
Dev: allow to save without quit in plugin settig
Dev: use autosublit select save actual settings
Affected Issues
08947
mod - application/controllers/PluginsController.php Diff File
mod - application/core/plugins/AuthLDAP/AuthLDAP.php Diff File
mod - application/extensions/SettingsWidget/SettingsWidget.php Diff File
mod - application/extensions/SettingsWidget/assets/settingswidget.css Diff File
mod - application/extensions/SettingsWidget/assets/settingswidget.js Diff File
mod - application/views/plugins/configure.php Diff File

Issue History

Date Modified Username Field Change
2014-04-09 12:43 DenisChenu New Issue
2014-04-09 12:43 DenisChenu File Added: Capture du 2014-04-09 12:32:57.png
2014-04-12 18:43 c_schmitz Assigned To => DenisChenu
2014-04-12 18:43 c_schmitz Status new => assigned
2014-04-12 18:43 c_schmitz Target Version => 2.06+
2014-04-12 18:46 DenisChenu Note Added: 29721
2014-04-22 15:23 sammousa Note Added: 29843
2014-04-22 15:26 DenisChenu Note Added: 29844
2014-04-22 15:28 DenisChenu Note Edited: 29844
2014-04-22 19:00 DenisChenu Note Added: 29847
2014-04-22 19:01 DenisChenu Note Edited: 29847
2014-04-22 19:02 DenisChenu Note Edited: 29847
2014-05-27 20:21 DenisChenu Note Added: 30025
2014-05-29 16:43 DenisChenu Changeset attached => LimeSurvey 2.06 132ba28a
2014-05-29 16:43 DenisChenu Note Added: 30032
2014-05-29 16:43 DenisChenu Resolution open => fixed
2014-05-29 16:49 DenisChenu Status assigned => resolved
2014-05-29 16:49 DenisChenu Fixed in Version => 2.06+
2014-06-18 16:40 c_schmitz Note Added: 30177
2014-06-18 16:40 c_schmitz Status resolved => closed